Ok, I'm also posting an update to the feature in a few minutes, maybe it fixes some bug that I hadn't noticed.
Comment has been collapsed.
Oh ok, because I don't see how blacklist check could give false positives, since the blacklist error message has priority over any other error message.
And yes, whitelist check currently gives false positives because of whitelist / group giveaways. It will be fixed in the next version.
Comment has been collapsed.
blacklist caching gets stuck currently until next update. at once point during the scan it probably was a blacklist (even if just for a few mins / accidental click), and since it has that tag it hasn't been able to update it.
i got two users like that myself too where it claims a blacklist when i'm not actually blacklisted. both mine were indeed actual blacklists upon the original scan though but since then have removed me from it.
it's known though and supposedly will be fixed in the next update. ^^
Comment has been collapsed.
i'm pretty sure there are false positives too.. it claims i'm whitlisted by 91 out of 255 members in one group. while i do believe i am highly whitelisted within that group, i'd only estimate ~65-70 whitelists are actually legit instead of the 91 it claims.
Comment has been collapsed.
not significant, but the text is overlapping whatever is above it (even here on the discussions page it is overlapping my "created" discussions button)
i'd just move the text to below the box and i think that would solve it everywhere (not 100% sure though) / or shift it down a little bit
Comment has been collapsed.
Looks like it only happens with user style enabled, I'll check it out.
Comment has been collapsed.
Comment has been collapsed.
Comment has been collapsed.
Did you check "Full Check"? If not, it will only perform a blacklist check.
Comment has been collapsed.
You can hover over the question mark to see the explanation.
Comment has been collapsed.
ahh okay, neither one are checked by default for me on any pages though. so the "leave it checkmarked" isn't quite right for me.
but thanks, my quick attempt at hovering failed initially, but hovering works fine for me now.
edit: yes latest update fixed the overlap issue above though ^^
Comment has been collapsed.
Noted. I'll either check them by default or change the text to "check this" in the next version.
Comment has been collapsed.
Comment has been collapsed.
Good God... xD
Comment has been collapsed.
Hello,
I tried the Whitelist / Blacklist Checker on a person who had whitelisted me and it said me that it was not able to find it out. The person didn't have a WL giveaway there but there were some WL/Group GAs where I was not a member of the group so it could be detected that I am whitelisted. Is possible to work with the group list and use the info for deciding whether the user whitelisted me or not?
Comment has been collapsed.
Yeah, there was an issue with whitelist / group giveaways that should be fixed now.
Comment has been collapsed.
I don't follow. It freezes just by opening or after running the checker?
Comment has been collapsed.
I assume you can't access the settings page then. Could you add this line to the beginning of the script and see if it's still happening?
GM_setValue("WBC", { Name: "Whitelist / Blacklist Checker", Enabled: false });
Comment has been collapsed.
I was just able to reproduce it with endless scroll support enabled. Will see if I can find what's causing it.
Comment has been collapsed.
there may need to be a limiter or timeout on checking? the latest update seems to work (accurately) for 3 out of 4 groups i've checked, but it keeps hanging on user 251 out of 253 for the 4th group.. it has hung there for 10+ minutes twice, so i've yet to see the results on that group.
i have a feeling it will eventually go thru, but i think it's a user that has 10k seperate giveaways and does the same thing when you load their "sgtools sent" page up. -- for speed reasons maybe add a timeout though or only scan the latest 2k GAs and just have those kind of users move to the "not enough information" results??
edit: for testing reasons i don't think anyone from that group would mind = https://www.steamgifts.com/group/GbNZO/deltachalos/users
Comment has been collapsed.
My check for that group finished in less than 5 minutes, but of course yours will take longer since you are a member of the group. I'll see about a timeout. You could add this line
console.log(User, NextPage);
at the beginning of the function checkWBCUser
and it will show the progress in more detail on the console, if you want to check if there's a problem occurring.
Comment has been collapsed.
oh, i didn't even think to check the console.
VM133:86 SteamGifts Library Checker Injecting SteamGifts Group Page
VM133:889 Creating button/progress bar on SteamGifts...
VM133:446 Getting user counts from main group page from SG...
VM133:455 Setting user pages for 253 users (11).
VM133:921 Library checking button loaded without errors.
VM124:1764 Uncaught TypeError: Cannot read property 'getAttribute' of undefined
at Function.eval (eval at E_c (:1:1), <anonymous>:1764:38)
at <anonymous>:2:297
at eval (eval at exec_fn (:1:108), <anonymous>:27:337)
VM124:1764 Uncaught TypeError: Cannot read property 'getAttribute' of undefined
at Function.eval (eval at E_c (:1:1), <anonymous>:1764:38)
at <anonymous>:2:297
at eval (eval at exec_fn (:1:108), <anonymous>:27:337)
edit:
function checkWBCUser = line 1338 ??
Comment has been collapsed.
Looks like the problem is happening in line 1456, but I can't find the source of it yet.
checkWBCUser function is in line 1357 here:
function checkWBCUser(Context, User, URL, NextPage, FullCheck, Callback) {
Comment has been collapsed.
that line is 1372 for me on version 2.4.4
changed it to
console.log(User, NextPage); function checkWBCUser(Context, User, URL, NextPage, FullCheck, Callback) {
and with that the cosole results are
VM897:3 ERROR: Execution of script 'rhSGST' failed! User is not defined
(anonymous) @ VM897:3
(anonymous) @ VM897:4
(anonymous) @ VM897:1778
(anonymous) @ VM890:2
E_c @ VM890:3
E @ VM892:56
create @ VM892:64
z @ VM892:13
runListeners @ VM892:13
(anonymous) @ VM892:65
aa @ VM890:9
e @ content.js:6
send @ content.js:8
(anonymous) @ content.js:25
processQueue @ content.js:3
a @ content.js:10
VM897:3 ReferenceError: User is not defined
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:114), <anonymous>:1683:14)
at <anonymous>:2:297
at eval (eval at E_c (:3:114), <anonymous>:3:1)
at eval (eval at E_c (:3:114), <anonymous>:4:3)
at Object.eval (eval at E_c (:3:114), <anonymous>:1778:6)
at <anonymous>:2:297
at Object.E_c (<anonymous>:3:112)
at E (eval at exec_fn (:1:108), <anonymous>:56:175)
at Object.create (eval at exec_fn (:1:108), <anonymous>:64:282)
at z (eval at exec_fn (:1:108), <anonymous>:13:88)
VM899:49[RIBBIT] - SGT Mode Activated!
VM907:86 SteamGifts Library Checker Injecting SteamGifts Group Page
VM907:889 Creating button/progress bar on SteamGifts...
VM907:446 Getting user counts from main group page from SG...
VM907:455 Setting user pages for 253 users (11).
VM907:921 Library checking button loaded without errors.
VM897:1764 Uncaught TypeError: Cannot read property 'getAttribute' of undefined
at Function.eval (eval at E_c (:3:114), <anonymous>:1764:38)
at <anonymous>:2:297
at eval (eval at exec_fn (:1:108), <anonymous>:27:337)
(anonymous) @ VM897:1764
(anonymous) @ VM890:2
(anonymous) @ VM892:27
VM897:1764 Uncaught TypeError: Cannot read property 'getAttribute' of undefined
at Function.eval (eval at E_c (:3:114), <anonymous>:1764:38)
at <anonymous>:2:297
at eval (eval at exec_fn (:1:108), <anonymous>:27:337)
those "Uncaught TypeError:"'s all occured prior to the 251st persons scan, but it still freezes for me on user 251.
i hope the info means something to you, it certainly doesn't to me. ;)
Comment has been collapsed.
It actually should be like this:
function checkWBCUser(Context, User, URL, NextPage, FullCheck, Callback) { console.log(User, NextPage);
Comment has been collapsed.
ahh okay, i didn't think that looked right. now the console results are massive but i don't think anything really useful.. it does repeat the same persons name 3x though and then just freezes up and nothing more in the console.
username 21
username 22
username 23
-- don't wanna get in trouble for calling out so ofc its anonymous but it was the same user 3x repeated before the freeze. unsure if they are the source or if that's just coincidence though.
Comment has been collapsed.
So it looks like it's freezing in page 22 of that user. Could you go to their profile at that page and check if there are any whitelist / group giveaways there and if you can enter them?
Comment has been collapsed.
Let's try narrowing it down then, if that's ok with you. Change line 1450 to:
Groups = Context.getElementsByClassName("table__column__heading"); console.log("Groups Length: " + Groups.length);
Then check your console. It should never output "Groups Length: 0".
Comment has been collapsed.
our line's were not the same earlier and i don't think they are now either. 1450 currently is
Groups = Context.getElementsByClassName("table__column__heading");
better then number if you don't mind just giving me before and after codes instead. xD
edit: nvm they are the same now that i see them at the same place. changing now.
Comment has been collapsed.
I checked the line in the Greasyfork version because the one I have installed has some modifications. xD
Comment has been collapsed.
now console last few results before the hang:
username 21
14VM54:1761 Groups Length: 2
VM54:1683 username 22
22VM54:1761 Groups Length: 2
VM54:1683 username 23
11VM54:1761 Groups Length: 2
VM54:1761 Groups Length: 1
(anonymous user with username) -- even though i'd only be calling them out as a good gifter ^^
Comment has been collapsed.
To save time, you could try checking that user individually instead of checking the whole list again.
Comment has been collapsed.
So the individual check works? Looks like the problem is happening after that user then, but the next user should have been shown in the console.
Let's try something else... Go down 2 lines from your last edit and change the line to:
do { console.log("Group Value: " + J);
It should never output a value less than 0.
Comment has been collapsed.
same username 23 (page 23)
then:
Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 2
VM54:1763 Group Value: 1
VM54:1763 Group Value: 0
VM54:1761 Groups Length: 1
VM54:1763 Group Value: 0
edit: but yes, individually checking that user works fine.
Comment has been collapsed.
Since all the values were above or equal to 0, I don't expect this test to change anything, but let's try changing the line below the last edit to:
console.log("Group: ", Groups[J]); Group = Groups[J].getAttribute("href").split("/group/")[1].split("/")[0];
This is the line that's giving the error because it says it can't get the property getAttribute
of undefined, so look for "Group: undefined" in the console.
Comment has been collapsed.
ahhh, that finally might of revealed something.. i am not in "German Giveaways" group but i am however in https://www.steamgifts.com/group/o2VtM/germangamercommunity
so i think it is hung up confused maybe?
edit: that group seems to be the scan from the same user that it doesn't get hung up on though when i individually scan them. so idk if that is new info really.
full screenshot of console:
Comment has been collapsed.
Nah, it checks with the group ID, and it's obviously defined so I don't know where the error is coming from. But... you say that's the full screenshot of the console, it didn't give the error this time?
Comment has been collapsed.
the only 2x errors that occured were way early on in the scan, something like user 43 & user 147 both have a really quick error fly by, but it's nowhere near the time it hangs up.
i meant the full unedited ending of the log though in the screenshot.
Comment has been collapsed.
Oh I thought it wasn't continuing because of this error. Well that changes things.
Ok let's try changing line 1347 to this:
function setWBCResult(Result, User) { console.log(Count, Result, User);
Comment has been collapsed.
no it skips right thru those errors just fine and continues on for quite a while until the end of the 251st person, which this time the console log shows it approving said person as a whitelister, but still doesn't seem to say anything after that.
edit: i've been leaving the scan going each time until i get new code and it still never has moved even 30-40mins later
Comment has been collapsed.
That's the issue. It sits on 251 of 253 forever waiting for those 2 users that got an error, but since they got that error, they never came / will come through. Can you locate the errors in the console and check groups length and value before them? You can remove the screenshot if you want.
Comment has been collapsed.
i see, okay xD
and there is deff too much info here to be misconstrued into a call-out so these console screenshots should be entirely safe.
https://imgur.com/a/mA4Cf
Comment has been collapsed.
There you go, groups length equal to 0. That shouldn't be happening, so let's see why it is. Add this at the end of line 1445:
console.log(WhitelistGroupGiveaways[I], ResponseText.match("you're not a member of the giveaway creator's whitelist"));
Then check your console before those 2 users.
Comment has been collapsed.
Ah why didn't I think of that... Ok, so replace line 1449 with this block and it should work now.
} else if (ResponseText.match("giveaway is restricted to the following region")) {
Callback();
} else {
Comment has been collapsed.
If you saw this while it was Callback("Whitelisted")
, I changed it to Callback()
, because it doesn't necessarily mean you're whitelisted if you see the region restricted message.
Comment has been collapsed.
Your line 1449 isn't } else {
? Well, that line. 1448 then, I guess.
Comment has been collapsed.
Haha ^^
You were great. xD Thanks for having the patience to do it. I'll have to revise the rest of the code because I'm sure this error also happens if the only whitelist giveaway an user has created is region restricted and I'll try to push an update later today.
Comment has been collapsed.
Just pushed the official fix, I hope I didn't mess it up. xD Could you test it again?
Comment has been collapsed.
Comment has been collapsed.
Great tool
i'm finding people entering my gibs who don't make alot of sent gibs but still blacklisted me? for what purpose? all this means is that they will be able to enter less gibs.
but much better i am finding alot of people to add to my white lists.
Comment has been collapsed.
Would a distinction between two scopes be enough?
Comment has been collapsed.
For me, I would prefer not to have it on main page and related pages, like new GA, group GA, and discussions. But I'm ok with it everywhere else.
The reason for me is mostly due to a conflict with Extended Steamgifts feature of "Active discussions in sidebar" which shows up in the main page, new GAs page (giveaways/search?type=new), group GAs (giveaways/search?type=group), whislist GAs, recommended GAs.
Image 1: rhsgst enabled, you can see that the display of the page get on top of the active discussions, also since the WL/BL checker is on top of the active discussions I have to scroll down to see them, while without rhsgst I can see most of them on my screen without needing to scroll down.
Image 2: rhsgst enabled, when you scroll down the text gets one on top of the other, making a mess. T_T
Image 3: rhsgst disabled, and everything looks neat. Even if I scroll down, that side panel stays the same, it's fixed to the sidebar.
Comment has been collapsed.
Simple check is the default (not checked). I'll clarify it in the next update.
Comment has been collapsed.
Hehe, ok. You have to switch yourself from programmer mode to text writer mode. :)
~It is a theory by a programmer called David Grudl. He says that while you are programming, you are not able to write good understandable texts for users such as description, error codes and so on. If you do it, the text will not be very good. So you should first program and then write texts.
I think it is true.~
Comment has been collapsed.
True, I often write stuff that I think are very clear and it turns out they're not. :P I hope it's better now in the new version.
Comment has been collapsed.
you probably already hate me enough, and this one is completely harmless but i thought i'd let you know still... don't kill the messenger :P lol
you're sharing your box with ITAD script on giveaway pages xD
Comment has been collapsed.
@Revilheart yes it was in my inbox, i tried replying from the inbox and from the thread and both times i got 'failed'
Comment has been collapsed.
Can you change line 817 in the script to:
ResponseText = Parser.parseFromString(Response.responseText, "text/html"); if (ResponseText.getElementsByName("xsrf_token")[0].value) console.log("Token found."); else console.log("Token not found.");
Then check your console and see if it outputs "Token found." when you try to reply.
Comment has been collapsed.
(i've turnt it off to see if it lets me reply now)
edit: it lets me reply when i turn it off
how do i do that?
Comment has been collapsed.
Click on the Tampermonkey icon, go to Dashboard
, then find rhSGST
, click on it, locate the line and make the change. To open your console, press Ctrl + Shift + J
. Then try to reply and see if Token found.
or Token not found.
appears in the console.
Comment has been collapsed.
line 817 currently says Comment.appendChild(Parser.parseFromString(Response.responseText, "text/html").getElementById(ReplyID).parentNode.parentNode);
do i copy and paste:
ResponseText = Parser.parseFromString(Response.responseText, "text/html"); if (ResponseText.getElementsByName("xsrf_token")[0].value) console.log("Token found."); else console.log("Token not found.");
Comment has been collapsed.
The script updated so I don't know which line it is in the version you're using. Basically search for this line:
ResponseText = Parser.parseFromString(Response.responseText, "text/html");
Then at the end of it paste:
if (ResponseText.getElementsByName("xsrf_token")[0].value) console.log("Token found."); else console.log("Token not found.");
Comment has been collapsed.
Are you still getting this with the latest update?
Comment has been collapsed.
If I am on a GA page or anywhere and I check the page for BL/WL, the script will tell me that I didn't WLed myself. No matter if I wrote something on the page or not, above the main textarea, there is my avatar and link to my profile - so I expect, the script takes my name and checks it for WL as well.
You should exclude the users (the ones who execute the script) of the script from checking...
Comment has been collapsed.
hahaha sorry.. one last thing i noticed. disabling the "Whitelist / Blacklist HighLighter" also disables the "Whitelist / Blacklist Checker" even with it still being check-marked. not that i normally keep the highlighter turned off anyways, but i realized that during the screenshots earlier. instead of disabling the highlighter i extended the console over peoples names so the screenshots didn't show who all i whitelist to possibly make some people jealous. but it's still worth reporting. :P
Comment has been collapsed.
correct, no longer happens in 2.5+
also yes, the official region restriction fix still works for me ^^
only other thing i haven't said that i have noticed is each and every time there is an update it re-enables all the features rather then leaving those settings alone. (i disable notes and better replies, and now will be disabling footer)
thanks for the update btw ^^
Comment has been collapsed.
Every update? It happened with v2.5 because I moved the location of the settings, but it shouldn't happen with every update.
Comment has been collapsed.
Comment has been collapsed.
Comment has been collapsed.
A few notes and questions about the last version:
Comment has been collapsed.
Comment has been collapsed.
I think it's being caused by the Fixed Elements feature or by whatever script is injecting that sgtools box. Could you try disabling one at a time and see if it fixes it?
Comment has been collapsed.
I found the reason. It's Steamgifts++ v0.4.7beta. As soon as I disable that script, the issue is gone.
Comment has been collapsed.
I believe it's because SteamGifts++ also has a Fixed Elements feature. Is yours enabled?
Comment has been collapsed.
The individual check is back to the sidebar panel.
Comment has been collapsed.
That's a better location.
Playing with the unified button, It doesn't seem to remember the settings across tabs. This means that if I'm doing whitelist/blacklist cleanup and open many tabs for different users, they all start with the same baseline, which is all three checkboxes are checked (which is very slow). To me it makes more sense that when a user checks another user's profile, they only care to check if they are whitelisted or blacklisted by that user. They don't really care about his/her winners. Where as when one checks the entries of a specific giveaway, they are interested in this information for multiple users.
Comment has been collapsed.
I don't follow. All three checkboxes checked is the same as the individual check.
Comment has been collapsed.
Also, if you're doing a whitelist / blacklist cleanup, you could just run the checker on your whitelist / blacklist pages instead of opening each user in a different tab.
Comment has been collapsed.
Comment has been collapsed.
2things, updating now no longer resets the settings menu.
and sadly another conflict found:
fixed header messes up the button for bookmarks -- sgt frogs fixed header doesn't though if that maybe helps. https://www.steamgifts.com/discussion/kceto/userscript-sg-bookmarks-save-giveaways-for-later-use
i switched from SGT Frogs fixed elements to yours, till i realized that (switched back for now)
edit: also i don't actually see the individual check on the sidebar or anywhere at all anymore. just the multi-checker.
Comment has been collapsed.
Were you previously seeing it in your own profile?
Comment has been collapsed.
Have you checked someone else's profile? It shouldn't appear in yours.
Comment has been collapsed.
to extend what i was saying about the fixed header a little further, i realized that the button on the header for sg bookmarks still works, but the top bookmarked result pops-up behind the header instead of below the header like it did with sgt-frog's fixed header. (in my case i only had one bookmark result at the time so i didn't even see it -- further testing i realized that)
Comment has been collapsed.
You shouldn't have both turned on at the same time though. :P
Comment has been collapsed.
no, i thought i did. i read into the way a few different scripts did the fixed header, and this scripts header is the only one i have issues with. but trying the various codes from other scripts inside this one, breaks one thing or another. that latest one i thought solved all my issues, but i didn't actually scroll down to realize it didn't even sticky the header anymore. lol
Comment has been collapsed.
Was planning an update today so i'll toss in a solution for Sgv2 Dark users at least, will revisit again if things change.
Comment has been collapsed.
sounds great to me, thanks. ^^
(am and always will be a user of the script version of it)
closest i got to fixing it inside this script was making the height 0 instead of auto, or changing the z-index from 999 to 1, but both those looked horrible to the way other fixed header scripts work. it opens up SG Bookmarks scripts first bookmark right on top of the header instead of dropping down and starting the top of the list right below the bottom of the header.
Comment has been collapsed.
Comment has been collapsed.
26 Comments - Last post 3 minutes ago by Jarda
48 Comments - Last post 8 minutes ago by Cim
31 Comments - Last post 45 minutes ago by Pika8
16,295 Comments - Last post 1 hour ago by Haplodh
1,519 Comments - Last post 1 hour ago by Tristar
1,798 Comments - Last post 1 hour ago by Cacciaguida
543 Comments - Last post 2 hours ago by Aristofop
6,280 Comments - Last post 2 minutes ago by fengskipper
83 Comments - Last post 5 minutes ago by Kyog
3,368 Comments - Last post 49 minutes ago by ba2
90 Comments - Last post 59 minutes ago by Swordoffury
107 Comments - Last post 1 hour ago by QSO
28,245 Comments - Last post 1 hour ago by Gamy7
68 Comments - Last post 1 hour ago by Thexder
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.