Found a minor weird bug, but it's reproducible for me:
When i check the comment history in the new User Stats, only the first comment is loaded.
Edit: also the popups for comment history and recent username changes are misplaced here.
Btw: can you expand User Stats by the possibility to sort also by the new columns?
Comment has been collapsed.
Ah, I knew I was forgetting something. I just pushed an update that adds a feature called Tables Sorter which allows you to sort by the columns, but I forgot to look into the bug, doing it now.
Comment has been collapsed.
Weird, they lead to the right places for me. Does it happen everywhere?
Comment has been collapsed.
Seems only happening on the mainpage. Loaded the first five pages on my profile and the links were correct there.
Still i somehow felt that these were unnecessary now since they lead to unobvious points on the page because the former seperators are missing now.
Comment has been collapsed.
They lead to exact points to me. The only place they could lead to unobvious points is in Grid View. Plus even when leading to unobvious points in Grid View, it's still a nice tool to orient yourself, so I disagree that they're unnecessary.
Comment has been collapsed.
On a discussion page with only one page of comments here for exemple, the comments don't load.
if I disable 1.21.6. Enable reverse scrolling it shows the comments again.
Uncaught TypeError: Cannot read property 'innerHTML' of undefined
at getNextPage (eval at E_c (:3:221), <anonymous>:30927:54)
at Function.onload (eval at E_c (:3:221), <anonymous>:5617:21)
at <anonymous>:2:398
at eval (eval at exec_fn (:1:108), <anonymous>:31:494)
Comment has been collapsed.
I just fixed this, are you sure you're on the latest version?
Comment has been collapsed.
I was about to report a similar experience. Both before and after just updating, same thing still.
If I come to this thread, not a single comment loads.
I can click the link under the OP for the last page, and then it loaded just where these few comments are.
Which then, also is not reversed.
EDIT: Just checked, and yeah turning off reverse scroll allows comments to load, starting with the oldest/first one.
Turning reverse back on once again causes no comments to load.
Comment has been collapsed.
Ah, ok, none of those are really errors.
Try opening the "Ctrl + Shift + J" console instead.
Comment has been collapsed.
No idea. How would that even happen, a setting?
When I scroll down from an original post, to where the comments should be, the page acts like it's all done loading, seems stable. But, there's not a single comment to be seen.
EDIT: Found the pause button, never noticed it before or knew what it was about. Clicked it, and that seems like it may have been it.
Thanks, sorry for the bother.
Comment has been collapsed.
No, is there a specific reason why you dislike the new method?
Comment has been collapsed.
You can still see the limits of the page through the pagination, it still changes as you scroll down and gets you to the place where the page begins when you click on the number.
But I guess there is a way to enable separators as an option in a way that is not complex and doesn't require much time from me to implement. I'll look into it.
Comment has been collapsed.
Well, it's a bit of trouble, but if I do bring them back, it won't be exactly like before though. For example, if you use Giveaways Sorter, the page would become a bit messy because the dividers would float down or up. But that's the best I can do, because I really don't want to revert the feature back to the way it was, it flows much better now.
Comment has been collapsed.
I think it's the same bug reported by marlop, should be fixed.
Comment has been collapsed.
Added the following features:
- 1.19 Tables Sorter
Would it be possible to have three states of sorting? Beside ascending and descending, i would like to sort it by the page's default on a third click on the same column.
Also i think Blacklist/Whitlist Sorter is kinda redundant now with this feature. ^^
Comment has been collapsed.
Whitelist/Blacklist Sorter still sorts your entire whitelist though, so it's still useful for users with large whitelists who don't want to use Endless Scrolling to load all the pages and then sort them.
Comment has been collapsed.
Added the option to reset the table to its default.
Comment has been collapsed.
Implemented a possible solution for #353. It would be useful if someone could test it if they know they're going to win a giveaway (100% chance) by not opening another tab when the giveaway ends and performing an action in the current tab that makes a request to SG (for example, refreshing a page through Endless Scrolling) to see if the popup appears.
While i looked away for a short time in this discussion, space cat appeared for me on the screen (i think my only request to SG was the header refresher). Popup was a bit misplaced and not centered, but it seems to work.
Comment has been collapsed.
Thanks for confirming. I've added something that should reposition the popup at the center, let me know if it works next time you see it.
Comment has been collapsed.
Displaying 1 to 75 (50 filtered by Giveaway Filters)
text (when all games are filtered) is not counting the games filtered from the last page until the filters are changed in any way Comment has been collapsed.
2 is normal, the enter button is automatically removed for:
Comment has been collapsed.
Well, if the games are hidden one would assume you don't want to enter them, so why show the button? But I'll tie this behavior with Hidden Games Enter Button Disabler in the next version. What the feature currently does is change the "Enter Giveaway" button inside of giveaways to a red disabled button called "Hidden Game".
Comment has been collapsed.
Can you be a bit more specific? What exactly is broken? Are all sorting options broken? And are you sure this is happening in the latest version? I was so sure I had fixed these bugs. :/
Comment has been collapsed.
sure this is happening in the latest version?
yes
Are all sorting options broken?
When it happens yes, filters stop then too.
Just retried, now didn't happen on main, but still does on 2nd install.. it seems to be dependent on some more factors, can't say what but endless scrolling+more than 1 page loaded is minimum to trigger it
Comment has been collapsed.
Ok, but what exactly is broken? The giveaways don't sort when you click on the sort button or they are sorted wrong? Same with filters, they just don't filter? If you disable and enable them, still don't filter? I cannot seem to reproduce this, everything works fine for me.
Comment has been collapsed.
sorted wrong and then sorting again has no effect,
filters filtering out wrong ones then, like it mixes up id's of the GAs
in both grid and normal view
everything works fine for me.
on 2 of 3 browser instances for me too now, 2 switched from bad to good shortly after I posted, can't say why..
Comment has been collapsed.
Hm, well let me know if it happens again on those 2 instances, I haven't found anything wrong in the code, and if I can't reproduce it I cannot know what is causing it at the moment.
Comment has been collapsed.
happens again, and I don't know why, damn...
only entered some GAs, maybe specific patterns or amounts of filtered items cause it
have filter on only for entered ones
but solely affects ones from page 2+ loaded through endl.scroll.
like it inputs those GAs wrongly, making sort&filter not able to access them correctly
Comment has been collapsed.
Could it be that it happens only if you enter giveaways and then scroll?
Comment has been collapsed.
I still cannot reproduce it, loaded 2 pages, filtered a lot of items and it sorted fine.
Comment has been collapsed.
That's expected. I wasn't gonna add divisors back, only did it because some people asked and I told them it was going to be only a visual divisor, not a physical one. The new Endless Scrolling treats all pages as one, so when you sort the giveaways it sorts them all together, not page by page, therefore making the divisors float. Only solution is to disable divisors for the main page.
Comment has been collapsed.
I doubt it.
Before, the reason why it was happening was very specific: giveaways loaded by Endless Scrolling weren't being added to the esgst.currentGiveaways
variable because there was a check that only added giveaways that existed in the page, and since the script runs the features on the content loaded by Endless Scrolling before it's appended to the page, they would never pass that check. So I modified the check to add an exception for giveaways loaded by Endless Scrolling: if (document.body.contains(giveaway.outerWrap) || endless) {
Maybe you can do a console.log(esgst.currentGiveaways);
inside of the filterGfGiveaways
function to see if all the giveaways are there?
Comment has been collapsed.
It includes the pinned ones, although I have 6 pinned ones here, so I got:
Although that is my whitelist view, I only have 1 page in my wishlist view. Does it happen in the main page as well, or only in the wishlist one?
Comment has been collapsed.
Might be something wrong in the exception then. Can you go to updateGfCount
function and log console.log(document.body.contains(giveaway.outerWrap), endless);
after giveaway = esgst[key][i];
just to confirm it? At least one of them should be logged as true.
Comment has been collapsed.
Hmm, I have an idea, can you try with Game Categories disabled?
Comment has been collapsed.
I don't know, maybe you need to install all the updates? Or change the font? http://blog.getemoji.com/post/82224498347/how-to-use-emoji-in-windows-7
Comment has been collapsed.
2 suggestions (sorry for not posting on GH)
separate images viewer (so we can turn off in messages)
and maybe something with this: https://store.steampowered.com/account/registerkey :)
Comment has been collapsed.
I don't understand the first suggestion.
And what do you have in mind for the second one? Adding an option to Steam Activation Links to open the browser page instead?
Comment has been collapsed.
and maybe something with this: https://store.steampowered.com/account/registerkey :)
I got the same idea. I already made a request on Github. :)
Comment has been collapsed.
entering a giveaway is not auto-filtering it after page 1, endless scrolling activated, divisor deactivated, no error in console, FF+GM
tell me if you need more information, i can reproduce this every time
edit: got this error when on a thread, it didn't load the second page until I posted a comment
TypeError: Argument 1 of Node.contains is not an object. ESGST.user.js:23683:21
Comment has been collapsed.
I cannot reproduce it. Are any other filters not working after page 1?
I'll look into the other bug later.
Comment has been collapsed.
I'm not sure yet, I'm confused because the behavior you and Tristar are experiencing I experienced myself before I fixed it in one of the last updates (34.6, I believe). Perhaps a Firefox thing? Someone else is having issues with the script and they think it's because of the most recent Firefox update and its changes. I haven't yet tested on Firefox to verify this.
Comment has been collapsed.
Well, in any case, it should be fixed in the latest version (both bugs).
Comment has been collapsed.
The difference is that the previous bug (which i reported) didn't apply any filter after page 1 if you didn't reload the page itself (so you saw all the entered giveaways in my example).
This bug i can confirm does filter giveaways all over the pages. But if you enter a giveaway after page 1, it won't be filtered and simply fades (vanilla SG behaviour). On page 1 it still filters newly entered GAs though.
Comment has been collapsed.
I am running 6.Beta.34.8, Firefox 55.0.3, Windows 10 x64 Enterprise 1703 build 16275.1000 (pre-release) . The Enter/Leave GA button is no longer visible. How to fix, thanks?
ERROR: Execution of script 'ESGST' failed! assignment to undeclared variable n %20line%203%20%3E%20Function:4:343
getAttachedImages@https://www.steamgifts.com/ line 3 > Function:7591:21
loadEsgst@https://www.steamgifts.com/ line 3 > Function:3606:25
tms_ab43583b_a709_4ac9_b571_4378fb6b1c9b/<@https://www.steamgifts.com/ line 3 > Function:68:5
tms_ab43583b_a709_4ac9_b571_4378fb6b1c9b@https://www.steamgifts.com/ line 3 > Function:65:2
g</<@https://www.steamgifts.com/:2:385
anonymous/<@https://www.steamgifts.com/ line 3 > Function:4:1
anonymous/<@https://www.steamgifts.com/ line 3 > Function:3:55
anonymous@https://www.steamgifts.com/ line 3 > Function:3:2
g</<@https://www.steamgifts.com/:2:385
E_c@https://www.steamgifts.com/:3:209
da@https://www.steamgifts.com/ line 1 > Function:60:417
create@https://www.steamgifts.com/ line 1 > Function:69:26
f@https://www.steamgifts.com/ line 1 > Function:16:235
%20line%203%20%3E%20Function:4:416
Loading failed for the <script> with source “https://cdn.steamgifts.com/js/prebid_v3.js”. www.steamgifts.com:113
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. ExtensionCommon.jsm:306
Comment has been collapsed.
Thanks for your help. But, it is still not working for me.
11:15:27.318 getAttachedImages@https://www.steamgifts.com/ line 3 > Function:7591:21
loadEsgst@https://www.steamgifts.com/ line 3 > Function:3606:25
tms_ab43583b_a709_4ac9_b571_4378fb6b1c9b/<@https://www.steamgifts.com/ line 3 > Function:68:5
tms_ab43583b_a709_4ac9_b571_4378fb6b1c9b@https://www.steamgifts.com/ line 3 > Function:65:2
g</<@https://www.steamgifts.com/:2:385
anonymous/<@https://www.steamgifts.com/ line 3 > Function:4:1
anonymous/<@https://www.steamgifts.com/ line 3 > Function:3:55
anonymous@https://www.steamgifts.com/ line 3 > Function:3:2
g</<@https://www.steamgifts.com/:2:385
E_c@https://www.steamgifts.com/:3:209
da@https://www.steamgifts.com/ line 1 > Function:60:417
create@https://www.steamgifts.com/ line 1 > Function:69:26
f@https://www.steamgifts.com/ line 1 > Function:16:235
1 %20line%203%20%3E%20Function:4:416
Comment has been collapsed.
Click the tab at the top of steamgifts. Most things are turned off by default.
Comment has been collapsed.
Click where it says ESGST, not the drop down bit next to it.
Comment has been collapsed.
Probably a conflict, the script doesn't play well with other scripts. Try checking the console for errors just in case. Or disable all other scripts and see if it loads.
Comment has been collapsed.
Just install and use it. Click on the ESGST button at the header to bring up the menu where you can enable the features.
Comment has been collapsed.
Not sure if this is ESGST issue...
Recently all background download related features (endless scrolling etc) has stopped working. I can see in console this message:
Tampermonkey: couldn't load @require from URL https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js
Tampermonkey: couldn't load @require from URL https://ajax.googleapis.com/ajax/libs/jqueryui/1.12.1/jquery-ui.min.js
Tampermonkey: couldn't load @require from URL https://github.com/dinbror/bpopup/raw/master/jquery.bpopup.min.js
These links are working fine if I click on them. Is it Tampermonkey issue or something else?
Comment has been collapsed.
Was there any Firefox update recently? I know Safari has a problem with loading required files, but I never heard of such a problem in Firefox. Can you test with Greasemonkey to see if it's Tampermonkey-related?
Comment has been collapsed.
No issues here with firefox and tampermonkey.
Last firefox update Version 55.0.3, August 25, 2017
Unless he's not on the release channel
Comment has been collapsed.
Might be a Tampermonkey incompatibility with the recent update then. A bit odd though, since Tampermonkey is supposed to be more compatible than Greasemonkey. Looks like you'll have to stick to Greasemonkey or downgrade until Tampermonkey is fixed.
Comment has been collapsed.
The latest update has all the required files inside of the script, so that bug shouldn't happen anymore.
Comment has been collapsed.
Hi! Your script is really a wonderful and complete one...
I'm here to let you know a bug on the level visualizer that appeared early on today.
I'm also using SGv2 Dark 1.4.6.8.
Basically, the bar shows up as 100% blue (as opposing to part green, part blue, part blank) if the blue part (the part you are going to reach when all your giveaways are set as received) exceeds the total.
Basically, if all the giveaways I made are going to make me level up, the bar will be 100% blue.
Without SGv2 Dark 1.4.6.8 the same happens, but with light green.
Additionally, when hovering over the bar, my current CV is correct, but the one between parethesis (probably the CV I'm going to have after everyone activates my wins) is incorrect.
Please be aware that this is not a complaint but just a feedback. I'm not in any way displeased by this script, I just like your work and wanted to let you know about this little bug. ^^
Comment has been collapsed.
Probably related to this. Did you create all your active giveaways natively through SG or did you use a tool (from this script or from other scripts)? When you created the giveaways did a popup appear asking you to wait a bit until it was added to the storage? And would you be willing to do some debugging to help me find the cause of it?
Comment has been collapsed.
Ah, ok, giveaways created by the script should be normally counted as well.
Well, if you know how to edit scripts, you could go the line that says
projectedFirstBar = `${progress}px`;
and change it to
console.log(cv, percentage, progress); projectedFirstBar = `${progress}px`;
and check the console to see what appears. If not, or you don't have a lot of time, we can do it some other time.
Comment has been collapsed.
Hmm, thanks, I'll do some tests later to see if I find the issue.
Comment has been collapsed.
And thanks for the whitelist, I'll check it out later, but I usually only enter stuff from my wishlist because I have a huge backlog as it is. :P
Comment has been collapsed.
Hey, did you make a lot of unbundled giveaways? It looks like your level is supposed to be 7.20 when your giveaways end. If that is correct, then the only bug is that the feature isn't altering the number before the dot. Although I don't think the bar should be fully covered by only one color (it should be the default color until a certain point and the other color from that point to the end).
Comment has been collapsed.
The latest update should color the bar correctly and show 7.20 in the title (let me know if not). If you think there's an error and you won't actually be 7.20, I could use some more debugging when you have the time. ^^
Comment has been collapsed.
Here I am!
Yes, I did make a lot of giveaways!
The number is fixed (now I'll end up level 7.22)!
The new update fixed the number and the first part of the bar, but in my case, there is no progress bar for the giveaways made and waiting for feedback!
Anyway, it's possible that this happened because the update made the script lose track of the giveaways made and/or because I'm going to level up soon. I'd wait for me to level up before changing anything!
Pics for context.
Comment has been collapsed.
Anyway, it's possible that this happened because the update made the script lose track of the giveaways made and/or because I'm going to level up soon. I'd wait for me to level up before changing anything!
Nope, was a bug. Should be fixed in the latest.
Let me know if you don't go to 7.22 when your giveaways end and are marked as received, because someone else reported that the calculation is wrong, so more feedback would be nice. :)
Comment has been collapsed.
Back I am!
Unfortunately the calculations changed from 7.22 to 6.69 today without me creating any new giveaway.
Anyway, today all but one giveaway ended, leaving me with one and only unbundled 20$ giveaway.
What I noticed is the following: the difference between my future CV and my actual CV became only 0,04.
20 / 500= 0,04! (500 being the difference between CV needed for level 7 and CV for level 6, that is the number used to calculate level at level 6)
This means the reason why the calculations are incorrect is that the level calculator is not taking into consideration giveaways that ended, but are awaiting feedback. Level calculator only uses open giveaways in the formula!
In my case, it's not counting all the bundled giveaways that I made in the last week and that ended today, but it's counting only the Songbringer giveaway worth 20$ CV that's still open and will end on Saturday.
EDIT: Also, just to put in there one more data, the console tells me "20 76 100" with the console.log(cv, percentage, progress) code
Comment has been collapsed.
Thank you very much for this script and all its features, rafaelgs18. (I'm sure I've explored less than half.)
Can someone explain what the settings under the discussion filters do? I mean "[NEW] Comments", "[NEW] <Forum Category>", etc.
Comment has been collapsed.
Ah, sorry again for the lack of documentation, it's something I plan on improving once the script becomes more stable. Discussion Filters now has advanced filters just like Giveaway Filters. There you can choose which filters you want to appear in the filter dropdown (when you click on "Expand filters".
Comment has been collapsed.
Oh, I get it now. Each one of those categories/features lets me change it between the three settings (hide all, show all, show only) in the advanced filters. Thanks. I haven't used the giveaway filters, that might be why I didn't immediately understand these filters.
Comment has been collapsed.
Couldn't you just manually glance through the giveaways to confirm that?
Comment has been collapsed.
DLC filters are working fine for me, can you give me more details? Where does it happen? Is DLC the only filter that is not working or do other filters not work as well? Are there errors in the console?
Comment has been collapsed.
No other filters than DLC - It only filters 11 giveaways out of all giveaways
https://i.imgur.com/k0hf4Kj.png
Actually I have a lots of bugs with the category filter... Trading cards filter combined with max point filter is also very buggy.
Comment has been collapsed.
Discussion Filters has been extended and now has advanced filters just like Giveaway Filters.
Two bugs on this:
Comment has been collapsed.
I have updated the script to 6.Beta.34.14 but I keep getting "There are new updates available for ESGST." notification when browsing discussions and old version warning when entering this thread. I restarted the browser after update, but the problem persists.
Tampermonkey 4.3.6 on Chrome 60.0.3112.113
Comment has been collapsed.
Are there errors in the console? Could you go to the line that says
esgst.version = getValue(`version`, esgst.currentVersion);
and add console.log(esgst.version);
at the end of it to see what appears in the console?
Comment has been collapsed.
Have the same issue as jarkus and my script is still 34.13... any way to force it to update? For some reason it always updates to the latest version way later.
Comment has been collapsed.
The ESGST button at the header has a button called "Update" (you have to click the arrow next to it).
Comment has been collapsed.
Still having the same issue in 6.Beta.34.17. When I visit this thread, it tells me I have an outdated version. Tried updating, but it says no updates are available.
Firefox 55.0.3 (32-bit).
Comment has been collapsed.
The latest version is 34.18. Sometimes GitHub takes a few minutes to update the files, so just try again later.
Comment has been collapsed.
6 Comments - Last post 11 minutes ago by jennie66
28 Comments - Last post 27 minutes ago by FallenKal
16,297 Comments - Last post 1 hour ago by SebastianCrenshaw
52 Comments - Last post 2 hours ago by adam1224
206 Comments - Last post 5 hours ago by Joey2741
31 Comments - Last post 6 hours ago by Pika8
1,519 Comments - Last post 7 hours ago by Tristar
19 Comments - Last post 11 minutes ago by UltraTaber
30 Comments - Last post 14 minutes ago by megusuri
46 Comments - Last post 30 minutes ago by MSKOTOR
7,973 Comments - Last post 30 minutes ago by herbesdeprovence
99 Comments - Last post 31 minutes ago by ashtwo
41 Comments - Last post 43 minutes ago by doubleomurfy
10 Comments - Last post 53 minutes ago by pizurk
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.