ERROR: Execution of script 'rhSGST' failed! Cannot read property 'Members' of undefined
(anonymous) @ VM2721:5
(anonymous) @ VM2721:6
(anonymous) @ VM2721:1761
(anonymous) @ VM2659:2
E_c @ VM2659:3
E @ VM2714:57
create @ VM2714:65
z @ VM2714:14
runListeners @ VM2714:14
run @ VM2714:15
(anonymous) @ VM2714:66
(anonymous) @ VM2714:66
(anonymous) @ VM2714:66
TM_back @ VM2714:67
(anonymous) @ VM2714:67
(anonymous) @ VM2659:2
exec_fn @ VM2659:1
(anonymous) @ VM2659:10
aa @ VM2659:9
e @ content.js:6
send @ content.js:8
next @ content.js:13
(anonymous) @ content.js:26
(anonymous) @ content.js:24
sendResponseAndClearCallback @ VM2656 extensions::messaging:347
messageListener @ VM2656 extensions::messaging:379
target.(anonymous function) @ extensions::SafeBuiltins:19
EventImpl.dispatchToListener @ VM2649 extensions::eventbindings:388
target.(anonymous function) @ extensions::SafeBuiltins:19
publicClassPrototype.(anonymous function) @ VM2655 extensions::utils:149
EventImpl.dispatch @ VM2649 extensions::event_bindings:372
EventImpl.dispatch @ VM2649 extensions::event_bindings:394
target.(anonymous function) @ extensions::SafeBuiltins:19
publicClassPrototype.(anonymous function) @ VM2655 extensions::utils:149
dispatchOnMessage @ VM2656 extensions::messaging:320
VM2721:5 TypeError: Cannot read property 'Members' of undefined
at Window.tms_b1bb311c_f0ce_4e47_a7b0_e867c0a0f312 (eval at E_c (:3:114), <anonymous>:206:35)
at <anonymous>:2:297
at eval (eval at E_c (:3:114), <anonymous>:4:1)
at eval (eval at E_c (:3:114), <anonymous>:6:3)
at Object.eval (eval at E_c (:3:114), <anonymous>:1761:6)
at <anonymous>:2:297
at Object.E_c (<anonymous>:3:112)
at E (eval at exec_fn (:1:108), <anonymous>:57:175)
at Object.create (eval at exec_fn (:1:108), <anonymous>:65:282)
at z (eval at exec_fn (:1:108), <anonymous>:14:88)
Comment has been collapsed.
Comment has been collapsed.
I don't get this. I'm using both rhsgst and "SteamGifts Blacklist/Whitelist Indicator", rhsgst placing a heart before the name, the other script behind it. Yesterday it worked properly and I could turn off rhsgst's Whitelist / Blacklist Highlighter ( I prefer my older script's heart) , but today no matter if I turn off or on it in rhsgst options, the hearts/block icons show up before affected users' names. Any idea why is that happening?
Comment has been collapsed.
Can you add this code add the end of the script and see if it outputs false
in the console?
console.log(rhSGST.WBH);
Comment has been collapsed.
Click on the Tampermonkey icon, go to Dashboard
, then find rhSGST
, click on it and add the code at the end of the script. To open your console, press Ctrl + Shift + J
.
Comment has been collapsed.
Then it's disabled. It shouldn't be showing. Are you using the latest version of the script?
Comment has been collapsed.
That's simply not possible if the output of rhSGST.WBH was false. Can you find this line in the code?
if (Saved && rhSGST.WBH) {
addWBHIcon(Users[User], Saved);
}
Edit: Ah looks like there's the issue. The official release has only Saved
. I fixed it in my version but didn't push it to the public. I'll fix it in the next version.
Comment has been collapsed.
Yeah, that's the issue. I'll be fixing it in the next version, but you can change (Saved)
to (Saved && rhSGST.WBH)
in line 196 until then.
Comment has been collapsed.
Comment has been collapsed.
Hello there, I have a few suggestions:
Comment has been collapsed.
Comment has been collapsed.
I guess I could add it to the settings menu then, since it wouldn't be something that you would be changing all the time, and then I could remove the "Also check whitelist." checkbox if that option is enabled. I'll see if I can push it to the next version.
Comment has been collapsed.
Are you in someone's profile? The checker was removed from all lists in v2.5.5 and now only shows up in the profile pages because cg mentioned it was stressing the servers. I'm working on reducing that load before making it available again.
Comment has been collapsed.
Done. I'll try to bring it back later today if I can implement the solution I thought of.
Comment has been collapsed.
Well, I just put something together, so if you would like to test it, that would be great.
Comment has been collapsed.
I was actually referring to the list checker. I just re-coded it limiting all requests to one request per second and storing each user's state for future checks. Maybe I'll just release it to the public and fix any bugs as they come, like I always do. xD
Comment has been collapsed.
Well, it's extremely slow, but it looks like it's getting the job done. ^^
Comment has been collapsed.
I was actually referring to the Whitelist / Blacklist Checker, I'm bringing it back in a few minutes.
Comment has been collapsed.
I tried it on a few profiles and it seems to be work very well.
I would like to have it on group/whitelist giveaways page, though. You could set a limit for max checked users or check one user per x seconds, or something like that, if the problem is too many request to server. Also you could cache the results so that if people would check it again in a short time, it would not check the users who was checked recently.
Comment has been collapsed.
My few minutes turned into a bug, so I'm fixing it. :P
Comment has been collapsed.
Comment has been collapsed.
Would this be too confusing? The blue heart / red ban would represent if you have them whitelisted / blacklisted and the black heart / ban would represent if they have you whitelisted / blacklisted.
I'm out of ideas. Don't know what other icon I could use other than the heart and the ban. :P
Comment has been collapsed.
What type of giveaways are available in the first page of that user? The failed reply seems to be happening with someone else as well, I'll have to check what's causing it.
Comment has been collapsed.
Are you still getting failed with the latest update?
Comment has been collapsed.
I don't have a lot of experience with Firefox, so I don't know, but I think Greasemonkey might be a better choice, since Tampermonkey for Firefox is quite new and might contain bugs.
Comment has been collapsed.
What if you reload the user's profile after saving the notes? Are they gone as well?
Comment has been collapsed.
You're welcome! Did the notes that disappeared return?
Comment has been collapsed.
Yeah, sorry about that, don't know what caused the bug this time. :/ Make sure you export your notes.
Comment has been collapsed.
I'm sure more people did that as well, or even worse: in the users page. I might have an idea of how to prevent that stress from happening.
Comment has been collapsed.
Please be considerate of our servers. Viewing our logs today, there were quite a few users, each loading 700+ pages a minute due to this add-on.
Comment has been collapsed.
Comment has been collapsed.
Comment has been collapsed.
Next to "Permalink".
Basically there's a bug on SteamGifts that if you post a comment and the OP edited the thread after you opened it, it doesn't save. Discussion Edits Detector fixes that.
Comment has been collapsed.
Comment has been collapsed.
Comment has been collapsed.
Comment has been collapsed.
Well, it currently acts similar to the checker: you can't check lists of users. But I guess if someone opens a lot of tabs... I have an idea to add an hourly request limit for both features, but I'm kind of waiting to see if cg will reply.
Comment has been collapsed.
yeah single user isn't too bad. but for some users it would be a ton of page requests fast (for instance i have 73 sent pages and only 2500 sent GAs, & i've seen some with 10k GAs (mostly individually setup / not multiple copies).
reply to below== yes, it says:
"1 giveaways were not found because the finder does not search in giveaways with multiple copies, but they should be below:"
then lists like 70+ multiple copy (4+) giveaways.
i see why that is then, it only scans the 3 visible winners instead of going to the winners pages.. =)
Comment has been collapsed.
I still don't think that's too bad. Your search lasted what, a bit more than a minute? cg said some users were requesting 700+ pages per minute with the checker, so 73 really doesn't sound like a bad number. But then again, I don't know how much the server can handle.
Yes, requesting each giveaway with multiple copies and then each page of winners of those giveaways is really something I don't want to implement right now. Maybe in the future when this server load thing has been taken care of.
Comment has been collapsed.
I think my problem with the checker is that there was an update where I started sending multiple requests simultaneously instead of waiting for one to complete before continuing to the next one, since the former was a lot faster. Maybe if I reverse it back to dealing with one request at a time, I can add the feature back without even limiting the requests at all then.
Comment has been collapsed.
Yeah, my bad.
I can't switch to server code because I don't have a host and I can't afford one at the moment, nor would the free hosting services available be able to handle the requests. But I think just reverting back to dealing with one request at a time is already better. And I do have an idea on how to reduce the requests a bit more (at least to users that were already checked once) by saving their giveaway so the script doesn't have to go through their profile again to get it.
Reverting it back to dealing with one request at a time, I just performed a check on 76 users and it made 551 requests over the course of 8 minutes. That's on average 69 requests per minute and 1 per second, so I should be good, right?
Comment has been collapsed.
well requests per second can vary depending on users internet, so you may still want to add a limiter in there for those with fiber and ~3-8ms ping replies. those are the users that with multiple tabs could still pull several hundred requests a minute all on their own in theory.
Comment has been collapsed.
from what i can tell i get around 2requests per second average, and revil only gets 1request per second with the current "find the not received" part of the script. and my internet isn't the best really (62ms to sgtools / 50ms to google). those figures are fairly harmless on the server impact, but if there isn't something keeping it down to 3-4 requests a second max then it could start causing stress on the servers again whenever the whitelist scanner/finder returns.
Comment has been collapsed.
Looking forward to that feature, and I'm glad to hear you managed to keep it live. :) I've been avoiding using the API because I think I remember you mentioned something somewhere about limiting our requests.
As to my problem, I came up with a solution: I will limit each user to one request per second, save giveaways of users that were already checked for future checks and cache the results of checked users for 48 hours. Not sure if the best one, but at least it shouldn't stress the servers that much. I thought about maybe using Google Sheets as a database like with my Username History feature, but I don't know if it could handle that. Although it has a limit of 400.000 cells, which to me seems more than enough. I don't know about its request limitations though.
That's pretty awesome. xD
Comment has been collapsed.
In that case I might look into grabbing usernames and SteamID64s from it, since the script uses those a lot.
Yeah, I ended up dropping the Google Sheets thing. It would also be extremely slow to make requests to the sheet. It might be a waste to have multiple users requesting the same user, but nothing I can do about it. At least the requests are limited now. :)
Comment has been collapsed.
Noted :)
Well, all the Whitelist / Blacklist Checker feature would need is the link to a giveaway (if single check) or whitelist giveaway (if full check) or all whitelist / group giveaways (if full check and no whitelist giveaway) from an user. So I would only need the list of giveaways an user has made and then I would do the individual requests to determine if the user requesting it is whitelisted / blacklisted on my side.
Comment has been collapsed.
If you could return the type of the giveaway I don't think there would be need for filters.
Comment has been collapsed.
oh yeah, i don't think it is that bad really either, and it was closer to just ~25 seconds really.
i agree, going to scan winner pages then would be 2+ more page requests and on very large (2k, 10k, etc) multi-copy gas it would cause it to be hundreds of page requests per minute again.
Comment has been collapsed.
As to your "0 not received", it doesn't show something like "x giveaways were not found because the finder does not search in giveaways with multiple copies, but they should be below" and then a list of giveaways with multiple copies?
Comment has been collapsed.
true, i'm one of them. but it's unimportant really. i've yet to be blacklisted since the features release, and i doubt i will ever be over that specifically. my not received mark is due to be removed anytime now (4month old ticket in que for admin), but i just think of it more as a ratio checker. if you see someone that has given 34 keys, but has 6 not received marks, you may want to avoid joining their giveaway versus someone elses. whereas when you see mine having 1 not received to 2500+ sent you can be fairly certain the key/gift will be valid or replaced if it isn't.
Comment has been collapsed.
Comment has been collapsed.
48 Comments - Last post 1 minute ago by Cim
31 Comments - Last post 38 minutes ago by Pika8
16,295 Comments - Last post 1 hour ago by Haplodh
25 Comments - Last post 1 hour ago by lewriczin
1,519 Comments - Last post 1 hour ago by Tristar
1,798 Comments - Last post 1 hour ago by Cacciaguida
543 Comments - Last post 1 hour ago by Aristofop
6,279 Comments - Last post 20 minutes ago by uWWu
82 Comments - Last post 23 minutes ago by hbouma
3,368 Comments - Last post 43 minutes ago by ba2
90 Comments - Last post 52 minutes ago by Swordoffury
107 Comments - Last post 53 minutes ago by QSO
28,245 Comments - Last post 59 minutes ago by Gamy7
68 Comments - Last post 1 hour ago by Thexder
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.