"go to first unread comment of this page" still snaps to read stuff though. sorry i was wasting your time on the last bug. with dark theme (especially customized), there isn't any difference visually.
Comment has been collapsed.
Ah, so the comments are actually read? But what about the discussions page? Is the "(+X)" data being shown correctly?
Comment has been collapsed.
i lost highlights data still, but the discussion comment counters are accurate. and i noticed the "jump to first unread comment" button jumps to the same comment on this page no matter if i unread and re-read or anything.
(i keep reading this one)
i'm not concerned with the highlight data though, i'll just re-highlight.
Comment has been collapsed.
The latest update gets your visited/highlighted data back.
Comment has been collapsed.
thanks, that update did fix them.
related though, when retrieving "load more" it just looped the same 5 results over again.
Comment has been collapsed.
well.... mostly accurate. i don't think there's been 288 comments on this thread since the update. (and i had everything read prior)
Comment has been collapsed.
sounds good. thanks btw for all the feature enhancements. quite a few really good ones. ^^
Comment has been collapsed.
that looks much better for me now, thank you. i was actually just taking a look thru the script seeing if i could find a easy opacity hack and couldnt find one. ^^
and it seems to jump to the correct comment. i still seem to be lacking a little bit of the comment tracker data (~200 comments unread on this thread that shouldn't be), but it's manageable.
Comment has been collapsed.
i almost agreed accept some of my older threads are still marked entirely that i have comments inside of. but ~200 comments in this thread, and ~60 comments inside of the DIG thread i maintain sounds pretty accurate. so maybe only threads i've commented on since "x" date are affected like that?
Comment has been collapsed.
I believe the version that started marking your own comments as read automatically simply showed them as read on the page, but didn't actually save them, so if that's true, all your own comments made since that version are unread. Basically, all your own comments that were automatically "marked as read".
Comment has been collapsed.
yep, everything is marked read now on this thread once again after just quick scrolling thru the last 10pages of it and marking the few comments i missed as read. ^^
wow, i comment a lot more then i think in this thread. xD
Comment has been collapsed.
after going thru all 5 pages of my dig thread it no longer has the (+60) next to it and i didn't mark anything because it was already marked. so i think it is my own comments, but as soon as those pages are loaded it counts them again.
Comment has been collapsed.
You can find the style in these lines if you want to increase it:
".esgst-ct-comment-read, .esgst-ct-visited {"
" background-color: " + Unknown.replace(/rgb/, "rgba").replace(/\)/, ", 0.2)") + " !important;" +The "0.2" is the opacity.
Comment has been collapsed.
that's okay, i'll wait to see what squished does first. but then if i don't like it i'll come back to this comment, thanks. ^^
Comment has been collapsed.
If you prefer the fading option, I can still add that back as an optional feature. I removed it because if you had the mouse over a comment/discussion it could be hard to tell if it's read or not without looking at the eye icon. The background stands out, so it's easier to see it. Plus, this way there's no conflict between the visited giveaway fade and the entered giveaway fade, as well as the visited discussion fade and the closed discussion fade.
Comment has been collapsed.
i kind of prefer fading but it was a little bit dark on fading before. i can get used to this though just fine, or maybe squished might have plans for dark theme in this department too. the difference before was just so minor i couldn't even see it, but i'm pretty adaptable there otherwise.
Comment has been collapsed.
another minor bug or unannounced feature.... it's highlighting or marking giveaways as visited when it didn't before. (not talking about entered game highlighter either)
edit: if feature, i'd prefer a disable option for it.
Comment has been collapsed.
It did do it before, under an optional feature, but I removed the optional feature because the argument that was used to request it was that fading out visited giveaways could be confused with faded out entered giveaways, but now there should be no problem, as they are not faded out anymore.
Comment has been collapsed.
it looks horrible for me tbh compared to before. i still have an "unvisited" giveaway entered and a "visited/entered" giveaway together to see the difference too. tbh, everything looks reverse (read looks unread & vice-versa / entered vs un-entered) but that's probably all stuff squished will do something for.
Comment has been collapsed.
Mmmmm should be an option if you want that enabled or not really.
Comment has been collapsed.
btw, i wasn't gonna pester you but one thing i know is now dark grey broken is the discussion highlighter coloration. but yeah i agree, an option would be nice there. =)
Comment has been collapsed.
thanks, i'd rather stick to fading then get used to something new to be honest. ^^
Comment has been collapsed.
Fading out is the default behavior again in the latest update.
Comment has been collapsed.
i'd say unfade upon hover (like it does now), but see if a light fade tone of yellow or orange highlighter can be applied while it's hovered similarly to the green discussion highlight but in a lighter faded tone. if that's possible anyways.
edit: i'd like that for hovered comments too.
edit2: feature: "Hover Highlighter" xD
Comment has been collapsed.
there's a pretty significant increase in storage space since yesterday it seems.
Comment has been collapsed.
Probably Game Categories? Comment Tracker data should also take a bit more space, since each discussion object now has a key comments and for each comment object there is a key timestamp.
Comment has been collapsed.
ahh okay, i guess it's probably the comment tracker. tbh i was expecting the opposite since i dumped the entire rulecheck scan history. :D
edit: i think that's what was going on too on my initial bug reporting today. it took a long time for it to inflate all of my tracking history to the new formatting and that's why i had so many issues and thought my history was missing. (it probably was missing my first few refreshes)
Comment has been collapsed.
v6.Beta.3.18 http://i.imgur.com/ICeGnQE.jpg
v6.Beta.4.0 - 4.6 http://i.imgur.com/SUnhqNN.jpg
Is it possible to somehow fix this?
Upd Nevermind. It just conflicts with Extended Steamgifts now.
Comment has been collapsed.
I got same problem since I use both of the scripts, did you find any solution other than disabling one of them?:(
Comment has been collapsed.
Downgraded to 3.18 and disabled updates. You can ask rafaelgs18 to disable it since it's intended: https://www.steamgifts.com/go/comment/L7C1Q1q
Comment has been collapsed.
It's not recommended to use old versions of the script. I'll disable it later, as I mentioned in that comment, but is there anything that's holding you to Extended SteamGifts tbh? I believe this script already has all features from it.
Comment has been collapsed.
It looks you are right. So it would be great if the information about the game will be in one line (even if more than one of features are enabled: Giveaway Winning Chance, Giveaway Winning Ratio for example).
Comment has been collapsed.
It makes the row too large, like I said, and that increases the width of the page and can sometimes be troublesome.
Comment has been collapsed.
There is some kind of glitch.
There is only one option chose in settings for me. @ Enter/Leave Giveaway Button@
It began several days ago. Every time I want to enter the giveaway by clicking on giveawaylist page onto green giveaway button, it show pop-up with the giveaway. But it's not for all of the giveaways. It's only for giveaways with some description There was no such thing in the past.. Sir, what can I do in this situation?
Comment has been collapsed.
it's not a bug, it's intended to be that way.
v6.Beta.3.14
Giveaway Description/Comment Box Popup - Upon clicking the Enter/Leave giveaway button, the script now checks for a description. If it finds one, it opens the giveaway in a new tab so you can read it before entering, otherwise it enters the giveaway automatically.
Comment has been collapsed.
you can turn off "Enter/Leave Giveaway Button" ¯\_(ツ)_/¯
or if you really really want... https://www.steamgifts.com/go/comment/lTOpaUo
Comment has been collapsed.
not in the current version of the script, besides my "smartass" answer above of just disabling the enter/leave button entirely. ;)
if you really wanted you could go back to an older version of the script, but anything broken in it wouldn't be supported.
Comment has been collapsed.
it's not a bug, it's intended to be that way.
v6.Beta.3.14
Giveaway Description/Comment Box Popup - Upon clicking the Enter/Leave giveaway button, the script now checks for a description. If it finds one, it opens the giveaway in a new tab so you can read it before entering, otherwise it enters the giveaway automatically.
Comment has been collapsed.
It wasn't a glitch, but I added back the option to disable it.
Comment has been collapsed.
it's not a bug, it's intended to be that way.
v6.Beta.3.14
Giveaway Description/Comment Box Popup - Upon clicking the Enter/Leave giveaway button, the script now checks for a description. If it finds one, it opens the giveaway in a new tab so you can read it before entering, otherwise it enters the giveaway automatically.
Comment has been collapsed.
Why is it intended, though? It just seems unnecessary and an inconvenience compared to simply entering the giveaway when you click the button.
Comment has been collapsed.
depends who you ask. imo it's perfect now. if you enter into a giveaway the least you should do is actually read or glance at the description.
Comment has been collapsed.
It was intended because people complained description should be mandatory to read, then people complained it shouldn't. The people who complained it shouldn't are a larger group than the people who complained it should, therefore I was getting annoyed at all the complaints, so basically the option to disable it it's back.
Comment has been collapsed.
It wasn't a glitch, but I added back the option to disable it.
Comment has been collapsed.
Before and after last update. All the other scripts are turned off.
Comment has been collapsed.
It's intended. If it bothers you, I can disable it. It is that way because of Accurate Timestamps, Giveaway Winning Chance, Giveaway Winning Ratio, Enter/Leave Giveaway Button and User Tags, because they take a lot of room in that column. I'll only enable it if one of those features are enabled later.
Comment has been collapsed.
Please do .I rather turn off accurate timestamps but it looks super off for me that level requirements and group/WL icons unnecessarily take up another row and inflate the page size :\
Comment has been collapsed.
It doesn't even inflate the size though. :S It's in the same line as the entries/comments links. It's just a bit below, so I don't see how people dislike it that much, but I will do it later.
Comment has been collapsed.
Please give us the option to deactivate those popup dialogues, on errors. I get one of those whenever I load a page with giveaways, but there are no errors related to ESGST. And I don't have any issues that would require fixing.
How is development on sorting threads by their date of creation going?
Comment has been collapsed.
If the alert is happening, then there should be errors in the console. Are you sure they are not related?
It's not going, at the moment.
Comment has been collapsed.
There are errors, but they aren't related to your script. There are some for SG++, some for SG Ratings or "SG Mark Threads". None that causes any problems for me.
Comment has been collapsed.
If you disable the other scripts, do the errors stop happening? And are you positive the errors aren't related? When the script logs an error, it doesn't appear as a red error as usual in Chrome, but a normal text log.
Comment has been collapsed.
If I disable ESGST (which I currently have, because of that frequent error message), I receive the same errors as with ESGST. So they certainly aren't related.
Those are the errors I get on https://www.steamgifts.com/giveaways/search?type=wishlist, for example:
Comment has been collapsed.
But did you try enabling ESGST and disabling all others? Does the message say "ESGST has failed to load" or "ESGST features failed to load"?
Comment has been collapsed.
Okay, I activated ESGST and deactivated everything else. No error message. So please, I need the option to turn that message off.
Comment has been collapsed.
I cannot add it. It would allow bugs to go by unnoticed. If you want me to try to fix whatever conflict is happening, you can activate one of the other scripts per time until you find the one that's causing the conflict.
Comment has been collapsed.
Why would the option to opt out be an issue? It's only a reminder to check the console for error reports anyway.
And as I said, there are no conflicts for you to fix. Those errors remain, with ESGST deactivated. It would be up to the other addon authors to fix them.
Comment has been collapsed.
It's not just a reminder. When errors happen they need to be reported so they can be fixed. You don't know that, there could be something I could do on my side.
Comment has been collapsed.
There is a way to use an older version? I don't want to see the irrelevant description everytime, 95% of the giveaways there is no relevant description, only "My first giveaway", "Good Luck"
Comment has been collapsed.
I might have to add the option back. The demand is just too huge at this point. I think making it enabled by default with the option to disable it wouldn't be that bad, since the user would be making a conscious choice in disabling it, like someone else mentioned earlier somewhere.
Comment has been collapsed.
lol i hear ya. i think the few who actually care about descriptions are far outweighed by those who don't care about descriptions at all. xD
Comment has been collapsed.
Please do. This script is too great to have such annoyance :D
Comment has been collapsed.
Thanks!
There is a bug with this option, if you enter a giveaway, leave the giveaway and enter again the description popup shows up even if i choose to not show
Comment has been collapsed.
there are a lot of troubleshooting console logging leftover in the live script, just fyi. ;)
Comment has been collapsed.
Avatar Popout - Completely revamped the feature using the styling from SquishedPotatoe's dark theme (it might also be incompatible with the theme for the moment because of class name changing) (closes #67).
I am not sure if it is a good idea to mix original SG bright design with a dark one inspired by a user style. It's like windows 10 now - something look like this and something like that. :) People who want bright design, use just pure SG and those who like dark design use some user style. Now the people who prefer bright one have to look at some dark stuff.
But it is not such a big deal. Just choose if the elements of your script will be bright or dark.
I would like the shadow of all the element had a bit smaller the shadow, it would look more naturally.
Comment has been collapsed.
The colors are literally the same as they were before, apart from the shadow, so I don't know what you're getting at, really.
Comment has been collapsed.
You are right I didn't realized it was always black. The shadow and buttons confused me after I read the sentence about dark theme. I just compared it with an old screen of the previous version and it looks better for me now. So ok. :)
Comment has been collapsed.
Steamgifts profile image is transparent to let the background color come through a bit, and that color is determined by your user picture. So you can control that to some point by yourself ;)
Comment has been collapsed.
Viewing a deleted giveaway causes an error.
1 ESGST features failed to load: Giveaway Features. Check the console (F12) for errors and report them in the script's discussion/GitHub page.
TypeError: Cannot read property 'textContent' of null
at getGiveawayInfo (eval at E_c (:3:221), <anonymous>:19261:45)
at getGiveaways (eval at E_c (:3:221), <anonymous>:19238:24)
at Object.loadGiveawayFeatures [as load] (eval at E_c (:3:221), <anonymous>:19226:21)
at loadFeatures (eval at E_c (:3:221), <anonymous>:1833:33)
at loadEsgst (eval at E_c (:3:221), <anonymous>:1796:9)
at eval (eval at E_c (:3:221), <anonymous>:412:9)
at Window.tms_e7c654df_9da7_42b9_9214_f3f1a8fb1890 (eval at E_c (:3:221), <anonymous>:20722:3)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
Comment has been collapsed.
Did you remove the option for mark a discussion as visited? I cannot see the buttons for it. It would be really a pity. I used it very much.
Comment has been collapsed.
it's still here for me. i'd check console for errors, and make sure the "comment tracker" is enabled.
never-mind, that one is missing for me as well.
Comment has been collapsed.
Hm, it's strange. Maybe an issue with full storage? But I think it uses just normal browser history, doesn't it? The console is clear, there is just an info about header refresh lock.
[ESGST] 6163a105-c5cb-4b4d-bd65-8b38ea06ac36 waiting to lock sgHeaderRefreshLock...
Comment has been collapsed.
sorry, i edited that one. yeah same is happening to me as well on both. missing that visited checkmark & i have those weird locks in console as well.
Comment has been collapsed.
Giveaway filter doesn't remember max values (for example max entries) when I refresh or go to next page. Min values are working fine.
Comment has been collapsed.
Is anyone else experiencing the Discussions not highlighting anymore? My starred discussions don't get highlighted in the discussion index page and the toggle stars are missing for that page too.
Edit: The actual discussions threads are still getting highlighted though and the stars are showing up as actively filled in ★.
Comment has been collapsed.
I don't really have any scripts that modifies so many things like ESGST.
Comment has been collapsed.
i'm a little curious on why on half of those now though, but nah.. theme's the only one that i think could be doing it.
but half of those scripts are esgst features. :D
Comment has been collapsed.
The last update borked my configuration :(
I have SG++ as well as ESGST running.
I want SG++ for the grid view, giveaway pop-up, hiding of entered giveaways, endless scroll, and to check who of those that entered commented on a giveaway.
I use ESGST for a few things mainly for the avatar pop-out and a few other things not so much related to the giveaway section.
(Configuration: Win7, Opera portable with Tampermonkey)
Since the update I get an error for your script:
"1 ESGST features failed to load: Giveaway Features. Check the console (F12) for errors and report them in the script's discussion/GitHub page"
Console gives me this:
TypeError: Cannot read property 'firstElementChild' of null
at getGiveawayInfo (eval at E_c (:3:92), <anonymous>:19299:67)
at getGiveaways (eval at E_c (:3:92), <anonymous>:19238:24)
at Object.loadGiveawayFeatures [as load] (eval at E_c (:3:92), <anonymous>:19226:21)
at loadFeatures (eval at E_c (:3:92), <anonymous>:1833:33)
at loadEsgst (eval at E_c (:3:92), <anonymous>:1796:9)
at eval (eval at E_c (:3:92), <anonymous>:412:9)
at Window.tms_401199f0_9e64_4779_a3f3_6d72a62d418f (eval at E_c (:3:92), <anonymous>:20722:3)
at <anonymous>:2:270
at eval (eval at E_c (:3:92), <anonymous>:3:1)
at eval (eval at E_c (:3:92), <anonymous>:4:3)Obviously this error results from the usage of both scripts because switching off either one won't give me the error anymore. The thing is, I rather switch off the components from your script that causes the error than switching off SG++ (the grid view there is just a lot better.) Had the error also when the feature "Giveaway Filters" was still activated but then it said "2 ESGST features failed to load...
But even with all options from your script deactivated I still get that error. I cannot even find a feature that is called "Giveaway Features" on the setting site.
Maybe you could look into this. Thank you.
Comment has been collapsed.
Script conflicts aren't really my priority, but let me know if it's fixed with the new update because I changed some things around.
Suggestions to Grid View are always welcome, and to any other feature. I'll be rewritting that feature soon and I'm thinking of showing the info below the giveaway instead of on hover.
Comment has been collapsed.
Thanks for your reply. I finally have some time to answer you in detail.
I fully understand that compatibility (to other scripts) issues cannot be a priority especially since no-one knows what another script might do to a page.
Unfortunately your recent update didn't change anything. I still get the error.
I had a look at your code and while I'm not a real programmer I can (to some degree) make out how programs run. I figured this:
Your function "Giveaway Features" (loadGiveawayFeatures) always runs on the pages /giveaways and some others, even if I don't have any features activated for changing the appearance of that particular page and that seems to cause the hickups (cause I cannot deactivate this function).
I would actually hope that if I deactivate all features your script wouldn't change anything on any page. (Of course that's not completely right, since you'd need at least some code to inject the button and need to check the settings and so on. But I would hope it wouldn't interfere with anything else.)
So the best solution for me would be an option that I could deactivate so that that function wouldn't run anymore. But of course I don't know what you need all the informations for you grab with this function and I understand if you cannot or do not want to change that.
Concerning GridView I will elaborate in another post for the sake of overview.
Comment has been collapsed.
GridView:
I use my browser window in a very defined size and space. Your GridView then scales to two rows only. SG++ still has three rows (it seems as if SG itself has a minimum width for the page and therefore shows me the scrollbar on the bottom. Your script apparently rescales the whole page to the width of the window and thus only shows two rows). This is actually besides the point but it would be nice if I could decide how many rows I want myself rather than have it auto-scale.
I actually really like the info on hover functionality and for my personal taste wouldn't want to have the info on all giveaways at once.
What I like about the gridview of SG++ like more:
- It has always (at least) 3 rows
- The hover info for the giveaway is a lot neater. It has the same size as the game picture, it is very tidy and still has all the infos I need. If I still want to know more (groups, description, enter button, and so on) I click on it and have a pop-up on the same page
What I dislike about the GridView of your script:
- "Auto-scaling" of numbers of rows (which is actually fine, but results in a lot of wasted space for my very special case)
- Hover-Info for the giveaway changes its size according to length of game title
- Hover-Info contains a lot of white (wasted) space
- Level-Info outside of box makes the site look more "scattered"
- Cannot check this right now but I believe your GridView automatically expands all the "featured" giveaways with 50+ copies. So that If there are many of that kind my page is always full with those already and the "real" information (other giveaways) are buried underneath. I'd rather have an option to hide those completely than to expand them.
What I like about your script:
- It still displays the tags from "SG Game Tags"-Script. I only noticed that now, but it's a really nice feature but I don't know if it was intended from you
Please don't take this as a personal criticism which it isn't supposed to be. I find it rather amazing how you are so much involved in this site and spend so much time trying to make this site a better experience for so many other people.
I'm aware that I use the site differently to many others and most of the time only check wishlisted and recommended giveaways anyhow. Thus my preferences probably are a lot different to those of many others. Yet I thought I'd let you know what I think but I totally understand if you don't want to consider any of it =)
Comment has been collapsed.
Thanks for all the suggestions. :)
The problem with it only showing 3 rows is that my Grid View has the level/group/region info outside, so that takes more space. I'll put it in the inside later. And I do have plans on reducing the hover, however the problem is my script injects so many features for giveaways, that shrinking all of that inside of the giveaway image would be impossible (Game Categories and Enter/Leave Giveaway Button would be an issue for example), but I will try to see what I can do.
Comment has been collapsed.
I just upgraded Grid View. Hope it's a bit better, but reducing the hover to the exact size of the image and setting a fixed width for the hover are not very doable things for this script, because of what I mentioned earlier that the script injects a lot of features into giveaways, and the image is too small to contain all that information.
Comment has been collapsed.
Thank you for the heads-up
Unfortunately it doesn't work for me - at all.
I deactivated SG++ and activated Grid View on ESGST - doesn't work.
I deactivated every other script - still doesn't work.
I deactivated every other feature from ESGST besides Grid View and it still doesn't work.
There is nothing in the console.
To be honest, I'm quite happy with my actual setup with both, SG++ and ESGST doing what they can best :) So I'm not so much concerned about it but just wanted to let you know.
Comment has been collapsed.
Comment has been collapsed.
Are there errors in the console? Can you check the class name of the button and see if it's changed? Maybe it's just not changing the background.
Comment has been collapsed.
it's a joke. i'm level 10 as of that approx timeframe. ;)
b.s. excuse for a GA on a fresh page xD
Comment has been collapsed.
Ah, I didn't realize you were level 10 now. Congrats! :)
Comment has been collapsed.
But I think you should continue to make GAs some time or you will get back to lvl 9 and you will be sad.
Comment has been collapsed.
oh yeah, even when i'm safe i still don't plan on stopping at all. maybe slow down a little bit, but certainly not stop. ^^
Comment has been collapsed.
total esgst failed to load with latest update
TypeError: Cannot read property 'replace' of undefined
at getUserStorageV6 (eval at E_c (:3:221), <anonymous>:462:48)
at updateUserStorageToV6 (eval at E_c (:3:221), <anonymous>:431:49)
at loadEsgst (eval at E_c (:3:221), <anonymous>:640:9)
at eval (eval at E_c (:3:221), <anonymous>:412:9)
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:221), <anonymous>:21175:3)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
at Object.eval (eval at E_c (:3:221), <anonymous>:21176:6)
at <anonymous>:2:398Comment has been collapsed.
Yeah, had the same error.
Downgraded to 3.13, but have to downgrade further since that is one of the versions that makes my Tampermonkey jump to 2GB of memory used.
Edit: 3.12 seems to be stable in regards to memory use, for me.
Comment has been collapsed.
Why did you not report that? And why downgrade to such low version? It's in 5.0.
Comment has been collapsed.
I tried 5.0 but has the same error that d3m4n stated. And the previous ones have a conflict with Extended Steamgifts, since EG still has features that I use and some that I visually prefer I'm still using it.
To fix both issues, I had to go to 3.12.
I think I was busy at the time of 3.13, so I just downgraded and then since it was not happening anymore, I kinda forgot... :(
Comment has been collapsed.
I just fixed that error in 5.1. You can always suggest features that you want to see here (I think it already has all features from Extended SteamGifts) or design improvements, if there are some features that are not good looking for you.
Comment has been collapsed.
Tried 5.1.
So far the memory jump is not as high, but still high. It's at 407mb and slowly rising when it used to be below 100mb.
Also I get an error in some pages, but not all. I know that it happens in https://www.steamgifts.com/giveaways/entered:
TypeError: Cannot read property 'setAttribute' of null
at updateFilterCaptionTextColor (eval at E_c (:3:221), <anonymous>:1279:21)
at drawUi (eval at E_c (:3:221), <anonymous>:539:3)
at Window.tms_e4c93caa_0e89_4b77_b748_34a592990f64 (eval at E_c (:3:221), <anonymous>:572:3)
at <anonymous>:2:398
at KEY_EXCLUDE_GROUP_GIVEAWAYS (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
at Object.eval (eval at E_c (:3:221), <anonymous>:1381:6)
at <anonymous>:2:398
at Object.E_c (<anonymous>:3:219)
at E (eval at exec_fn (:1:108), <anonymous>:60:467)
Just now I checked the memory use of TM and it's at 602mb, it went up almost 200mb while writing this comment.
Edit: Had to downgrade again to 3.12, since it was up to 900+mb again. With 3.12 it's at 59mb.
Comment has been collapsed.
To be honest, I'm surprised that with 3.12 it's at 59mb, the script has always consumed around 200mb for me when I'm not doing much. How much does 3.13 use? I don't think there were any significant updates from 3.12 to 3.13.
I get some jumps from time to time when doing stuff, but they eventually clean out and the memory lowers again.
That error isn't mine, so it's a conflict.
Comment has been collapsed.
the memory usage is a little weird here too. and i'm not even really doing anything.
https://imgur.com/a/52Ec5 (large gif, so i didn't want to attach)
edit: it seems to just keep rotating between ~150mb up to ~2.1gb, then back to beginning to restart the process. that just continues to happen.
Comment has been collapsed.
Did it not do that in the previous version? I get those jumps as well, but they eventually clear out, I haven't really observed the memory consumption previously to compare, but I will see if there are any improvements that can be made, maybe I haven't fixed that memory leak yet.
Comment has been collapsed.
yeah, it's been like that a long while now for me tbh. i want to say since ~version 4 or a late 3. i have 16gb of ram though so that's really a small amount in comparison.
Comment has been collapsed.
Ah, ok, I got the impression that the last update was the source of it.
Comment has been collapsed.
no, i just bring it up each time i see someone else mentioning issues. it's not an issue for me, but it does have a little bit of an unusual memory usage pattern to it, so that's why i bring it up.
Comment has been collapsed.
By the way, I think I know why there was an increase in your export size and I assume there was an even bigger one with 5.0? It's because the script upgrades your v5 storage to v6 but doesn't delete it, in case something goes bad and a recovery is needed. I might add an option to purge the v5 storage to the settings menu later, but you can do it manually:
GM_deleteValue("Users");
GM_deleteValue("Games");
GM_deleteValue("Comments");
GM_deleteValue("Comments_ST");
GM_deleteValue("CommentHistory");These are all the storages that were upgraded so far. Still recommended to export before doing this.
Comment has been collapsed.
ahh okay. sounds good to me. i keep such a large archive of old backups in many different ways so i'm never afraid of data loss in that department. actually the really large increase in storage was "June 9, 2017 - v6.Beta.3.14" it almost doubled storage size. the difference between beta4 & beta5 was pretty negligible tbh (~300kb).
edit:
thanks. that dropped me from a 8.8mb export to 7.1mb :D
or 5.8mb tm zip export to 3.7mb tm zip export.
Comment has been collapsed.
No, it was not the last update.
While using 3.13 it still goes up to over 1gb: http://i.imgur.com/kgUHDZL.png
Comment has been collapsed.
So it really was from 3.12 from 3.13? I'll see if I find anything here.
Comment has been collapsed.
I think I found why 3.13 consumes so much memory, but it's no longer in 5.1.
Comment has been collapsed.
Then it might be something else, since d3m4n's gif is from 5.1, isn't it?
Comment has been collapsed.
It is. I assume it would be too much work for you to test from 3.14 onward?
Comment has been collapsed.
Do you have any specific version that you think the issue is solved? Because there are 20 versions from 3.13 to 5.1.
Comment has been collapsed.
I'll inspect the commits and see which version should have the 3.13 error fixed.
Comment has been collapsed.
Ok, let me know and then I will test it out from there.
Comment has been collapsed.
I couldn't really track it down. I'll have to see if something that I do in future updates fix it. Still consuming that much?
I find it weird that it's not consuming that much for me. It's literally at 128MB right now with 2 tabs open and in theory I should be consuming much more than you as I have all features except for Grid View and Endless Scrolling enabled.
Comment has been collapsed.
Even going to the giveaways page for me, which should consume a lot of memory because of Game Categories, only gets me to ~300MB.
Comment has been collapsed.
I went back to 3.12 because of the error that 5.1 was giving me on /entered page and not liking the way to temp fix it and due to the memory use too.
But every time I had 5.1 on, it would spike up even with only two tabs open, the /entered page and the /giveaways/search?type=new page, I always have both open with a 2m to 10m refresh.
With 3.12 after having both tabs up for several hours during yesterday and all of today's night, and this thread page now open too, it sits at 74mb right now, but I saw it at 111mb a few minutes ago when I woke up. So quite low compared to 5.1.
Comment has been collapsed.
Fixed that bug, but yeah, haven't found the source of those spikes yet. Have you tried disabling some features that run in the entered page to track it down?
Comment has been collapsed.
I'm confused, why disable features that run in the entered page only if you fixed that issue?
Comment has been collapsed.
I meant the memory issue, you said if you open the entered page it spikes, so maybe if you disable the features that run there and go enabling them one by one, we can find the source of the spikes.
Comment has been collapsed.
No no, the memory issue is not about the entered page, the error that I was having is the one that was related to the entered page, since I only had that error in that page.
The memory issue I have no idea to what it is related to.
Comment has been collapsed.
Ups, linked the wrong error since I have two.
The one that I linked is a conflict with SteamGifts v2 Giveaway Filter.
The other one it is:
TypeError: Cannot read property 'nextElementSibling' of undefined
at getGiveawayInfo (eval at E_c (:3:221), <anonymous>:19757:55)
at getGiveaways (eval at E_c (:3:221), <anonymous>:19652:24)
at Object.loadGiveawayFeatures [as load] (eval at E_c (:3:221), <anonymous>:19640:21)
at loadFeatures (eval at E_c (:3:221), <anonymous>:1933:33)
at loadEsgst (eval at E_c (:3:221), <anonymous>:1896:9)
at eval (eval at E_c (:3:221), <anonymous>:412:9)
at Window.tms_90e7c32f_6846_4f2a_bb04_018d508b2685 (eval at E_c (:3:221), <anonymous>:21163:3)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
I disabled SteamGifts v2 Giveaway Filter, and only this error shows up. Then I though, maybe it's a conflict with another addon so I disabled all but ESGST and this error still shows up, so it's not a conflict.
Edit: I disabled SteamGifts v2 Giveaway Filter for good and enabled the Filters from ESGST. So one error left.
Comment has been collapsed.
you'd be surprised how much a disabled script can still conflict tbh. idk if that's really the case here or not, but disabled or not they can still cause issues.
Comment has been collapsed.
Well, that makes it harder to test.
But the error so far only seems to show up in https://www.steamgifts.com/giveaways/entered , which is annoying to me since I use that page quite a lot.
Comment has been collapsed.
yes, it really does. i can't find the topic currently but there is/was a script that causes steam to logout of the browser when it's installed even if it's disabled. it was a major 1+ month long pain in the ass to track down cause i thought disabled wouldn't cause issues, but it was the culprit all along.
edit: it was someone elses topic with the same issues i had. there were 3 or 4 of us trying to solve it.
Comment has been collapsed.
I just started to downgrade ESGST to see when the error that I have would go away, it's with 4.8.
Comment has been collapsed.
well, i just installed extended steamgifts on my firefox testing browser and esgst+extended+darktheme all enabled doesn't seem to have an issue on the /entered/ page for me. they're pretty bare, with only esgst settings matching the settings i use in chrome and extended steamgifts on its full default settings.
so chances of it being a conflict from extended steamgifts itself is dramatically lowered. (not completely ruled out, but certainly lowered) ;)
Comment has been collapsed.
I went and tested with firefox, I had no GM script installed, so I installed ESGST and I get one error in the same page and in none of the others.
1 ESGST features failed to load: Giveaway Features. Check the console (F12) for errors and report them in the script's discussion/GitHub page.
And the console gives me:
TypeError: giveaway.panel is undefined
And a bunch of links to the location of the addon.
So it seems that the error is from ESGST, since I barely use FF and have no other script installed at all.
Comment has been collapsed.
are you using greasemonkey in chrome or tampermonkey?
i'm wondering if it's a greasemonkey thing now, cause i use tampermonkey on both chrome & firefox.
Comment has been collapsed.
In Chrome I'm using TM. In Firefox I use GM.
Had no idea that TM was now usable in FF, that's how long I haven't used FF.
Comment has been collapsed.
is there a giveaway in your entered page that has the broken/missing photo on it by chance? it maybe one of the giveaways inside the page triggering the error and that's why we're not getting it.
also to test that theory, try different pages inside the /entered/
Comment has been collapsed.
There aren't any photos/images broken or missing in either browser.
I tested different pages in FF where ESGST is the only script installed and the error still shows up.
Then I remembers to go check ESGST's options, since the script was installed just a few minutes ago, and there are only 2 options enabled (Header Button and Giveaway Encrypter/Decrypter, both in the Other category). Disabling both, so no option enabled at all, and the error still pops out.
Comment has been collapsed.
Happens unless giveaway winning chance is enabled.
Comment has been collapsed.
Giveaway Winning Ratio* for me, but +1
good catch. =)
edit: either one enabled will fix it so there is no error, but both disabled throws an error.
Comment has been collapsed.
Yeah, I didn't had it enabled.
That seems to fix it.
Thank you!
Comment has been collapsed.
Yeah, hopefully it will be fixed since not everyone uses that option and some others use other addons for it.
I use another addon for it (ES). If I disable the option in ES and activate the option in ESGST then I have visual conflicts in every https://www.steamgifts.com/giveaways/* page, except /entered. T_T
Comment has been collapsed.
I have both "Winning" options disabled and no error on that page. but I do have two giveaways with broken/missing image in the page.
Comment has been collapsed.
It won't show up if both are disabled and the enter/leave giveaway button is enabled but not if it is disabled.
Comment has been collapsed.
yeah that fixed it, thank you. but...
Giveaway Grops Loader - Replaces Giveaway Groups Popup (can be added back if there is demand for it).
+1 for demand for it here. at least for main giveaways page view, i used it to see what groups the giveaway was for prior to loading the giveaway page.
also there's a typo there ;)
If you hover hover whitelist/blacklist
another small typo ;)
edit:
never-mind after all, i could get used to it that way. i didn't realize it pulled them at the bottom on the front page too.
Comment has been collapsed.
But they are still shown below the giveaway, so you can still see what groups the giveaway is for, unless I'm missing something?
Comment has been collapsed.
yeah sorry about that nevermind. i can get used to that fine too, i didn't realize they were pulled to the bottom of the giveaways there also. =)
i honestly just didn't expect that many request pulls tbh. xD
Comment has been collapsed.
Yeah, but at least groups only need to be requested once, so it shouldn't bring too much load to the server.
Comment has been collapsed.
it seems that showing only group or only restricted giveaways isn't working in the filter
edit: it isn't hiding them also
Comment has been collapsed.
Are there errors in the console? Could it be a conflict with another script?
They are working fine for me.
Comment has been collapsed.
no errors in the console, only your script active, can i do anything to help you debug it?
versions:
ESGST v6.Beta.5.1
firefox 53.0.3 (x64)
tampermonkey 4.3.5447
win10 x64
Comment has been collapsed.
just checked giveaways/search?type=group and there isn't any there so the group filter probably is working correctly, but i do have some region restricted giveaways that should be detected by the filter
Comment has been collapsed.
the genre categories is only wrapping in the right side of the screen if the hover info goes to the left it stays in on line even if it makes part of the hover info go off screen
Comment has been collapsed.
Ah, Grid View. Yeah, there are many things that need to be fixed on Grid View. I'm thinking of showing the giveaway info, reduced, below the image instead of on hover.
Comment has been collapsed.
well i would prefer if the hover would stay, could be as an option, I like it a lot 😅
Comment has been collapsed.
about the change you made to the width of the hover info, could you change it so that the size is dynamic(as it was before) instead of fixed, but with a size limit(don't care about what you set as the limit).
Comment has been collapsed.
Size limit of 600px and no minimum size, sounds good?
Comment has been collapsed.
Yes :D
giveaways with few tags would look way better this way :D
Comment has been collapsed.
I would also change the enter/leave button to have a minimum width but no maximum(making it dependent on the width of the hover) as it would make it easier to click it if the winning ratio and chance are disabled or if the width of the hover is closer to 600 px
i have a custom css rule that does it for me so not particularly needed
Comment has been collapsed.
I don't really know how I could do that without a fixed width. Would you mind sharing the rule?
Comment has been collapsed.
this is the rule i use:
.esgst-giveaway-panel.giveaway__columns{
float: unset;
}
.esgst-button-set{
width: 100% !important;
}
.form__submit-button.green.btn_action,
.form__saving-button.btn_action.grey.is-disabled.is_disabled,
.sidebar__entry-delete{
width: calc(100% - 30px);
}there may be a better way of doing it. SquishedPotatoe probably can confirm if there is a better way
Comment has been collapsed.
it also makes the enter/leave giveaway button bigger on the popup(which i consider a plus)
edit: and on the giveaway list if gridview is disabled, which may or may not be desired
Comment has been collapsed.
Huge buttons are not my thing so i would probably set a max width, in certain cases that enter button is 730+ pixels.
Comment has been collapsed.
that's another option, as long as it is left aligned(right aligned and small makes you move the mouse a hell lot more than it should).
and i can just keep using my overrides or part of them, so not a necessity :D
Comment has been collapsed.
I'm more concerned with the rule to be implemented whatever is chosen being actually the more optimized way of doing it and not having unintended consequences, which is why I mentioned you, as I'm not good at all with CSS, and the rules i shared just happens to work, but may not be the correct way of doing it.
Comment has been collapsed.
There are many ways but no correct way ;) as for unintended consequences that would need testing. Classes can be reused in other places so if you find yours affecting something it shouldn't you just need to be more specific in your targeting if possible.
Comment has been collapsed.
would also recommend doing:
.is-faded.GVBox:hover{
opacity: 1 !important;
}so that the hover info can be readable if the giveaway is faded for any reason
Comment has been collapsed.
not exactly but i checked again and it's an issue only because of another one of my rules(one that i use to move the icons from level, group etc in gridview as you said you won't move them to inside the image)😅
sorry for wasting your time
Comment has been collapsed.
Oh I kinda forgot about that, I think I can add an option to move them to inside the image, or even make it the default way.
Comment has been collapsed.
If you apply .is-faded to .GVContainer instead of .GVBox then .GVIcons will be faded as well unless your intention was to not fade them.
Comment has been collapsed.
The current rule is:
.is-faded.GVBox {
opacity: 1;
}
.is-faded.GVBox .global__image-outer-wrap--game-medium {
opacity: 0.5;
}It makes sure nothing is faded but the image of the game if you have entered the giveaway.
Comment has been collapsed.
So you are saying it is intentional to not fade the icons?. I can understand the level icon on white looks fine but the group/whitelist standout, and on dark well.... it all pops out there :P
Comment has been collapsed.
Ah, it does look bad on dark theme. I'll change it later.
Comment has been collapsed.
It does not bother me either way, i just thought it was suppose to be consistent with the regular view giveaways and you never noticed on white.
Comment has been collapsed.
I often forget to fix bugs or add stuff that aren't reported on GitHub. I use it as my main source for updates. But I wrote it down on the next changelog so I can remember it. :)
Comment has been collapsed.
Thanks. BTW I almost got heart attack today, because I went to look at the new Giveaway Groups Loader feature and I didn't notice the list of the groups there so I thought that the feature is just the opened page in the new tab with the white chance to win. So I thought that I lost the possibility to see the groups easily and that you even replaced it by new tabs. You sure know how "much" I like new tabs so I really almost got crazy and I started to write you about it. :D
But luckily, I noticed the list of groups there in the end and deleted the post before I sent it. I really like the new feature. I already dreamed about it long time ago but I thought it was not possible to make it because of too many requests so I even didn't requested it.
Good work!
Comment has been collapsed.
Awesome, thanks for your hardwork.
In case anyone wants these:
HAWKEN – Prosk Starter Bundle 3XW26-MF68H-DE93Q
Paragon Gunslinger Pack 2TT5Q-ULJZD-NLW3T-CFQGT
Neverwinter Gilded White Steed 0uoirJN8
Robocraft eagle pack 0510-176D-A357-4246
Crossout - Thug Starter Pack 2RYG7-JAKQM-X26B4-6ZU1F-2E5KF-FGC6Q
Master x Master Poharan Pack 1SO64UQ6XSS4S3N23R3R
Blade & Soul Shadow Guard Bundle 1ZNMO4J65OBSDMDX118A
Comment has been collapsed.
You're welcome. I appreciate the key drop (but didn't take any). :)
Comment has been collapsed.
Can people using the script with version 5.1 (latest version) go to https://www.steamgifts.com/giveaways/entered and report if an error pops out or not?
Since it's a page that most users don't usually go, it's harder to check if the error is global or not.
Comment has been collapsed.
Found what was causing the error: https://www.steamgifts.com/go/comment/GkOrTAE
Comment has been collapsed.
Did something change with the discussions highlighter? I'm not seeing highlighted discussions on the main discussions page any more, and am also not seeing the stars next to each thread that used to be used to mark/unmark them. If I click into one of the discussion threads I already have marked, it does indeed show at the top of that discussion. Thanks!
Comment has been collapsed.
Someone else reported this, but I have yet to find the source. It's working fine for me.
Comment has been collapsed.
Hmm, ok. I'll poke around a little and see if I see anything. There are no errors in the console or anything, it just doesn't display.
Comment has been collapsed.
It looks like the stars and discussion highlighting now only work if you have "Comment Tracker" enabled in the settings. With that disabled, the highlighting and stars don't show in the main discussions list.
Comment has been collapsed.
@Zupe00
dark theme enabled?
it does this for me with dark theme, but it's fine without it and squishedpotatoe is already aware & working on a fix for it if so. if not then maybe it's another conflict.
@revil
just to semi-link the two similar issues together you're referring to this ;)
Comment has been collapsed.
Nope, I don't use Dark Theme. The same thing happens if I disable all my other scripts, with "Comment Tracker" enabled, discussions highlight and the stars show up next to all the topics. With Comment Tracker disabled, no stars and no highlighted discussions
Comment has been collapsed.
oh i see, sorry. i misunderstood you explaining that before. yeah, there seems to be a few places in the features that are a breaking if certain other features are disabled atm. hopefully revil has enough details now to get it fixed.
Comment has been collapsed.
Giveaway Groups Loader is an amazing addition!
You are making our experience here even more epic!
Thank you!
You are awesome!
Comment has been collapsed.
5.1 Bug list
- Hidden game removal not displaying as removed after first page on endless scroll.
- Win chance and ratio are showing on entries/winners/group page of a giveaway.
- Groups stats are applied for each page with endless scroll on steamgifts.com/account/steam/groups
- Giveaway Groups Loader is missing some groups completely and handles <Intense Intents In Tents> group as a html tag.
- Whitelist/blacklist on hover times undefined.
Comment has been collapsed.
Using SG's default or One-Click Hide Giveaway Button?
Which groups are missing completely?
Comment has been collapsed.
The removal function on steamgifts.com/account/settings/giveaways/filters after first page ;)
traders group giveaway https://www.steamgifts.com/giveaway/kP1y7/david not showing but other traders group giveaways show.
<Intense Intents In Tents>, Charitable Losers, The Vivarium group/whitelist giveaway by d3m4n https://www.steamgifts.com/giveaway/IYyZS/pivot-pilot not showing any.
Comment has been collapsed.
Can't access first one.
It's showing Charitable Losers and The Vivarium fine for me. Maybe the first one is making the others not appear for you? Can you check the HTML?
Comment has been collapsed.
<div class="popup__actions esgst-ggl-panel">
<i class="fa fa-user"></i>
</div>Comment has been collapsed.
And the storage? Logging groups inside the function addGglPanel should show you what's saved.
Comment has been collapsed.
Sorry missed this post, is this what you were looking for?
Object {Gd3ux: "<Intense Intents In Tents>", GbNZO: "Charitable Losers", pldoD: "The Vivarium"}
Object {Gd3ux: "<Intense Intents In Tents>", GbNZO: "Charitable Losers", pldoD: "The Vivarium"}
Object {}first 2 do not show <Intense Intents In Tents> because it is treated as a html tag third one has the exact same 3 groups but does not add any of them.
Comment has been collapsed.
Sorry never even knew you updated, i was stressing over what might happen to gridview 😛
Will check
Comment has been collapsed.
I'm still thinking of a good redesign, but I might have to keep the hover because the script adds too much info to giveaways and it wouldn't be possible to shrink all of that below the giveaway.
Comment has been collapsed.
You should keep hover, the whole point of grid view is to have a minimalist view in order to view as much as possible at a glance.
Comment has been collapsed.
<Intense Intents In Tents> now show but i still have nothing saved for the third one https://www.steamgifts.com/giveaway/IYyZS/pivot-pilot
Comment has been collapsed.
No errors? Wasn't the object from the third one empty in the log you posted?
Comment has been collapsed.
Another one of d3m4n's giveaways
<div class="popup__actions esgst-ggl-panel">
<i class="fa fa-user"></i>
<a class="" href="/group/Gd3ux/"><intense intents="" in="" tents=""></intense></a><a class="" href="/group/GbNZO/">Charitable Losers</a><a class="" href="/group/pldoD/">The Vivarium</a></div>Comment has been collapsed.
Added #5
<span class="sidebar__shortcut-inner-wrap esgst-wbh-icon" title="You whitelisted rafaelgs18 on undefined NaN, NaN, NaN:aNpm.">Comment has been collapsed.
I'd rather not, but if you really need it I'll bring it back.
Comment has been collapsed.
It was a lot easier to check with popup what group GA it is.
Comment has been collapsed.
If the problem is the highlighting of the groups that you're a member of, I can enhance that, maybe by coloring it differently so it stands out, or adding a background.
Comment has been collapsed.
Just one of the examples that stand out so far
There are just to many things on giveaway page in my opinion :)
And with popup you can just easily check if you want, but page would look better :)
Comment has been collapsed.
Can also easily add an option to only show groups that you're a member of, if that makes it better.
Comment has been collapsed.
That would be way better then all the groups listed in my opinion :)
But still i love the popup :D
Comment has been collapsed.
You just said in the previous comment that page would look better, I'm confused. :P
Comment has been collapsed.
Does my suggestion of only listing groups you're a member of make it any better? That way it wouldn't take much space on the page.
Comment has been collapsed.
It's back, but not the same as it was, it not longer has the group avatars because it's not good to cache that and the results are always cached now.
Comment has been collapsed.
Well english is not my primary language, so maybe i translated things in wrong order in my head before writing it down :P
The best would be popup, since it doesn't add anything new on page(unless you click it)
2nd best would be only showing groups that you're a member of
3rd (worst in my opinion) show all group names with highlighting/bold
Comment has been collapsed.
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.