It's staying compatible with Greasemonkey for now. But take into account what Pilda said, Tampermonkey for Firefox already supports v57, and Tampermonkey has a much more robust API than Greasemonkey.
Comment has been collapsed.
Glad to hear it. :) Greasemonkey has been very troublesome with this script.
Comment has been collapsed.
For some reason, with ESGST enabled, every time I try and post a link it's automatically formatted with the brackets, but I don't seem to have any option enabled in settings to make it do that?
Comment has been collapsed.
Hm, I actually have comment formatting enabled with just 'exclusive giveaways' selected. Link/Image is already disabled.
Comment has been collapsed.
It's not Link/Image, it's the button with the paste icon. It should be the last button or the second to last if you have Exclusive Giveaways enabled.
Comment has been collapsed.
I have everything for comment formatting disabled except "Exclusive Giveaways". However, the button that says "utomatic Links / Images Paste Formatting: On" is still there. I just want to be able to ctrl+v into the window without it auto-formatting.
Comment has been collapsed.
The automatic formatting button appears no matter what, you cannot disable it.
Comment has been collapsed.
So, there's no way to avoid auto-formatting without turning off "comment formatting helper" and thus exclusive giveaways?
Comment has been collapsed.
Ah. Well, seems have to do it for every comment, but yea that appears to work. Thanks
Comment has been collapsed.
oh, it should save itself i thought. should just toggle once and stay that way.
edit: maybe try toggling it to the off position and rather then posting something just refreshing and see if it stays off from then on out. thats should make it stay off.
Comment has been collapsed.
Awesome. :) I'll stop posting the changelog in this thread now that it's showed to the users on each update and easily accessible through the header button. Plus it's less work for me. xD
Comment has been collapsed.
Im having a error with encrypted GAs.Strange thing is that 3 days ago it worked- now (ESGST updated) it says 'failed to load, see console'.
...but the console seens cryptic to me for anyone who don't know the script code for this function :P
From Console
TypeError: Cannot read property 'XXXX' of undefined
at getEncryptedGiveaway (eval at E_c (:3:221), <anonymous>:17907:44)
at getEncryptedGiveaways (eval at E_c (:3:221), <anonymous>:17898:9)
at Object.loadGiveawayEncrypterDecrypter [as load] (eval at E_c (:3:221), <anonymous>:17888:5)
at loadFeatures (eval at E_c (:3:221), <anonymous>:1668:29)
at loadEsgst (eval at E_c (:3:221), <anonymous>:1588:5)
at Window.tms_2fdaa1ee_6d1a_43f1_8ace_8eb3b6b32d32 (eval at E_c (:3:221), <anonymous>:436:5)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
at Object.eval (eval at E_c (:3:221), <anonymous>:18954:6)
That 'undefined' seens to be the problem for me- but thats a wild guess. My javascript-fu is weak, yellow belt at best, so even if i scrutinized the script on tampermonkey my chances of finding the problem are small.
(xxxx above was the GAs url code)
Comment has been collapsed.
I'm also having a problem with the encryper/decrypter. The message says:
"1 ESGST features failed to load: Giveaway Encrypter/Decrypter. Check the console for more info."
I'm not sure how to access the console. I'm using Greasemonkey 3.11 with Firefox 53.0.3
Comment has been collapsed.
And still not with 6.Beta.3.10. :P I'm aware of the issue, just haven't fixed it yet because Firefox makes me lazy to even test, I can't stand that browser. xD Will try to add a fix for the next version.
Comment has been collapsed.
Great, wasn't sure if people would respond well to it. ^^
Comment has been collapsed.
i didn't feel this was a vital enough suggestion for a github ticket due to the fact that there maybe a different reason for the change but....
any chance you can make the api / steam store login difference optional for the sync? reason i ask is because i prefer the speediness that comes with api recognizing freshly purchased content. for instance i just purchased state of decay yose, and even though i'm not entered into any active giveaways for that game it didn't even recognize new games. it took till just now (while typing this message / ~3-4mins) in order for the steam store login method to catch that new ownership.
Comment has been collapsed.
I've always wanted to implement that, but never got around to it. Yes, will add it.
Comment has been collapsed.
Using Google Chrome v58.0.3029.96 (64-bit) I'm getting this warning when I try to switch from the Giveaways page to the Discussions page:
"Do you want to leave this site? Changes you made may not be saved." [Leave] [Stay]
Similarly, I get this with Firefox 53.0.3 (32-bit)
"This page is asking you to confirm that you want to leave - data you have entered may not be saved." [Leave page] [Stay on page]
Is this a known issue?
Comment has been collapsed.
You are probably syncing data on that page/tab. Open a new tab to do stuff while it syncs.
Comment has been collapsed.
That appears if you're running a check that hasn't ended yet or the page is syncing and hasn't ended yet, to make sure you want to leave and cancel the check/sync. Is the script syncing? Sync now appears in the header instead of popping up, which makes it harder to be noticeable.
Comment has been collapsed.
Did this happened recently? It takes a while to update.
Comment has been collapsed.
I'm pretty sure SG Game Tags uses the same place to get that information though.
Comment has been collapsed.
It started specifically in the last update (v6.Beta.3.10)?
Do you have Header Icons Refresher running in the background? If you disable it, does the memory usage reduce?
Comment has been collapsed.
The only thing the last update did that would affect you was bring back the option to sync using the Steam API key. Does it happen all the time? Was the script syncing?
Comment has been collapsed.
You updated from v6.Beta.3.9 to v6.Beta.3.10 or did you jump from an oldest version to v6.Beta.3.10? You could disable each feature, one by one, testing to see which one is causing it (maybe start with Comment Tracker as it was one of the features updated lately).
Comment has been collapsed.
So does it get back to normal with Comment Tracker disabled or just helps but still consumes too much memory?
Comment has been collapsed.
Can you try doing the inverse (disable all features and go enabling one by one to see where it really peaks)?
Comment has been collapsed.
So if you disable both of them it gets back to normal?
Comment has been collapsed.
It's odd that it started with the last update, I'll see if I can optimize those features.
Comment has been collapsed.
tbh it's always been pretty high memory usage (1-1.5gb) for me personally so any optimizations would be nice, however i have 16gb of ram so it's not a big deal to me either.
edit:
that's full tampermonkey memory usage though, not just ESGST. (4-8scripts depending which websites/pages are loaded / i'd estimate ~80% of that to be ESGST though)
Comment has been collapsed.
I actually never noticed any lags while navigating around SG and I have 4GB only (except sometimes when using endless scrolling because it basically needs to load all features again for the newly loaded page), but I am noticing an odd memory consumption since terminator reported it. I think there might be a memory leak in the script, will see if I can solve it.
Comment has been collapsed.
i never really got lags personally (and still don't) even with the somewhat large memory usage. but that 1-1.5gb was its normal peak, even currently i'm only down at 380mb ram usage (all of tampermonkey, not just this script). it has the ram available to use, so it probably just using more then it needs to for me sometimes, and is/was totally unrelated. good luck with the leak search though.
edit: i'm also a 7.7mb esgt export filesize (cachesize), so i'm not suprised i get up into higher memory usages either.
Comment has been collapsed.
The one I was talking about here ^^
https://www.steamgifts.com/go/comment/3m9LWA3
Seems since some days/versions ESGST doesn't load inside anymore and I was wondering if that is intended?
Comment has been collapsed.
He's talking about it not loading in iframes, which of course is intentional.
Comment has been collapsed.
Some more stuff from me ^^
There is an inconsistency when hiding entered GAs is on, it doesn't auto update (hide) newly entered GAs unless they have a description that pops up.
I'd prefer for this auto updating to not happen at all actually, could that become an option?
Reload button doesn't work, it just keeps spinning.
Also I'd suggest that description pop ups to be mandatory when using the direct entry button. Read rates have dropped below sad 5% by now, that decline shouldn't be further supported imo.
Comment has been collapsed.
I'll work on the first two later, but I've already expressed my "controversial" feelings about making the description popup mandatory in this thread. My take on it is that reading descriptions is not a requirement to enter giveaways by SteamGifts' rules, and therefore should not be mandatory. Those that don't bother reading descriptions won't read them anyway (they will most likely just click out of the popup without even paying attention). I personally often enter public giveaways without reading descriptions because they're not that important, so I would be very annoyed if I was prompted the description every time I entered a public giveaway. I do always read the description of private/group/whitelist giveaways though. So it's better to leave it optional, as each person has a different feeling about it and I don't want to force anything on anyone.
Comment has been collapsed.
don't want to force anything on anyone.
I see it oppositely. The script allows to avoid it in the first place. That isn't covered by normal SG usage otherwise.
It's not about forcing to view, which is SG default, but allowing to circumvent. Therefor the script is actively contributing to the problem.
Just read how many people are discouraged by that decline.
I'm solely saying to not make it actively worse, but it's your decision in the end ofcourse.
Comment has been collapsed.
SG's default doesn't force anyone to see it though. You can easily go inside a giveaway, hit the enter button and exit without even moving your eyes to the description area. It's something optional on SG, and should also be optional on the script.
People are the problem, script isn't the problem.
Comment has been collapsed.
SG default ensures that users see the GA description. They may not read it, but that is a different thing. With the script default they can bypass even seeing that there's a description. I fully agree with Tristar that this allows them to circumvent the SG default and makes an already bad-issue worse. I really hope you'd reconsider making this the default for the script.
Comment has been collapsed.
The same can be said about ads, using d3m4n's analogy. Blocking them is not good for the site either.
Comment has been collapsed.
I'm not encouraging people not to read giveaway descriptions, I'm just not forcing the descriptions on them. It's quite different. What I meant with the ads example is, if blocking the ads is bad for the site, this script should force users to see the ads, right? Sorry, but I disagree with that line of thinking. If it's not in the rules of the website, it's not in the rules of the script.
Comment has been collapsed.
i actually argued these same things upon it's creation, so i understand. i don't use the feature either for those same personal moral reasons. but i do understand where he's coming from at the same time, since the whole point of this script is to create convenience for people as long as it remains within the rules/tos/faq/quidelines/etc.
Comment has been collapsed.
That's like saying comments should also be mandatory to see when entering a giveaway because they're there in the page for the user to see, in which case all giveaway pages should be loaded when entering a giveaway, right? Because the creator might have said something important in a comment, right?
Sorry, but I'm not changing my mind on this. Even if, for example, you state in a giveaway description that the key doesn't work in a certain country and the winner ends up being from that country, there is no punishment whatsoever to that winner for not reading the giveaway description and not entering. The giveaway is simply re-rolled. So the description is absolutely optional.
Comment has been collapsed.
The creator doesn't expect people to go through all comments because the site doesn't force them to if they want to enter a GA. Creators do expect users to see (though maybe not read) the description because the site does enforce it.
The description is optional (in the sense that reading it is optional), but it's an important part of the site. GA creators who write comments normally want people to read them and expect that they at least see the descriptions. The script breaks all this. It's the only part of the script that isn't improving the site, and is actually doing the opposite.
Comment has been collapsed.
I think you're contradicting yourself. The site doesn't force them to read the description either. If we're talking about what the user can see, then the site surely enforces the viewing of comments, at least in the first page. Expectation is different than reality. Just because creator expects users to read their description, doesn't mean all users will do that.
They want people who want to read them to read them. Like I said, people who don't bother reading descriptions won't read them anyway. I fail to see how the script breaks this. You can even enable the option to make the description pop up upon entering. So users who want to read descriptions will surely have that option enabled. We'll just have to agree to disagree.
Comment has been collapsed.
Even if pointless and too late now.
When the tab/description is at least visible than things like:
may very well get still noticed and actually read by a few more than otherwise.
But I see (and only now) just noticed the fight is lost.
Getting "convinced" to turn around by some of the worst leechers however is a bit disappointing though. Quite obvious how they care about that.. considering they don't gift anything in the first place.
Comment has been collapsed.
Not quite sure I understand what you're saying.
But I myself see the annoyance of having it mandatory like it was. Even with the option enabled I'm constantly annoyed because some descriptions-- actually 99% of the descriptions in public giveaways are absolutely useless. If people somehow miss some important information, that's what rerolls are for. Sure, it's annoying for the creator and support, but that's a SG problem, not a ESGST one. I'm sure the reading rate in invite only/group/whitelist giveaways is quite high.
Comment has been collapsed.
Not forcing to see but it still always displays it.
Script allows to skip that entirely.
Same argumentation line about 'not forcing' can be used for bot usage which is why I disagree
People are the problem
Absolutely.
But script enables more laziness and ignorance, which makes things worse. Therefore the script does become part of the problem.
If that doesn't concern you then I won't argue further, as said your decision, even if I don't agree.
Comment has been collapsed.
Same point can be made about comments, as I stated in the comment above.
I disagree that it's part of the problem, but yeah, there's no point in arguing this further.
Comment has been collapsed.
So, I actually went back on this and changed how the feature behaves. Now it checks for a description when you click the Enter button and opens the giveaway in a new tab if it's found, removing the Enter button from the current page. Otherwise, it enters the giveaway through the Enter button as usual.
Comment has been collapsed.
oh my, to quote Adam Jensen "I Never Asked for This".
ok serious mode: what was wrong with the popup? I only meant to make that un-hide-able. Nothing more. Appreciate the notion but that seems a bit too much.
The opened tab is also bugged for me as it gets put completely to the right of the row instead of directly besides the origin tab (or generally adhering to the setting, shitty chrome default.., am using FF btw)
Comment has been collapsed.
There was nothing wrong with the popup, opening in a new tab is just easier for me to implement with the new system. I'll work on a new popup later.
If you're using Greasemonkey, the function to open in a new tab does not work well with it.
Comment has been collapsed.
easier to implement with the new system .. a new popup later.
But it was completely fine, just the optional setting "show popup" should be mandatory.
That's it, you could just use the old system again and only remove the possibility to hide the popup, should be only a few lines.
If you're using Greasemonkey, the function to open in a new tab does not work well with it.
window.open( url );
works fine in my scripts
Comment has been collapsed.
The problem is I don't want to use the old system, since it shouldn't automatically enter upon clicking the button. It should first open the popup, allowing the user to see the description, and then allow the user to enter using a second Enter button inside the popup. For example, if you enter a giveaway, and in the description it states that the key is locked, you would then need to leave the giveaway and that's a waste (if you have the filter to hide entered giveaways enabled this is even more painful, since you would have to go and disable that filter to be able to leave the giveaway). It's better to first popup the description and then allow the user to decide whether or not to enter based on it.
I'll try that later then, I'm using Tampermonkey's GM_openInTab.
Comment has been collapsed.
Added an option to the settings menu that allows you to merge the imported data with the current data when importing.
This sounds very promising. Can you clarify what happens if notes for a specific user are available in both source and target but are different?
Thanks!
Comment has been collapsed.
The notes will currently be merged. I'll see if I can implement a method that allows you to choose to either keep the current notes, keep the imported notes, or analyze it on a case-by-case basis, because unfortunately the current method can lead to duplicated notes if you have an user with two notes like "Whitelisted because x." and "Whitelisted because x. Something else.". The resulting notes will be "Whitelisted because x. Whitelisted because x. Something else.".
Comment has been collapsed.
Some suggestions for new features:
Suggestions for the game categories icons:
Bundled: a letter "B", a bag or 3 dots
Not bundled: a dollar sign "$"
Wishlist: a whitelist icon (in other words a simple heart)
Owned: a star icon or this: ☑
Ignored: blacklist icon
Trading Cards: 2 or 3 cards
Achivements: a "trophy-cup" icon
Multiplayer: two people like on Steam
Steam Cloud: a cloud
Linux: a penguin
Mac: an apple
DLC: "DLC"
Comment has been collapsed.
ability to cancel greying-out read discussions
+1
see revil.... i'm not alone. :P
https://github.com/revilheart/ESGST/issues/128
hehe
Comment has been collapsed.
It'd be pretty useful feature - for example I don't wanna have Orphan Keys or Giveaways for Peace or even Karaoke thread greyed-out because they are easier to miss this way. Also it'd be even cooler if we could have a feature that allows us not only cancelling greying-out but also set settings to automatically cancel greying-out when new comment appears in a marked discussion.
Comment has been collapsed.
Well, I think those are different suggestions. :P But I'm implementing your suggestion already.
Comment has been collapsed.
The current icon for wishlist is a star, for owned is a folder and for ignored is a minus circle. I'd rather not use the same whitelist/blacklist icons here.
Comment has been collapsed.
I've suggested BL and WL icons because this way there's 2 icons less to remember - if someone is using all of them it might make quite a difference :) I personally use only 4 things: non-bundled, wishlisted, dlc and genres - basically only 1 icon to remember so it's not something that'd affect me personally :)
Comment has been collapsed.
I just wanted to give this a bump because this is an awesome improvement to the site and I really appreciate you taking the time and effort to do this for us. Thanks
Comment has been collapsed.
If I don't use a fixed header button, I got sth like this: pagination navigation on the header. If fixed header is enabled, then everything on main SG page is ok, but then on ST the header takes half of the screen.
Comment has been collapsed.
Most likely a conflict with another script because that header isn't mine. The header on SteamTrades is normal, it is that way because of the "Search trade/Search reputation" fields.
Comment has been collapsed.
Oh forgot to add another change to the v6.Beta.3.11 changelog. I'll append it in the next update:
Comment has been collapsed.
Nice i'll assume this is what fixed stylish loading styles multiple times on endless scroll.
Comment has been collapsed.
Yep. It was a cool feature, but it's a bit messy anyway. Better to just alter the pagination navigation as it has always done.
Comment has been collapsed.
The icon of the tab is no longer changed, the message count will now appear in the title of the tab e.g. (5M).
I really dislike this change. :( The icon was wonderful because it was easier to notice it when one was reading something in another tab. Changed text in title is not noticeable at all. It's good for the points but not for messages when one would like to notice them as soon as possible.
Please make also an option for the icon.
Comment has been collapsed.
in another tab
i don't use this feature, but from what i understand... now it syncs those things across all tabs, so it shouldn't matter which tab you're in anymore. idk if that changes your opinion on the features update, just thought i'd point that out though.
Comment has been collapsed.
Yes, but it is an internal script mechanism what you are talking about. It's good but I am talking about removing notifications from tabs. Changed text doesn't work like a notification. The difference between red square in tab icon and changed text in title is, that people will notice the icon even if they are staring at another place because the red color "attract" eyes, but one hardly notice a changed text in title if unless they look at the directly.
Comment has been collapsed.
Sorry, but I'm not bringing the icons back. This way is just much better. Altering the icons required the icons to be loaded every time they were changed. Altering the title is much simpler. Plus this is the way all other websites (Facebook, YouTube, etc...) do it. It requires less resources.
And this way is also better because there is no number restriction (I often have more than 10 unread messages and it was very annoying trying to figure out if there was a new one, since the icon only showed "+"), so this way has accuracy. What I could do, though, is to add an option to show browser notifications when new messages are received.
Comment has been collapsed.
Look what I wrote to Ideman in this post. It is not a change it is removing of notifications. :( I don't care about the numbers there I just want to easily notice that there is a new message. Maybe you could just change the color of the original icon if there is/are a new message. Without numbers.
Comment has been collapsed.
That would still involve changing the icon and that's what I want to avoid, so no. The browser notifications option is still the best I can do. That way if you're staring at another part of the page you'll still be able to see the notification.
Comment has been collapsed.
That would be doable, although I can't see anything because I'm on Linux. xD
Comment has been collapsed.
Isn't there a decent browser in linux with a decent unicode support? :S
https://emojipedia.org/large-red-circle/
Comment has been collapsed.
i'm in chrome, but i don't think it's the browser. i think it's the unicode table i'm on inside of linux that sees things differently then others, and no idea if i can or how to change that. it used to only see in black and white and only work with ~20% of them until around 2months ago i got an update that enabled color for that 20% and enabled a ton more black and white. now ~80% of them work, but not very well.
Comment has been collapsed.
well since the primary supported browser for this script is chrome, i think a unicode character that is chrome friendly would be best. =)
i don't know what package that would be, there is not package inside my package manager called "utf-8" or anything that looks relative enough when searching for it or "unicode".
Comment has been collapsed.
I still guess it is browser depending. I didn't update Chrome and still see them grey (I should update it...). Linux version is another version of Chrome.
BTW you can check all emojis in the official unicode website http://www.unicode.org/emoji/charts/full-emoji-list.html
Comment has been collapsed.
Well, you should select it from the browser encoder, but it seems Chrome removed the encoding menu since version 55 since they think their auto-encoding detection is more clever than people using their browser (but ye since you are viewing emojis your encoding is utf8. If not, you would see greek or chinese characters, or just gibberish)
Comment has been collapsed.
This emoji messes up things for me https://emojipedia.org/heavy-black-heart/
Comment has been collapsed.
I dislike the title change a lot, it unnecessarily uses up half of the space of the tab, therefore I don't even see the title any more.
I don't need to see every second how many points I have left, since I don't even use up these points.
I tried to look for an option to turn this off, but I couldn't find any.
Comment has been collapsed.
It's not available yet, but more options will be added later.
Comment has been collapsed.
I like the header notification when there's a message, but doesn't want it to show the points, if you can add an option to turn it on/off... ʕ•ᴥ•ʔ
Comment has been collapsed.
71 Comments - Last post 9 minutes ago by Reidor
19 Comments - Last post 10 minutes ago by Acojonancio
7 Comments - Last post 23 minutes ago by sensualshakti
1,775 Comments - Last post 35 minutes ago by Shanti
28 Comments - Last post 1 hour ago by DiabLXIX
52 Comments - Last post 2 hours ago by BlazeHaze
24 Comments - Last post 2 hours ago by Fluffster
3,362 Comments - Last post 1 minute ago by pizurk
433 Comments - Last post 21 minutes ago by WaxWorm
103 Comments - Last post 22 minutes ago by eeev
1,865 Comments - Last post 28 minutes ago by MeguminShiro
8 Comments - Last post 30 minutes ago by gortman
35 Comments - Last post 39 minutes ago by Mayanaise
112 Comments - Last post 44 minutes ago by Ev11
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.