found a giveaway the ITAD data isn't loading on, and it has an error: (version 17.4)
ERROR: Execution of script 'ESGST' failed! Cannot read property 'querySelectorAll' of undefined
update: same error exists in 17.5 (the giveaway is priv group, or i'd share link)
Comment has been collapsed.
No line number in the error? For what game is the giveaway for?
Comment has been collapsed.
no, sorry. Monochroma
edit: i suppose you maybe whitelisted though so here's ga link > https://www.steamgifts.com/giveaway/tA4hd/monochroma
Comment has been collapsed.
Definitely not related to the game, as I found a public giveaway for it that loads just fine. Is there anything in particular about that giveaway that's different from others? I really don't understand why your Chrome doesn't say the line where errors happen. :P
Comment has been collapsed.
ahh after enabling verbose console i get more details.. not exactly the line number, but probably enough to determine where in the script.
TypeError: Cannot read property 'querySelectorAll' of undefined
at Array.loadNpth (eval at E_c (:3:221), <anonymous>:10951:35)
at loadEsgst (eval at E_c (:3:221), <anonymous>:2876:43)
at eval (eval at E_c (:3:221), <anonymous>:417:5)
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:221), <anonymous>:26513:3)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
at Object.eval (eval at E_c (:3:221), <anonymous>:26514:6)
at <anonymous>:2:398
at Object.E_c (<anonymous>:3:219)
also i edited prior comment with the other answers.
Comment has been collapsed.
oh actually i found several more. here's a public example.
edit: i just saw same message.. no, nothing different, i just keep finding them in clumps. like 5-6 working in a row, then 5-6 not working in a row it seems. idk why on line number either. i guess it lacks that in the linux version.
edit2: a working example
edit3: oops, that's regionlocked working non-regionlocked
Comment has been collapsed.
Why ESGST loads on http://store.steampowered.com? And sometimes change loaded page.
Comment has been collapsed.
It loads no matter what, but it should not redirect anymore in the latest version.
Comment has been collapsed.
Should be fixed in the latest (it now shows a trophy instead of coloring).
Comment has been collapsed.
There's no problem. It says "Pop up the giveaway description before entering, if any.". If there's no description it won't pop up the box and you will be entered to the giveaway automatically.
Comment has been collapsed.
Ah, nevermind my previous comment, you confused me with the word "box". But I see now that you mean the button. Are there errors in the console (F12)?
Comment has been collapsed.
Oh, sorry .Here it is
Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
It gives me this https://cdn.steamgifts.com/js/prebid_v3.js
Comment has been collapsed.
Not related to my script. If you refresh the page a few times, are the same giveaways always missing the button or is it completely random?
Comment has been collapsed.
Just to let you know; changelog.txt is missing the 17.10 update.
Comment has been collapsed.
I just exported all data to a .JSON file and then imported it on my laptop (in both cases with everything checked except for 'Merge current data with the imported one').
On my laptop I first updated to 17.10 (it was an old version 5 before, I think).
Now the settings are not restored at all (an no idea if anything was).
Weird, you'd assume an export from 17.10 to another Firefox running 17.10 would work without any problems.
Comment has been collapsed.
Hi rafaelgs18,
I also have the same issue but the version is 17.9. In fact, this issue have happened several times since v6 beta. Sometimes the data didn't show on the management page (I have checked the size of sql file, and it is larger after I imported it.). Sometimes the data seemed normal but some functions didn't work.
Could you give me some advices for this issue?
By the way, I usually export all data on the management page (selected all option).
And my browser is Firefox with version v54.0.1 and Greasemonkey is v3.11 (both newest).
Comment has been collapsed.
The problem is only the settings not being imported? If so, it's a bug, I'll fix it later.
Comment has been collapsed.
No, this time, nothing is imported. I mean the size of sql file is become larger after it was imported. But neither the setting nor the data (whitelist, blacklist, user data...) was showed on the management page. That's strange. I think I will try copy the sql file tomorrow and see what happened.
Comment has been collapsed.
I still don't quite get it. That data doesn't show on the management page. Did you have the "merge" and "user data" options enabled when importing?
Comment has been collapsed.
I selected all option instead of decrypted giveaways data. And I tried the merge option, no luck. Then I close browser and delete the sql file directly. After that, I imported again w/wo merge option, still no luck. Really strange.
Comment has been collapsed.
I tried replace the .db file, it works but the import function still broken after I upgraded to v19.7. Even I tried to delete all data on the management page, sometimes the data just still there, sometimes the setting is the same and other data is deleted. Uninstall the script and delete the .db files, and then reinstall and import also didn't help.
I also found another issue I think it may be a bug. If a GA is created for whitelist and groups, and I am not in any groups set by the creator but I am in his/her whitelist, I can enter that GA and see all groups in that GA. If I turn on the Giveaway->Giveaway group loader, the loader will not load the group of that kind of GA and kind of FREEZE after that GA. So it is just like the following illustration:
GA1
blank (above GA all blank)
GA2
blank
GA3 (the one with whitelist and group I described above)
a group icon but no groups are loaded
GA4
groups loaded
GA5
groups loaded
If I also turn on the "Only load groups after clicking the group icon in the giveaway, as a popup." and click the group icon of that GA, it just keep loading (loading icon). But if I turn on " Only show groups that you're a member of." instead, that kind of GAs would keep blank and other GAs could be loaded successfully
Screenshot:
Comment has been collapsed.
There are just some security warnings, no errors (related to the unsafe content (user's avatar) in encrypted page).
Comment has been collapsed.
I don't think the script is currently importing settings, I had a problem with that as well.
Comment has been collapsed.
Sorry for double posting about this issue but the "entries remover" feature still doesn't work. It didn't work before the design change (at least during the last 1-2 weeks) and it still doesn't work.
It always says that "0 entries removed" and doesn't remove any entry even when there are entries that should be removed. Tested it now with many games and by disabling every other Steamgifts script but ESGST and still doesn't work.
Thank you for this otherwise really awesome script and keep up the good work!
Comment has been collapsed.
It's not working for me either.
I was entered into this one: https://www.steamgifts.com/giveaway/op0jD/destruction-48 and I synched just a minute ago, having just added that game and the other ones from an IndieGala bundle.
The entry was not removed.
Comment has been collapsed.
If you want to be sure a bug will be fixed or a feature added, you have to use Github issue tracker. This topic already has thousands of comments and for rafaelgs18 it is impossible to remember all issues mentioned here.
Comment has been collapsed.
I'm gonna start opening tickets myself for people who report issues here instead of there because they're not registered, which is probably something that I should have started doing a long while ago, but I didn't know I could open issues. :P
Comment has been collapsed.
I don't even remember you first reporting that issue. :P Thanks for reminding me, will look into it today. And thanks Pilda, for opening an issue on GitHub.
Comment has been collapsed.
Try in the latest version. There was a bug in the game sync that might have been the problem.
Comment has been collapsed.
I was able to try it out finally. Sorry, but it seems that it still doesn't work. When I sync games it goes through pages then writes that nothing found. Nothing found even when I'm using the special button on the Entered page.
After that I leave the giveaway in question and try to reenter is but Steamgifts doesn't let it happen so it is visible that I already have the game.
Comment has been collapsed.
Updated my main install, the shared groups checker still misses exactly the same groups
here's another public one:
https://www.steamgifts.com/group/nNgib/keysadded
I'd have tons of more feature ideas and bugfixes to provide, would direct code contribution be taken and would new features require some sort of prior approval?
Comment has been collapsed.
That's because I haven't looked into it yet, so it hasn't been fixed.
Well, I would of course have to analyze the code contribution before adding it and possibly modify some things, but you're free to make pull requests on GitHub anytime you want. You can also provide the feature ideas and I can work on them as well, I've accepted pretty much all feature suggestions made so far and implemented them.
Comment has been collapsed.
First was just to confirm to not be a singular browser/sync issue.
I just don't want to come across as a beggar every-time xD so instead I do the work myself then too. Speeds up development overall as well, and the for me important things get in quicker ;-)
About features acceptance, I generally meant if I should outline those first before I write all code and then it may get rejected.
Comment has been collapsed.
You wouldn't come across as a beggar at all. But if you want to do the work yourself, then it's no problem.
Yes, it's probably best if you outline them first, because I might also already be working on them.
Comment has been collapsed.
You could, you know, report what's broken so I can fix it. :P
Comment has been collapsed.
blob:http://imgur.com/a16a70ae-43b8-4ccd-8ea9-04347646ecc5 This is popping up all the time, and notes and WL/BL icon next to avatar disappeared (those was the features that i used the most), Also i couldnt reply to the thread with the script activated.... every time that i clicked on submit, it just redirected me to: https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta197-new-feature-train-giveaways-extractor/search?page=39
Comment has been collapsed.
Can't see any image.
If you were using a very old version of the script, you need to go back to a previous version first, to make sure your data is carried on. Or export from the old version and import to the new version. If you came from v4, you have to go to v5 before going to v6.
The icons don't appear even after syncing?
Did you have Discussion Edits Detector enabled? Because apart from that feature, there is no other feature that interferes with the main submit button.
Comment has been collapsed.
Someone reported that the script performs much better on GM than TM, and I confirmed that, I get much less memory consumption while using the script with GM. So I stopped being lazy and implemented a Header Refresher that was compatible with GM. ^^ It changed a few days ago.
Comment has been collapsed.
This is a request I made for another script, but I'd like you to consider it for your fine script:
Recommendation regarding hidden games/DLC
SG has a little icon that looks like and eye with a line through it that allows you to hide a game/DLC. However if you are on the page of a GA (perhaps the link was in a forum post or part of a train) you still see the GA (and the "Enter Giveaway" button is still active) for that game/DLC even though it may be hidden.
I have noticed that on the GA page for games I have hidden that the eye-slash (hide) icon that normally is displayed next to the game name is missing (indicating that the game is already hidden), however this is very easy to miss.
Would it be possible to have ESGST look to see if this icon is missing and if so "disable" the "Enter Giveaway" button? Maybe disabling it is too harsh, perhaps making it a different color (and perhaps labeled "You have hidden this item.") so that it is easy to see that you have hidden the game/DLC? Perhaps if it is pressed having a pop-up "are you sure?"
The reason for this request it that I own many DLC and it is hard to remember which ones I own, and SG has a hard time knowing that info as well, so on SG, I hide any DLC that I own. I don't want to accidentally enter a GA for a DLC I already own, so making the button a different color will make it much easier to see that I already own it.
Thanks for your time!
Comment has been collapsed.
What about a "Hidden" category in Game Categories?
Comment has been collapsed.
Well, colors are already customizable. I could add it as category AND disable the button as SpaceClick suggested as well, I think that would be best.
Comment has been collapsed.
I also don't think disabling the button is harsh. I think if someone hid a game they obviously don't want to enter giveaways for that game, so it would make better sense to disable it completely.
Comment has been collapsed.
I think I blinked and missed it... Thanks!
Now I'll have to find a GA for a game I have hidden to see how it looks...
Comment has been collapsed.
How do I get this to work? I see the "Hidden" indicator on the page but the button is still active.
EDIT: Oops, missed the option in the settings, don't know why, I mean it's not like there are like a hundred options... :-)
Works now, thanks!
Comment has been collapsed.
Just check the changelog when I add stuff. I add the full path to the location in the settings where you need to enable it, just need to follow the numbers. :)
Comment has been collapsed.
I'll make some changes to the extractor so that it works in cases like that.
Comment has been collapsed.
To highlight games you already own there is Game Categories. I'll see about hiding.
Comment has been collapsed.
I really like the function that greys out already visited thread. After updating, this doesn't happen anymore. I tried a few options but couldn't find the right one. What do I have to do, to grey out already visited threads again?
Comment has been collapsed.
It is a button that looks like a train and a search icon on the page heading of any train giveaway, that brings up the popup with the extract button.
Comment has been collapsed.
What is there to explain? It extracts giveaways from trains.
Comment has been collapsed.
Ah, that. Yeah, I forgot to include screenshots and add the location of it, sorry about that. I thought you were asking what the feature does.
Comment has been collapsed.
Did you test in Pilda's train with the latest version, though? Because that was fixed.
Comment has been collapsed.
sync bug with "Sync owned/wishlisted/ignored games." version v6.Beta.19.1
Uncaught TypeError: Cannot read property 'responseText' of null
at continueGameSync (eval at E_c (:3:221), <anonymous>:4312:37)
at <anonymous>:2:398
at e.string.k.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:55:352)
Comment has been collapsed.
I'm getting a few Errors with the new version
F.e. on the main page:
Uncaught TypeError: Cannot read property 'type' of undefined
at filterGfGiveaways (eval at E_c (:3:221), <anonymous>:7963:15)
at checkGcComplete (eval at E_c (:3:221), <anonymous>:23324:17)
at <anonymous>:2:398
at e.string.k.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:54:352)
and when entering a GA with description, the enter pop up doesn't close automatically
Uncaught TypeError: Cannot read property 'type' of undefined
at filterGfGiveaways (eval at E_c (:3:221), <anonymous>:7963:15)
at eval (eval at E_c (:3:221), <anonymous>:9001:21)
at Function.onload (eval at E_c (:3:221), <anonymous>:4585:17)
at <anonymous>:2:398
at eval (eval at exec_fn (:1:108), <anonymous>:30:494)
Also the load time of the game categories went up again for me, can this be related to the errors or did you chnage something there?
Comment has been collapsed.
Fixed.
Because of the new "Giveaway Info" category, the script now needs the price of the games, so it's updating the caches with the prices. If you refresh the page, it should take the same amount of time to load as before, but loading new pages will take a while, nothing I can do about it.
Comment has been collapsed.
Yep i was indeed too impatient regarding the load times, back to normal again. :)
Popup is also closing again and the errors disappeared aside from one, which i seem to get on all pages
Uncaught TypeError: Cannot read property 'undefined' of undefined
at Window.eval (eval at E_c (:3:221), <anonymous>:8417:71)
at <anonymous>:2:398
at e.string.k.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:54:352)
And as always many thanks for your hard work and fast support :)
Comment has been collapsed.
That error doesn't really help, can you try seeing if clicking on it takes you to a more precise line in the script?
Comment has been collapsed.
Hm clicking brings me to line 8417, hover message is the same as in the console-
http://imgur.com/a/xg1b4
But while there is an error i can't see anything actually not working ...
Comment has been collapsed.
Sort of, the old error is gone but now i get
Uncaught ReferenceError: game is not defined
at Window.eval (eval at E_c (:3:221), <anonymous>:8420:474)
at <anonymous>:2:398
at e.string.k.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:55:352)
Comment has been collapsed.
First a few games didnt show it had trading cards. Close the browser and now game categories doesnt show on any game.
Comment has been collapsed.
Game tags worked again after I synced. Was stuck a while at "Sync owned/wishlisted/ignored games." so aborted and refreshed the page and the tags was visible again.
Comment has been collapsed.
Were you in the latest version? Because there was a bug while syncing that was fixed. Do you mean "game categories" by "game tags"?
Comment has been collapsed.
By game categories I mean the wishlist, owned, hidden, trading cards tags etc.
Problem came when I last updated about an hour ago. But I have received two new messages since that update that there is new version. Either way, it works now.
Comment has been collapsed.
Well, doesnt seem like the tags work at 100 %
I was going through my hidded game and I have 2842 hidden and only 1 game showed it had trading cards. I accidently hid som games that probably had cards when the tags stopped working on some games.
I checked the wishlist page and no game had a wishlisted icon. Went to steam store and saw I had Access Denied on the page. Eventually steam store started working again, i synced ESGST and checked wishlist page and the first pages seemed to show on every game. The pages after that was a little spread out on what games worked and not. And I checked the giveaways page again and not all games showed trading cards even if it should. And noticed I had access denied again on steam store.
Dont know if the script somehow causes the access denied for me on steam or if I just have a temporary problem?
Comment has been collapsed.
You get access denied when visiting what page? This one?
Maybe you hit a request limit or something? What's the name of the error?
If you already opened a page, opening it again won't alter anything because it uses cache the second time and keeps the cache for 1 week. You can force a refresh by locating the line in the script that contains function addGcCategories
and changing the number 604800000 three lines below it to 0, then load the page, and change it back to 604800000.
Comment has been collapsed.
I got Access Denied when I visited a random store page. Example
After the store pages started working again I refreshed giveaway page and it seemed to view Trading Cards icon on the games that didnt show before. And I just checked the wishlist page on steamgift and wishlist showed up on all games now.
Maybe it was a request limit like you said. I guess your scripts somehow collects the trading cards info and wishlist info directly from steam? And if storepage doesnt work it cant collect the info?
Comment has been collapsed.
Info is collected from the Store API, for example: http://store.steampowered.com/api/appdetails?appids=588650 If you can't access the API, it can't collect any info.
Maybe just wait it out.
If it's similar to this, using ipconfig /flushdns
seems to have fixed it for a user.
Comment has been collapsed.
I can just wait a couple of minutes and it starts working again. But I have quite a few pages on manually filtered games
I checked again just now in the morning. Instead of using automatically scrolling I went to page 2,3,4 etc. I think when I finally came to page 7 or 8 I got the access denied on steam again. :) So it is probably because of too many requests. I will try the flushdns and see if I can go through all pages without a problem. if it doesnt work I quess I just have to go thorugh the pages very slowely.
Comment has been collapsed.
Is there an option to enable ESGST's former settings page, or make it open a separate tab, instead of the current pop-up version?
I'm not really a fan of pop-up windows/inputs, and generally avoid them much as possible--outside of conveying supplemental information quickly and efficiently (ie. like hovering over a group giveaway to bring up a list of the included groups)
Comment has been collapsed.
No, and I'm afraid it's not coming back. The popup is much more practical, as you can access the settings from any page now without the annoyance of having to go to the account page, and it doesn't make the script tied to SG (you can also access the settings from ST). Plus, it avoids pollution in SG's account page, which could also lead to many conflicts.
Well, everything in ESGST opens in popups. xD The script revolves around the idea that the default SG page should be altered as less as possible, so making everything injected by the script open in a popup ensures that. And how do the settings not apply to "information quickly and efficiently"? :P
Comment has been collapsed.
An option has been added that allows you to open the menu in a separate tab. Alternatively you can go to https://www.steamgifts.com/esgst-settings with the latest version and it will appear even with the option disabled.
Comment has been collapsed.
oh god thank you very much!!! 💘
With all the ground the script covers and all the subjects that might overlap into different subheadings I've been having an increasingly hard tie keeping the outline straight in my head or shifting back/forth between options while testing the settings I like most together. Being able to access/associate more info at the same time will really help me a buttload! Thanks!
Comment has been collapsed.
and i hope there's a way to "hide" owned game from it
there is, but it currently isn't functioning properly for me.
see my attached gif to see how it's done though. ;) https://www.steamgifts.com/go/comment/0JfIcrN
Comment has been collapsed.
What happens when you click enter/leave? Everything is working fine for me.
Well, if the train has no previous links then it obviously can't extract on the last page. :P
Comment has been collapsed.
30 Comments - Last post 1 hour ago by brivid0boy
450 Comments - Last post 2 hours ago by klingki
7 Comments - Last post 6 hours ago by xXSAFOXx
16,297 Comments - Last post 8 hours ago by SebastianCrenshaw
52 Comments - Last post 9 hours ago by adam1224
206 Comments - Last post 12 hours ago by Joey2741
31 Comments - Last post 13 hours ago by Pika8
47 Comments - Last post 15 minutes ago by Oxxra
283 Comments - Last post 36 minutes ago by Thexder
202 Comments - Last post 1 hour ago by xkingpin
45 Comments - Last post 1 hour ago by DarkRainX
7,979 Comments - Last post 1 hour ago by eeev
137 Comments - Last post 1 hour ago by TheAgonist00
22 Comments - Last post 1 hour ago by UnknownDepth
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.