Bug: I've activated notifications with browser notifications for wishlist giveaways ending within one hour. It just so happens that I've noticed - by visiting the wishlist page - that there is a GA ending within about 22 minutes that was opened 38 minutes ago. So that is a one hour giveaway but I did not get a browser notification.
Now looking at it there's a heart in the page name on the tab but no marker as there is for new messages.
So I guess wishlist notifications is not working as intended.
Comment has been collapsed.
That's how it works. The heart indicates that there are giveaways. If by marker you mean counter, it does not have a counter because there is no place to put one.
The browser notification only appears after the amount of minutes you set the Header Refresher to refresh, otherwise every tab you opened would show a notification.
Comment has been collapsed.
Yes, I meant a counter. Ok.
Uhm... so I guess setting both timers to one hour was a bad idea. I guess I should set the header refresher to something less than an hour then. I thought both features were independent from each other.
Comment has been collapsed.
They are independent though. For example, if you have it set to indicate only giveaways ending in 1 hour and refresh every 1 minute (which is the default), every minute the script will check if there are giveaways ending in the next hour and notify about them.
Comment has been collapsed.
Ok, but then what would you suggest me to set the wishlist giveaway timer to to not miss those that only run for an hour? Especially since they probably only run for 59 minutes 50 seconds? The notification timer I've changed to 15 minutes (1 minute just seems unnecessary often to me).
Comment has been collapsed.
I still don't think you fully understand how it works. It notifies about any giveaways that end in an hour, not giveaways that end exactly in an hour. So let's stay there is a giveaway that runs from 12:00 to 13:00 and the last refresh was 11:55. When the next refresh happens at 12:10, it will notify about the giveaway, because it ends in an hour (before 13:10).
Comment has been collapsed.
Alright.
By the way, the browser pop up notifying me about your message didn't stay open. In other words, when I came back from the kitchen there was no browser notification.
So that would mean that the "Only close notifications manually." doesn't work, yet. But I'll see what happens when you reply to this.
Comment has been collapsed.
That's odd, when I tested I waited about 3 minutes and it didn't go away, and with it disabled it goes away in about 30 seconds for me.
Comment has been collapsed.
This time it showed up (before it didn't in the first place) and I waited for about 10 minutes I'd guess - it still stood open.
Comment has been collapsed.
There seems to be a bug where you can click on the notification and nothing happens:
I just get a notification saying I got a new message but - as just described - nothing happened when clicking on it. It just stood open. When closing it and surfing manually to the messages page there was no message.
Comment has been collapsed.
Wait, so there are 2 bugs? One that when you clicked nothing happened and another that it notified about messages when there were none? Can you check the console log if it happens again?
Comment has been collapsed.
No, that was happening at the same time - it's one bug.
The message that I got seemed to be deleted. You know how you get a note about a new message but when you check there is none because it got deleted by the person writing it? That's what happened and why there was no message... well, I guess.
Yep, I'll check the console although this should be a quite rare case... so this might take some time.
Comment has been collapsed.
The puzzle marker don't load in discussion
Uncaught (in promise) TypeError: Cannot read property 'getElementsByClassName' of undefined
at addPmButton (eval at E_c (:3:298), <anonymous>:32714:22)
at getValue.then.value (eval at E_c (:3:298), <anonymous>:10007:25)
at <anonymous>
Comment has been collapsed.
Issues noticed with 7.13.1 so far
- Notify errors feature not showing button or popup.
- Game ratings has a match error when all color settings are deleted which breaks game categories altogether.
-
Game categories "Use Default" button only resets to default values in settings menu, seems to not save that value so user setting will still be used.
Side note: some sections indicate new features are available but i can't find them.
Errors in console:
Uncaught (in promise) ReferenceError: i is not defined
at checkNewVersion (esgst.js:32337)
at init (esgst.js:6062)
at <anonymous>Uncaught (in promise) TypeError: Cannot read property 'match' of undefined
at addGcCategory (esgst.js:29835)
at getGcGames (esgst.js:29450)
at <anonymous>Comment has been collapsed.
The feature to notify errors does not notify about all errors yet.
The new features indicator is just leftover from previous new features that I forgot to remove, there are no new features in those sections.
Comment has been collapsed.
Are you sure about 3? I just tried the default button and the colors saved fine for me. Is it always reproduceable and does it happen for every category?
Comment has been collapsed.
Can be reproduced every time and on every category.
Comment has been collapsed.
I added something that should prevent 2, although I don't understand why someone would delete all color settings at all, but oh well.
Comment has been collapsed.
For the curious peeps here is what i used for testing giveaway chance/ratio highlighting, apply to appropriate function.
$(context).closest('.giveaway__row-inner-wrap').find('.esgst-gv-time').attr('style', 'box-shadow: 0 0 0 1px #000, 0 0 0 1px #000, ' + colors.color + ' 0px 0px 0px 8px inset !important'); /* attr used to override themes , giveaway time also useful for when steam image already has colored border */
$(context).closest('.giveaway__row-inner-wrap').find('.giveaway_image_thumbnail').css('box-shadow', '0 0 0 1px #000, 0 0 0 1px #000, ' + colors.color + ' 0px 0px 0px 3px inset'); /* giveaway image border, inset works with or without esgst image borders */
$(context).closest('.giveaway__summary, .table__row-inner-wrap').find('.giveaway__heading__name, .table__column__heading').css('color', colors.color); /* giveaway game name */
Comment has been collapsed.
That looks cool, I might add that to the script. Some users asked to add the chance colors to the Grid View color bar, so this might be time time to do that as well.
Comment has been collapsed.
Keep in mind i did it this way for quick pasting and uses values tailored to a specific theme, actual integration probably should add classes to those elements instead.
Comment has been collapsed.
Of course, there are a lot of things I have to change in that code, I just meant adding the idea.
Comment has been collapsed.
Added it to the current Dev.17. There is no way to add a class for the colors, since they are retrieved per giveaway, but I added a class to the elements. If you need anything else to make it work with the theme let me know.
Comment has been collapsed.
You can add color inline and i will have access to it (example below). While i am at it i should point out why i use box shadow instead of border, but whichever you use i can work with both.
Pros
- no need for separate code for esgst image borders.
- does not force an image resize so no performance/quality loss
- giveaways with missing images look the same
Cons
- if esgst image borders are not enabled edges of image are hidden below shadow (to reduce how much of image was obscured i originally used 3px instead of 5px)
if (esgst.gwc_h) {
giveaway.headingName.classList.add(`esgst-gwc-highlight`);
giveaway.headingName.style.color = esgst.gwc_a && !esgst.gwc_a_b ? advancedColor : basicColor;
if (giveaway.image) {
giveaway.image.classList.add(`esgst-gwc-highlight`);
giveaway.image.style.color = `${esgst.gwc_a && !esgst.gwc_a_b ? advancedColor : basicColor}`;
giveaway.image.style.boxShadow = `${esgst.gwc_a && !esgst.gwc_a_b ? advancedColor : basicColor} 0px 0px 0px 5px inset`;
}
}Ooops missed the check i'll just edit that in , nobody will ever notice muahaha
Comment has been collapsed.
Added it and made it 3px because of the issue you mentioned. I don't think it looks too bad with Image Borders.
Comment has been collapsed.
Well if the OCD kicks in you could always go back to separate code with 5px for those ;), but i like consistency so i'm sticking to 3px for each.
Comment has been collapsed.
Or and don't hate me for suggesting this you could have a setting to let users set thickness.
Comment has been collapsed.
I hijacked static popup width setting for testing
changed box shadow to have css variable so i could access
giveaway.image.style.boxShadow = `${esgst.gwc_a && !esgst.gwc_a_b ? advancedColor : basicColor} 0px 0px 0px var(--esgst-gwc-highlight-width, 3px) inset`; and in your style sheet i added
:root {
--esgst-gwc-highlight-width: ${esgst.staticPopups_width};
}Overkill or useful ?
Comment has been collapsed.
I went ahead and added the option to the latest dev version. That CSS variable isn't needed, right?
Comment has been collapsed.
It is needed, just for clarity you can add both to :root
:root {
--esgst-gwc-h-width: ${esgst.gwc_h_width};
--esgst-gwr-h-width: ${esgst.gwr_h_width};
}Comment has been collapsed.
I don't see why it is needed? I mean, it's not like the width needs to be styled? Seems a bit pointless, since the value is already added during the execution. Maybe I'm missing something.
Comment has been collapsed.
The inline style can use javascript variable or css variable that part does not matter, but i do need the css variable in the style sheet. It is so i can make changes to box-shadow while keeping user set values. I use a box-shadow on those currently so to keep that plus have the user set values i do something like so.
.esgst-gwc-highlight[style*="color"][style*="box-shadow"] {
box-shadow: 0 0 0 1px var(--SG-Dark-Grey-image-border-color), 0 0 0 1px var(--SG-Dark-Grey-image-border-color), currentColor 0px 0px 0px var(--esgst-gwc-h-width, 3px) inset!important;Comment has been collapsed.
I have some plans to allow the user to specify the URLs where they want some features to run, so I'll see if I can do that for the next version. That should take care of your request.
Comment has been collapsed.
Check the new functionality in the latest version, it allows you to specify where features run.
Comment has been collapsed.
Bug: elements dragged into giveaway columns are also applied to .esgst-gv-icons.giveaway__columns.
Comment has been collapsed.
From Game Categories, right? I'll have to add a separate storage for Grid View like I did for the chance/ratio/enter buttons.
Comment has been collapsed.
I'll look into it. Try disabling Header Refresher > "when clicking on a browser notification, check if the related page is open and set it as active" in the meantime.
Comment has been collapsed.
'notify errors' means that the errors are contacted (about something else)
show errors is the easiest way to express it
Comment has been collapsed.
I believe it could also be interpreted as "notify errors to the user". I don't think "show errors" is very accurate.
Comment has been collapsed.
Havent been able to use send unsent gifts for about a week.
Get this i console
ReferenceError: code is not defined
[Läs mer]
created%20line%202%20%3E%20Function:19689:25
It just says
Retrieving groups (page 1 of 1)...
0 of 2 giveaways checked...
And it loads but nothing happens.
I just have "Do not send if the winner is no longer a member of at least one of the groups for group giveaways" checked.
Comment has been collapsed.
Sorry, haven't been able to look into it yet, will see to it tomorrow.
Comment has been collapsed.
I had one not marked received so I tried with that one.
Just says
Checking if USER is a member of one of the groups...
0 of 1 giveaways checked...
Nothing happens just keeps loading. I checked console while I pressed sent and no new errors.
Comment has been collapsed.
Does it go through if you disable the option to check groups? I was sure I fixed it, but maybe I overlooked something. You're in v7.14.1, right?
Comment has been collapsed.
Sends without a problem when not checking groups.
Yes, I have newest version. Even restarted firefox and synced everything :)
Comment has been collapsed.
Hi, saw it came a new version but still not fixed. Just wanted to check status. :)
Still stuck at " Checking if USER is a member of one of the groups... "
I only have " Do not send if the winner is no longer a member of at least one of the groups for group giveaways. " checked and send unsent gifts works fine if I uncheck it.
Comment has been collapsed.
This shows in log when loading the page "Användning av Mutation Events är föråldrat. Använd MutationObserver istället. created:2:110"
Comment has been collapsed.
How do I hide the giveaway always when I join it ? I formatted my PC and forgot to do the backup, in my old config had this feature enabled but I cant find it anymore :/
Comment has been collapsed.
It looks like the Group Forums are locked. :)
Suggestion / request:
Add https://www.steamgifts.com/giveaways/created to the list that gets Last Page Link added.
Comment has been collapsed.
Are you sure? I have the forums' "Who can view?" and "Who can post?" settings set as "Anyone".
Comment has been collapsed.
http://steamcommunity.com/groups/esgst/discussions/1/2549465882932218647/
This topic has been locked by a moderator, no replies can be made.
Comment has been collapsed.
Oh.
Somehow I assumed there would already be active discussions there. :P
Comment has been collapsed.
Anyway, just came back for the suggestion and it is not possible. That page does not have the total number of giveaways in the pagination, and linking to a big number like 999 doesn't redirect to the last page, so there's no way to tell unless a lot of requests were made, and that's just not a good solution.
Comment has been collapsed.
Thanks for looking. :)
Can you take the sent count from the main profile page (Last button works there) and estimate the count for Created last page?
Comment has been collapsed.
Wouldn't be accurate if the user has deleted giveaways. This should probably be suggested to cg. After all, the entered and won pages do have the counter, so I don't see why the created page shouldn't have it.
Comment has been collapsed.
Bug?:
When using steamgift's search and wanting to filter the results afterwards, there are no "Basic Filters" (Type and Category filters are still there) in the "Expand filters" box.
Sure, I could turn on "Advanced Giveaway Search" (2.1) but I'd rather not have this extra box using screen space when there's already the expandable filter box that has (should have) all the filters needed.
Comment has been collapsed.
That's because if you're searching with SteamGifts' search you are obviously wanting some specific results, so it makes no sense to enable basic filters there.
Comment has been collapsed.
Oh, so this doesn't work on purpose. I see.
Well, it would make a lot of sense to me. Let me justify why: I search for a title but then notice that it's way too many results for me to enter all of them (especially for currently bundled games). With filters (like min. level, chance,...) I can make further adjustments to narrow the results down to an amount of giveaways that's fine for me.
In cases where there's only few results anyways no basic filters are needed indeed - it's just when there's pages over pages of results for a game when it would come in really handy to have those filters available.
Comment has been collapsed.
As far as I know, if you didn't include advanced filters in your search (like level_min=5) the basic filters should be there. Do you have advanced filters in your search?
Comment has been collapsed.
You mean, did I type in e.g. "level_min=5" into the search when searching? Nope, I didn't even know that was a thing.
Comment has been collapsed.
In the URL. For example, https://www.steamgifts.com/giveaways/search?level_min=5 only returns giveaways above or equal to level 5. That's what the feature Advanced Giveaway Search does for you. And more details about it can be found in cg's thread: https://www.steamgifts.com/discussion/1kgzB/new-search-parameters
Comment has been collapsed.
There is indeed an issue. The basic filters are only supposed to be hidden if the search was made with advanced filters. I'll look into it.
Comment has been collapsed.
Should now be working as intended in the latest dev version.
Comment has been collapsed.
I've just checked and it does. Thanks!
With the dev version I also got a popup saying "There are ESGST errors in the console, use Ctrl + Shift + J to view them" - 1 of 5 is the typical google-analytics error I'm getting on steamgifts - I guess it's about time this one gets fixed by cg - and 4 errors saying "notificationsounds.com/notification-sounds/confident-543/download/mp3 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT".
Comment has been collapsed.
Nope, that URL is correct. Try disabling the new options to play sound with the notifications or use another URL to see if the issue goes away. What happens if you visit https://notificationsounds.com/notification-sounds/confident-543/download/mp3 on your browser?
Comment has been collapsed.
I'm using a script blocker - but even without I'd suggest using system (or browser) notification sounds instead of having the script download random files on peoples machines? Just a thought.
Or maybe rather make it an opt-in instead of an opt-in?
Comment has been collapsed.
I don't know what you mean by browser/system notifications, if you know any API for that please let me know.
The script doesn't download random files on peoples' machines, it loads the files on the page.
But anyway, I added a fix to it in the latest dev version so you should stop getting the popup error.
Comment has been collapsed.
I don't think an API is needed. The system sound files are - if not changed by the user - always stored in the same system folder. Therefore you only need to specify that and your good to go (see this thread)
"random" as in "alien to the users system".
You can also simply create your own sound within the script and be completely independent of other sources (check here):
import javax.sound.sampled.*;
public class SoundUtils {
public static float SAMPLE_RATE = 8000f;
public static void tone(int hz, int msecs)
throws LineUnavailableException
{
tone(hz, msecs, 1.0);
}
public static void tone(int hz, int msecs, double vol)
throws LineUnavailableException
{
byte[] buf = new byte[1];
AudioFormat af =
new AudioFormat(
SAMPLE_RATE, // sampleRate
8, // sampleSizeInBits
1, // channels
true, // signed
false); // bigEndian
SourceDataLine sdl = AudioSystem.getSourceDataLine(af);
sdl.open(af);
sdl.start();
for (int i=0; i < msecs*8; i++) {
double angle = i / (SAMPLE_RATE / hz) * 2.0 * Math.PI;
buf[0] = (byte)(Math.sin(angle) * 127.0 * vol);
sdl.write(buf,0,1);
}
sdl.drain();
sdl.stop();
sdl.close();
}
public static void main(String[] args) throws Exception {
SoundUtils.tone(1000,100);
Thread.sleep(1000);
SoundUtils.tone(100,1000);
Thread.sleep(1000);
SoundUtils.tone(5000,100);
Thread.sleep(1000);
SoundUtils.tone(400,500);
Thread.sleep(1000);
SoundUtils.tone(400,500, 0.2);
}
}Comment has been collapsed.
Java is not Javascript, and like I said, the script cannot access local files, but I already figured out how to do it, don't worry.
Comment has been collapsed.
Well, you know I'm not a programmer.
Generating a sound from within the script as in the example wouldn't work either? Just curious.
Comment has been collapsed.
Just pushed it, it now has a default sound created from within the script and also allows you to upload a different file from your computer.
Comment has been collapsed.
The update didn't work so I grabbed the new dev version. I'm still constantly getting the error message "There are ESGST errors in the console, use Ctrl + Shift + J to view them" though. (And by the way, Ctrl + Shift + J is not the right combination for Chrome. That would be Ctrl + Shift + I as in India. And it opens the console but not the error section of it.)
This is the errors I'm getting - they don't seem related to ESGST though:
Comment has been collapsed.
There wasn't any update, it's still in the dev version. You get the errors in any page? Ctrl + Shift + J is the right combination though, it works fine for me.
Comment has been collapsed.
I thought because you said you pushed it.
Yep, I'm getting it on any page.
Never mind, "I" is the console, "J" the errors.
Comment has been collapsed.
Hmm, maybe the script detects errors from SG as if they were from the script. Do you get those errors in the messages page, since there are no ads in the messages page?
Or it's your script blocker?
Comment has been collapsed.
As I've said yesterday, yes I'm using a script blocker. The only scripts being blocked though on steamgifts are those from google-analytics and from googletagservices - and neither is related to the error message.
Having the live log of the script blocker open there was nothing blocked by it when the last error just occurred. Judging by this the script blocker is not involved in the issue at all.
Yes, I'm also getting the error pop-up on the message page. I'm not getting it with every single page visit but every other or every third or so on any steamgifts page - no matter which one.
Comment has been collapsed.
I don't understand, the error messages clearly say "www.googletagservices.com" and "www.google-analytics.com", so how could they not be related to the error message?
Can you check the console when you don't get the popup and see if those script block errors are there as well?
Comment has been collapsed.
The second paragraph explains that: Nothing is blocked at the moment the error (i.e. the error message popping up) happens. Apart from that, both scripts get blocked every single time a steamgifts page gets loaded - but the error message doesn't pop up every time.
So, when I say "the error" then I'm talking about the pop-up message, not the errors show in console.
The errors change depending on the page I'm at. On the messages page it's only the google analytics one, on GA listing pages it's those you see in the screenshot which I've added to my comment from an hour ago.
Comment has been collapsed.
Well, I can't figure out why. Could be related to the script, because I use the extension and I'm not getting that here. You might want to downgrade from the dev version until I can figure out why it's happening.
Comment has been collapsed.
How about an option to turn off error message pop ups? That would do the trick.
Comment has been collapsed.
Well, the version before the dev version also produced the error message pop-up (as you can see in my comments from yesterday). So... yeah. Not sure what to do.
Comment has been collapsed.
I think I remember very well you mentioning the bug only after updating to the dev version, but maybe I was mistaken.
Comment has been collapsed.
I just re-read your comment and you did say it was happening with the dev version.
Comment has been collapsed.
Yes, but after that I again updated to the next newer dev version after you said you just pushed it. Besides that even before that I was on the dev version since - I also mentioned that - the update doesn't work and if I recall correctly, the version I had on before was from 17 days ago.
EDIT: So I guess I should have said "previous dev version" instead of just "previous version". My bad.
Comment has been collapsed.
That's what I meant, maybe you should downgrade to the last public version, didn't it start happening when you upgraded to the dev version?
Comment has been collapsed.
I said before the last update I already was on the dev version. Last time I was on the public is now at least over 17 days ago.
That means it didn't happen from public to dev but from dev to dev.
How do I downgrade - github can't show the RAW of it because the file size is too big (that's what it says)?
Comment has been collapsed.
Ok, I downloaded the git, extracted the user scrip, opened and copied everything over into the browser script; so I should be back on the current public version.
Comment has been collapsed.
I just checked the settings and interestingly they all are turned off. So... seems like the script tries downloading them nevertheless.
Comment has been collapsed.
Another way - but surely more complex - would be the option for people to pick a sound from their files that's going to be played in case of a notification.
Comment has been collapsed.
It should be using
var audio = new Audio('audio_file.mp3');
audio.play();
And for the variable pointing to the address of the sound you simply make a user input to define it.
I don't see why this wouldn't work.
Stackoverflow has several exapmles for this or similar approaches.
Comment has been collapsed.
Decided to look for an alternative to ESG and stumbled upon your extension. I have to say the amount of features is insane, for someone like me who loves customization and features ESGST is amazing.
However I have some issues with it so I'd like to ask for some help.
- I can't comment on thread (I can reply to people) if I have endless scrolling turned on. It seems like the reply box is placed after the last comment on a page, so if I use endless scrolling I don't have easy access to it.
- Is there no option to hide entered giveaways or did I miss it? It's a great feature that ESG has and I got so used to it because it removes the clutter from the giveaway page by not showing entered giveaways. If it's not available would it be something you'd consider adding?
- Is it possible for you to make an option to put win chance, enter button, etc. on the same line as the giveaway creators name, etc? This is how it looks on ESG. This way the giveaways list is a lot neater and more comfortable to go through in my opinion.
Comment has been collapsed.
- You could enable Reply Box On Top, which puts the reply box on top, or Reply Box Popup, which adds a button to the heading that allows you to open the reply box at any point in the page.
- Enable Giveaway Filters > Multiple Filters. That will add a filter panel below the heading in the main page where you can customize your filters. To hide entered giveaways, set the Entered filter to "hide all".
- Sure, I'll look into it. Reason why I put it below is because sometimes there can be a lot of items in that line, which is bad for users with small screens (like mine, which is 1440x900 resolution) and breaks things, but I guess allowing the user to decide on their own is not a problem.
Comment has been collapsed.
Thank you for such a quick reply!
I went through all options slowly and I still missed the "Reply Box on Top" when I was deciding what to activate/de-activate. There are just so many options, I love it! Activated it now along with the giveaway filters for entered.
I'm really glad you're willing to take some time to look into what I requested in #3. I love neatness probably as much as I love options.
PS: Is there an option to disable the feature that automatically marks my comments as read and fades them? I also don't have the icons on my comments to mark them as read/unread/etc.
I would only like discussions to be automatically marked.
Comment has been collapsed.
The settings menu has a search bar where you can search for features.
PS: Is there an option to disable the feature that automatically marks my comments as read and fades them? I also don't have the icons on my comments to mark them as read/unread/etc.
No, because it doesn't make any sense to have them there, unless you can tell me a scenario where it does. If you wrote the comments you clearly read them.
I would only like discussions to be automatically marked.
Marked as what? Read or visited? If read, enable Comment Tracker > Enable simplified version. For visited enable Giveaways/Discussions/Tickets/Trades Tracker > Mark discussions as visited when visiting them.
Comment has been collapsed.
Well basically I am only interested in knowing which discussions I opened already, so this feature is great when it comes to that. On the other hand faded comments annoy me while going through the thread and wouldn't want mine or anyone else's to be faded. I'm not saying there's a fault in your logic, it's just a personal preference so I would like to have more options here.
I hope I'm not bothering or annoying you too much with my questions and suggestions.
Comment has been collapsed.
In that case you should disable Comment Tracker altogether. Giveaways/Discussions/Tickets/Trades Tracker is the one that tracks discussions. Comment Tracker tracks comments.
Not at all.
Comment has been collapsed.
Aaah, I see. The information about Comment Tracker says (among other things): "Fades giveaways / discussions / support tickets / trades you have already visited." So I thought I have to have that enabled as well.
Thank you for all the help.
Comment has been collapsed.
Yeah, that functionality was originally a part of Comment Tracker, but it was later separated into its own feature by popular demand. A lot of feature descriptions are outdated, because the script is constantly changing, so they can be confusing for new users or users who haven't been following the changelog. If you have any questions about other features feel free to ask. I have to reserve some time when I can to update the information.
Comment has been collapsed.
Sure, I'll look into it. Reason why I put it below is because sometimes there can be a lot of items in that line, which is bad for users with small screens (like mine, which is 1440x900 resolution) and breaks things, but I guess allowing the user to decide on their own is not a problem.
Probably shouldn't apply this to gridview, and speaking of which i noticed level is missing in gridview. And don't forget to enable dragging back if there is nothing there ;)
Comment has been collapsed.
I don't see an issue with applying it to Grid View. It's up to the user to decide how to use it.
Are you talking about the level missing in the latest dev version?
Comment has been collapsed.
Yeah in the dev version. i see it was more than level but you already corrected it.
Edit: Now there is an issue with gridview though. There are pages with and without gridview and currently anything moved from a non-gridview page will be added into .esgst-gv-icons.giveaway__columns. The other thing is by default the enter button order is first in gridview and last out of gridview, so that might confuse people since it gets moved in both at the same time.
Comment has been collapsed.
I'll see if I can add a separate storage for Grid View, so that changes on Grid View affect only Grid View and changes on normal view affect only normal view.
Comment has been collapsed.
Personally i don't see a need to rearrange any of the 5 elements at the bottom of the gridview popout, but if seperate storage solves the problems i guess it's a bonus.
Comment has been collapsed.
Like I said, I don't see an issue with allowing the rearrangement of the items in Grid View. Especially since with this new feature you can, for example, move the chance of a giveaway to the outside box, so some users might want the ability to see all chances of the giveaways at a single glance (although I don't think the style looks good at the moment).
There's no issue in giving complete freedom to the user to decide what they want to do. Some users won't see a need to do so, but others will.
Comment has been collapsed.
Done, in the latest dev version changes on grid view should affect only grid view.
Comment has been collapsed.
So far so good except i can't get chance and ratio to stay in .esgst-gv-icons.giveaway__columns it moves back into the popout on page refresh.
Edit: ratio will stay if chance is absent but chance won't stay no matter what. Even just rearranging chance and ratio inside the popout gets moved back to original position on page refresh.
Comment has been collapsed.
Hmm, when I tested it seemed to work fine, will check again.
Comment has been collapsed.
¯\_(ツ)_/¯ i can't import, export, or delete settings either to try fresh. Also if you move everything out of .esgst-gv-icons.giveaway__columns you can't move anything back.
Comment has been collapsed.
You mean there is a bug when importing/exporting/deleting settings?
Comment has been collapsed.
What happens when you try to export to the computer?
Comment has been collapsed.
So weird, are all options selected correctly? Are they selected when you open the export menu or do you have to select them?
But if you want to reset the order of the columns you can run this code in the debug menu:
delete esgst.settings.giveawayColumns_gv;
delete esgst.settings.giveawayPanel_gv;
setValue(`settings`, JSON.stringify(esgst.settings));Comment has been collapsed.
Export opens with everything selected except the following.
-
Discussions
- Main
- Puzzle Marker
-
Games
- Main
-
Giveaways
- Main
-
Groups
- Main
-
Tickets
- Main
- User Suspension Tracker
-
Users
- Main
- User Tags
-
Winners
In the current dev build it will export if i don't select anything, but for example if i select all it exports to an empty file.
Comment has been collapsed.
Try in the latest dev version, the import/export/delete and the color default should be saved now.
Comment has been collapsed.
import/export/delete works but game category text color still does not change to default, also .esgst-ged-source was not included in the movable elements.
Comment has been collapsed.
I read the changelog when I got pop-up informing me the extension was updated and I was very happy when I saw you added that. Thanks for that!
I can't figure out how to do it though. I scrolled through all options and I don't see one that allows me to change location of the enter button and other things.
I would appreciate if you could explain how to do it.
Comment has been collapsed.
Just go to the main page and drag them in the giveaways. I was going to add a GIF showing how to do it but got lazy. :P
Comment has been collapsed.
Ah, I figured out why it didn't work. I thought the extension was automatically updated since I got a pop-up telling me there's a new update, but it wasn't.
I manually updated it now and it works. Thank you so much for adding this.
Comment has been collapsed.
Yeah, the popup is just to notify you about the update.
You're welcome.
Comment has been collapsed.
I just gave ESGST a try after using ESG for a very long time, and holy shit, there are so many options! But: Is there an option to hide entered giveaways instead of fading them? I dislike seeing dozens of giveaways I entered, I loved that feature on ESG.
Comment has been collapsed.
2.15. Giveaway Filters
Enable 2. Multiple Filters and enable 17. Entered
Save the configuration you want as a preset
Comment has been collapsed.
For some reason 2.15 doesn't exist for me, 2.16 doesn't exist as well. That's weird.
Comment has been collapsed.
That's odd. Just a guess, but maybe this fixes it:
Scroll down to 9. Steam API Key
make sure you have entered your API Key there.
nvm.
Comment has been collapsed.
I entered my Steam API Key before that, 2.15 and 2.16 are still gone. I wonder if one of the other settings removed both of them.
Edit: I disabled all other settings and they still are gone. I guess this might be a bug?
Comment has been collapsed.
Odd, do you have anything written in the "Filter settings..." field?
Comment has been collapsed.
If you mean the "Filter features..." field, nothing is entered there.
Anyways, I'm using ESGST through Tampermonkey. I decided to export my ESGST settings and upload them for you, maybe they help with identifying what's wrong. I removed my Steam API Key and hope that the other settings don't include any private information of me.
Link to the .json file: Removed because not needed anymore
Comment has been collapsed.
Sorry for the delay, I just tried it and the options appear fine for me. Are you using other scripts that could be conflicting with this one? Try reinstalling the script to see if that solves it.
By the way, you can export your settings through a special button in the settings menu (the one right after the trash one). That option removes all your private information before exporting.
Comment has been collapsed.
I figured it out! I decided to uninstall the Tampermonkey extension with all scripts and installed it again. Then I installed ESGST and the other scripts again and now both settings exist. I'm not not sure why it just fixed itself, I tried reinstalling Tampermonkey and ESGST before and it didn't work.
Anyways, I'm glad that it works now, finally I have less clutter on the giveaway list. Thank you for taking your time to help me.
Comment has been collapsed.
Manage user tags in the settings isn't working.
TypeError: savedUser.tags[0] is undefined
Comment has been collapsed.
It's working fine for me. Can you give me more details? Are you editing a single user or multiple users at the same time? Does it happen for every user?
Comment has been collapsed.
I mean the "Manage User Tags" button in the ESGST setting.
Are you editing a single user or multiple users at the same time? Does it happen for every user?
They work pretty fine.
Comment has been collapsed.
Ah, ok, the way you worded it made me think the bug was happening when actually managing the tags. Probably one of your tags got corrupted somehow, I can't really tell how, but the next version will prevent the bug from happening.
Comment has been collapsed.
Bug: enter button is missing if game does not have a steam store page.
it can be forced to show by entering from giveaway page then going back to giveaways and open the description/comment popup and leave giveaway, now it will show the enter button except in the popup.
Comment has been collapsed.
Hmm, that's really weird, enter button has nothing to do with Game Categories. Do you have a page where I can test?
Comment has been collapsed.
It might not be related but it was the only thing in common l could find since there are no errors in console.
Comment has been collapsed.
Enter button appears fine for me there. Do you have Grid View?
Comment has been collapsed.
It is missing on both views, i do not have filters or game categories on though.
I deleted all data and now it shows, so must be something related to settings.
Comment has been collapsed.
Tracked it down to Games main data, it is marked as owned but i do not own it.
Correction: after checking game licenses it seems these are games i own but SG does not pick up on them.
Comment has been collapsed.
ESGST uses the store API (http://store.steampowered.com/dynamicstore/userdata) to sync your owned games, and that API detects games that the normal API doesn't (like games that were removed from the Steam API). I think SG doesn't use it because it requires you to be logged in to Steam.
Comment has been collapsed.
Related to the options of importing/exporting data to/from Google Drive and OneDrive, and the notification options on Header Refresher to set the SG tab as active or open a new tab when clicking on a notification.
Comment has been collapsed.
I can't find the extract train option in chrome anymore. Any suggestion?
Comment has been collapsed.
Add game release date to settings.
This can be used to remove recent shovel-ware from appearing in giveaways.
Please reply here if you read this, or I will contact you in several days as this seems an important feature.
Comment has been collapsed.
No need to contact, I read everything in this thread. It's better to report bugs/suggestions in the GitHub issues page or the Steam group forums though, as it's easier to keep track of issues there.
But anyway, what do you mean by settings? Game Categories?
Comment has been collapsed.
Yes. It is game categories. Currently we can chose to show additional information of the games such as availability of trading cards, ratings, genres,... etc.
But it is good if the release date can be also shown. So we can decide whether it is a recent shovelware without opening the store page of the game. We can see a lot of such giveaways these days. Hopefully it will be lot easier to avoid such giveaways if you implement this feature. Thanks for this cool script which saves a lot of everyone's time.
Comment has been collapsed.
wow. that's so fast than expected.
I will report on GitHub if there is any issues.
Thanks!
Comment has been collapsed.
You might find issues when filtering, there is a bug in the current public version that filters all giveaways regardless of their dates, which has already been fixed in the dev version.
Comment has been collapsed.
And I find that in some giveaways, categories are not shown. In the following screenshot, you can see that release date is only shown in the 3rd one, a question mark is shown in the 2nd one and there is nothing shown in the first one. Why is that?
Comment has been collapsed.
Game Categories uses a cache, and it is only updated once every week, so those games missing the date might be from the old cache. You can wipe your cache by deleting esgst_gcCache from your localStorage (if you don't know how to do that let me know and I can help you). That will force all games to update.
As for the second one, you can see it also doesn't have any other category, so probably that information is missing (I think it's a package? I don't believe packages have release dates).
Comment has been collapsed.
On main giveaway page, the enter button is under the "level image" and not beside it.
Edit. Now when I updated the page. The level image moved next to time remaining :)
Edit2: Seems I could drag and drop them wherever I wanted. I accidently dropped a trading cards tag so it got removed. When I updated page every tag for trading cards vanished. How do I get them back? :)
Comment has been collapsed.
Yeah, I noticed that. But I accidently dropped a trading cards tag. So everyone vanished now. :) How do I get them back?
Comment has been collapsed.
You dropped it where? It should be there somewhere.
Comment has been collapsed.
It must have moved to under the field that says username and creation time. I moved that away and saw text that said trading cards and then I managed to move the tag back :) Before that it was invisible from the page.
Comment has been collapsed.
Yes, looks like it. I was aware I could drag things around in discussion but havent tried it on giveaway page. They must have moved by themselves because the second time I updated the page I didnt touch anything and they moved again.
Comment has been collapsed.
Well, I'm unable to reproduce it so let me know if it happens again.
Comment has been collapsed.
I was sure also "Bookmark giveaway" and "Hide giveaway" had switched places. I tried to move them myself but guess thats not possible.
Either way. Now when I was going to bookmark a GA. It moved to the correct place. And when I updated the page it moved to the wrong place again. I know I was certain that Hide was first and bookmark was second, because it just felt wrong until I clicked it and they switched back :)
Comment has been collapsed.
It's just a matter of which feature loads first, so there isn't really a correct place. I moved some functions around in the last version, so some things in the script might be in a different order.
I'll put it back in the original order.
Comment has been collapsed.
Thanks for that. Its a small detail but when something feels wrong it just does :)
Comment has been collapsed.
Cannot reproduce. Did you try refreshing the page?
Comment has been collapsed.
The exclusion problem I can reproduce. Can you paste this in the debug menu and let me know what the output is?
console.log(esgst.settings.ail);
console.log(esgst.settings.vai);Comment has been collapsed.
Are you sure VAI not working is not your include/exclude settings?
Comment has been collapsed.
I am just bumping it so that you could test the Quick Inbox View in case you need it.
Comment has been collapsed.
I don't know if it's a bug or if I missed something in the settings or something but the script now completely overrides the "enter" button on giveways when I don't have enough points left (as seen here) and even overrides itself with hidden games and the entry disabler (as seen here)
Comment has been collapsed.
It's intended. The button turns back to green when you have enough points. It's been like that for a long time.
Comment has been collapsed.
Ah I see, fair enough. It's just so rare that I don't have any points to spare, I probably didn't even notice :p
Comment has been collapsed.
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.