Hi, I just found this enormous train. Well, I believe the filters work well there but it takes them really a very long time since the train has several hundreds wagons and the filters don't start apply until the categories are applied and the categories don't start apply until all the wagons are loaded. Try to set some filters (I tried wishlisted games only) and extract the train. Maybe you will find a way how to filter these enormous trains faster. Maybe you could separate them to parts or so. I think this is a good chance to try it since enormous trains like this aren't here so often.
Comment has been collapsed.
That would actually make it slower to load the train, the way the script is currently structured. It's better to load everything first and then load the categories/apply the filters. I'm pretty sure you've noticed how Giveaways Encrypter/Decrypter is a bit slow, because it loads in parts, but since it loads just 5 giveaways, it's not that noticeable. Just open the extractor and leave the tab for a few minutes, then come back. Pretty sure waiting a bit isn't the end of the world and it's still faster than going through all wagons manually.
Comment has been collapsed.
Actually just changed it to load 50 giveaways per time, hope that's better.
Comment has been collapsed.
Yes it is much better. I am just not sure if people will understand that they have to click again to the button called extract to load another batch of the wagons. If they don't know how many wagons there are, they cannot know that they have to click there. There would be better button Extract more.
Comment has been collapsed.
I don't think this is relevant. I'll add something to the description of the feature in the settings menu about the batches, but "Extract" can mean both start extracting and continue to extract. If the button is there then there is obviously more things to extract, otherwise it wouldn't make any sense to keep it, which is why the button is also removed when the extraction ends.
Comment has been collapsed.
But people really cannot know if the button extract will extract the whole train again or there are some other wagons and it will extract them. The button is always there, that's why they cannot know it. Description cannot help it.
Comment has been collapsed.
Yes, they can. Like I said, the button is removed when the extraction process is complete, so if the button is still there it can only mean that there are more giveaways to extract. Description can help it.
Comment has been collapsed.
the filter on extractor doesn't do anything for super massive trains. (where it's needed the most)
Comment has been collapsed.
oops, forgot the console error logs....
https://pastebin.com/CemNXX4e
Comment has been collapsed.
Did you wait until all giveaways are loaded? Filters only kick in when everything has been loaded.
Comment has been collapsed.
yes, and a good 10minutes after they loaded even also. (in case it was just slow)
there were errors, i had just forgot to post though. ;)
(it's a reply to myself)
Comment has been collapsed.
It's related to that "Access Denied" error, I think I'll have to add a request limit to Game Categories, it might be Steam blocking requests if a lot of them are made in a short period of time.
Comment has been collapsed.
You're right. After i went through this train (>300 GAs) with the extractor, the filters weren't applied.
Right afterwards i also couldn't access the Steam Store from my browser for some minutes.
Comment has been collapsed.
I can confirm; I tried to filter that train just on Owned and I was blocked from the Steam store as well.
BTW, when it comes to owned status I just use this to get a JSON of owned apps: http://store.steampowered.com/dynamicstore/userdata/
Comment has been collapsed.
I'm also having the same problems with this train.
Maybe the option to manually limit the number of GA's loaded at the beginning would help.
Say the extractor loads 50 GA's, which you then check, and after continue with the next 50 and so on. So in case of access denied errors you wouldn't have to start from the beginning and the load times for the filters to work wouldn't be as big either for each batch.
Comment has been collapsed.
Nice idea, that's what I did. I didn't add it as a manual option, but made it the default behavior though.
Comment has been collapsed.
Well since it was error prone for me and the loadtimes were pretty high without limit, you won't here any complaint from me about it being not an option :)
Comment has been collapsed.
why do i even have the api key if it never uses it? i don't enable categories that should be touching the steam store login. i use "owned" which could go off of api or steamgifts.com synced data, "wishlist" which should go off of synced data, and "bundled" which does go off of synced data. this exact issue is why i prefer steam api method 9 outta 10 times.
Comment has been collapsed.
It does use it. The problem is the script was always getting categories even if only one/all between Hidden, Bundled, Owned, Wishlisted and Ignored were enabled. These categories are retrieved from API when syncing. But the latest version should check if these are the only categories enabled and not retrieve the store data if so. Try loading a new page and see if it's working.
Comment has been collapsed.
ahh okay.. i was wondering why you kept asking about steam stores data, then i remembered there was categories i don't use. =)
that makes sense, and yes it works now mostly. i say mostly cause it does have one "owned" that should be filtered (all is synced / it has the bundle tagging), but it's just 1 out of the 50 with 39 filtered..
tbh, i'm not a fan of the "load 50" at a time, nor the fact that the tab has to be active in order for it to function. i really would luv to just click start, switch to a diff discussion while it all loads up, then go back to it once it loaded.
Comment has been collapsed.
Just one? Other Owned are filtered fine?
Yeah, since you don't have any category that needs to be retrieved from the store enabled, I guess I can make the feature behave differently in that scenario and just load everything. But it should work if the tab is not active, as far as I'm aware. I think Chrome limits stuff if the tab is not active, so it would probably load slower, but I don't think it completely stops loading, I'll check that out later.
Comment has been collapsed.
yes, i just wasn't paying much attention. it's a common issue one that i can even still join. "RFLEX + Soundtrack Pack" lol. so no biggie really, it has the tag there showing me i own it, so i know better.
that would be amazing if it's not to much trouble. i think it would load a lot of pages much faster, or at least the features from esgst on the pages load faster. i think tabs do work in the BG, but you're right, chrome limits it down to a trickle speed actually. not a full halt.
Comment has been collapsed.
The extractor should now extract all giveaways in a single batch if you don't have any of the categories mentioned in the changelog enabled.
Comment has been collapsed.
i actually may of spoke to soon. it doesn't seem to be filtering the second batch of 50 giveaways at all. it filtered the first 50 batch, i clicked load next, and waited for it to fully load, it tagged them, and then....... nothing.. no filter was applied at the end.
(no console errors)
Comment has been collapsed.
to be more precise.. i tried a second time, the second time it filtered all of them properly on the first 50 (40 filtered), then loaded the next 50 and filtered 17 more of those (57 filtered), but left ~24 of them that should of been filtered. still no errors on the second attempt either.
Comment has been collapsed.
also.. can you make it so that "Loading xyz Giveaways..." (loading status) is on the fixed location at the bottom rather then the scrolling location?
(above the manage/close buttons where they are, but the fixed portion instead)
edit: sorry i haven't been doing github lately.. i haven't been doing much of anything lately besides gaming. :D
edit 2: ROLMAO..... attempt #3 worked just fine on the first 150x (and counting).... =)
edit3: attempt #3 got all the way thru it successfully for some reason while the first two attempts on the same version of the script failed. ^^
(311 out of 387 filtered)
Comment has been collapsed.
Both the filters and the button now stay fixed.
That's really odd, but if you can't replicate it I don't know why it happened. Let me know if it happens again.
Comment has been collapsed.
thanks, idk why it was 3rd time charm thing, but it seems flawless now with the latest update on the train extractor. only issue now is the same one Espo was having on the main page. ;)
Comment has been collapsed.
Slight bug I found - even if there is no endless scrolling on list pages because lists are not selected under endless scrolling, pagination will move to the top on list pages (Checked on the entered giveaways list) if endless scrolling is selected, even if no subcategories are chosen.
The logic needs to be switched to check for activated endless scrolling on the relevant page type before moving the pagination.
Comment has been collapsed.
19.11: main page (everywhere else seems fine) is broken while game categories are enabled. Syncing didn't help.
Comment has been collapsed.
+1, just not quite as broken on chrome.
(unknown) TypeError: Cannot read property 'bundled' of undefined
at addGcCategory (eval at E_c (:3:221), <anonymous>:23657:48)
at addGcCategories (eval at E_c (:3:221), <anonymous>:23374:17)
at getGcGames (eval at E_c (:3:221), <anonymous>:23290:13)
at Array.eval (eval at E_c (:3:221), <anonymous>:23269:21)
at loadGameFeatures (eval at E_c (:3:221), <anonymous>:26397:34)
at Array.startGameFeatures (eval at E_c (:3:221), <anonymous>:26390:9)
at loadEsgst (eval at E_c (:3:221), <anonymous>:3452:43)
at eval (eval at E_c (:3:221), <anonymous>:417:5)
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:221), <anonymous>:27170:3)
at <anonymous>:2:398
Comment has been collapsed.
I'm not getting it, are you still? Maybe it was a specific game causing it?
Comment has been collapsed.
Importing your bundle list seems to have fixed the problem, what the heck?
Comment has been collapsed.
Are you sure? Maybe it was a certain game causing it and when you refreshed the main page the giveaway ended and the error didn't happen anymore because the game wasn't there.
Comment has been collapsed.
Could also be. The bundle list import was the only thing though i did after the update (which didn't fix the issue) and suddenly the main page was back to normal. Weird but i'm happy. ^^
Edit: lol, the issue is back... ><
Comment has been collapsed.
Will look into it, it's probably a game causing it then.
Comment has been collapsed.
idk i'm getting it 13hours later still after the new update, but haven't imported the file yet. i downloaded and was just about to, but couldn't figure out what section to import... in the import section there isn't a single "bundle" option to toggle.
edit: found the import for that, and it errors... nvm, that was a main page error still.. i was a goof, and tried import from the main page that errors, it imports fine if i do it from my profile page instead. -- the main page(s) errors on all pages tho (one thru five tested).
edit2: only known side effect of the main page error is importing issues (clearly), and the advanced search comes pre-expanded. otherwise it doesn't seem to effect anything else noticeable.
(unknown) TypeError: Cannot read property 'bundled' of undefined
at addGcCategory (eval at E_c (:3:221), <anonymous>:23722:48)
at addGcCategories (eval at E_c (:3:221), <anonymous>:23439:13)
at getGcGames (eval at E_c (:3:221), <anonymous>:23355:13)
at Array.eval (eval at E_c (:3:221), <anonymous>:23334:21)
at loadGameFeatures (eval at E_c (:3:221), <anonymous>:26470:34)
at Array.startGameFeatures (eval at E_c (:3:221), <anonymous>:26463:9)
at loadEsgst (eval at E_c (:3:221), <anonymous>:3454:43)
at eval (eval at E_c (:3:221), <anonymous>:417:5)
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:221), <anonymous>:27243:3)
at <anonymous>:2:398Comment has been collapsed.
The import has an error? Or are you just repeating the other error?
Comment has been collapsed.
sorry, i was a goof and tried to import from the main page that already had the error. the import is fine if i do it from a fully functional error-free page though. it's just the main page error issue i'm having now. (still after a successful import)
Comment has been collapsed.
the error is certainly tied into the "Games Categories" part of the script though. turning off that feature temporarily, gets rid of the error.
edit: turning the feature back on and then disabling the "bundled" portion makes it error on "owned" instead.....
TypeError: Cannot read property 'owned' of undefined
at addGcCategory (eval at E_c (:3:221), <anonymous>:23722:48)
at addGcCategories (eval at E_c (:3:221), <anonymous>:23439:13)
at getGcGames (eval at E_c (:3:221), <anonymous>:23355:13)
at Array.eval (eval at E_c (:3:221), <anonymous>:23334:21)
at loadGameFeatures (eval at E_c (:3:221), <anonymous>:26470:34)
at Array.startGameFeatures (eval at E_c (:3:221), <anonymous>:26463:9)
at loadEsgst (eval at E_c (:3:221), <anonymous>:3454:43)
at eval (eval at E_c (:3:221), <anonymous>:417:5)
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:221), <anonymous>:27243:3)
at <anonymous>:2:398edit2: same for owned & bundled disabled, it errors on wishlisted...
TypeError: Cannot read property 'wishlisted' of undefined
at addGcCategory (eval at E_c (:3:221), <anonymous>:23722:48)
at addGcCategories (eval at E_c (:3:221), <anonymous>:23439:13)
at getGcGames (eval at E_c (:3:221), <anonymous>:23355:13)
at Array.eval (eval at E_c (:3:221), <anonymous>:23334:21)
at loadGameFeatures (eval at E_c (:3:221), <anonymous>:26470:34)
at Array.startGameFeatures (eval at E_c (:3:221), <anonymous>:26463:9)
at loadEsgst (eval at E_c (:3:221), <anonymous>:3454:43)
at eval (eval at E_c (:3:221), <anonymous>:417:5)
at Window.tms_b08b5eca_9bc9_4dfa_920d_ddaa37ae358e (eval at E_c (:3:221), <anonymous>:27243:3)
at <anonymous>:2:398(and ofc disabling all the sections of "categories" gets rid of the error)
Comment has been collapsed.
Should be fixed. It probably didn't affect me because I have all categories enabled.
Comment has been collapsed.
is indeed, thanks a bunch. ^^
it looks too cluttered with all of them enabled to me. i just go with the minimum i want/need instead. =)
Comment has been collapsed.
Yeah, it's a bit cluttered (although I'd say not that much with simplified version enabled), but I personally like seeing that information and it's nice to filter giveaways by them. :P
Comment has been collapsed.
the performance was just enhanced by at least 3 times over with this latest patch... that kinda tells me you may be able to find the memory/cpu issues contained within one of the features of the games categories that i do not use.
Comment has been collapsed.
It's probably just the extra memory used for the categories and all the requests that it needs to make to the Steam store if one of those categories are enabled. I don't think I can optimize it to have the same memory usage as users that only have the API categories enabled.
Comment has been collapsed.
possibly. but i went from ~10gb ram usage average down to ~1.5gb ram usage average. ^^
rather significant difference.
Comment has been collapsed.
That's a lot, I wasn't aware it was still consuming that much. I'm currently trying to see if I can provide a category database from Google Sheets, so that the requests to the Steam store are only made from me, and then I can keep it updated on a week-by-week basis (I don't know how often new games are added to Steam).
Comment has been collapsed.
tbh it seems rather random. today i'm upto ~7gb usage again after only reading my messages, activating my wins, & replying here and now. all that from a freshly booted up pc. i haven't even had a chance to go thru discussions or giveaways yet.
Comment has been collapsed.
Ah, ok, 'cause I really don't see how it would have reduced that much from simply the change I did.
This thread is quite heavy, it takes a few seconds for the script to load when I open it. I think all threads with a lot of comments in a single page are like that, I'm not sure.
Comment has been collapsed.
Did you sync through the settings menu? And were you logged in on Steam while syncing?
Comment has been collapsed.
You need to be logged in to the browser when syncing for it to pick up your wishlist.
Comment has been collapsed.
Do you see anything here: http://store.steampowered.com/dynamicstore/userdata It might take a while after logging in to refresh. Try doing a hard refresh on that page if you see nothing (Ctrl + F5).
Comment has been collapsed.
It's most likely the Firefox/Greasemonkey issue then.
Comment has been collapsed.
Which makes me believe it's related to the store sync, but you said visiting the page I linked had everything there, so I don't know what's going on here. Do you have a Steam API key set?
Comment has been collapsed.
I detected the issue, and it's related to using the extractor from the discussion page, but it's a bit complicated to fix it, so extract from the first wagon like before in the meantime.
Comment has been collapsed.
Hey, I just found your script and it's great, really good work, I replaced most of my old scripts with just this one.
However, I have problems with Level Progress Visualizer. It just won't work, always stays gray.
Errors from console:
(index):113 GET https://cdn.steamgifts.com/js/prebid_v3.js net::ERR_BLOCKED_BY_CLIENT
6(index):1 Mixed Content: The page at 'https://www.steamgifts.com/' was loaded over HTTPS, but requested an insecure image 'http://cdn.akamai.steamstatic.com/steamcommunity/public/images/avatars/b0/b011c560c691daaf323f73929cf75ba777fbd47b.jpg'. This request has been blocked; the content must be served over HTTPS.Comment has been collapsed.
Hello, can you add gridview to Decrypted Giveaways window?
Comment has been collapsed.
Endless scrolling cannot work correctly.
Comment has been collapsed.
Check for console errors, script conflicts, etc...
Comment has been collapsed.
I haven't active another script.
Don't know how to check console...
Comment has been collapsed.
Actually, I don't know which tab of info you want.
Comment has been collapsed.
Should be the second tab, it should be written "Console", I don't understand that language. If you're using Firefox, you might have to open Ctrl + Shift + J instead.
Comment has been collapsed.
just fyi, it seems "ctrl+shift+J" works on chrome also. it maybe the better "goto" to tell people. ^^
Comment has been collapsed.
I got the root cause, when I using the setting "Active Discussions On Top/Sidebar " to siderbar, this issue will happen.
When I change to top, this issue will gone.
It seems some of setting are conflict.
Comment has been collapsed.
Idea:
Since one can sync the bundle list now via file, how about a function that gets the bundle list on a daily basis and people could download this file directly into ESGST instead of syncing with SG's server. Advantage would be that one could update his bundle list everyday while SG will not be hammered with requests.
Comment has been collapsed.
I have an idea to use a Google Sheet to sync from SG and then the script syncs from that sheet. Pretty much the way it currently does for Username History. But I don't know about syncing daily, I have a feeling bundles aren't added that frequently.
Comment has been collapsed.
Basicly the same i was thinking about. You can't tell exactly when the list gets updated since it's done manually by a single user but i don't see the harm by a daily one-time request of the list. I think all ESGST users together are causing more bandwith right now for SG even with the weekly restriction.
Comment has been collapsed.
the problem i think you'll run into with a google sheet is bandwidth. if i'm not mistaking ruphine had tried that on her script at first and it failed after only 1-2days from the sheer amount of traffic. she ended up having to get an actual service to host it on instead.
Comment has been collapsed.
Nope, the way I'm thinking of it, it would be impossible to exceed Google's limit. It would request to Google only once per week and store the data in your storage, so it wouldn't request to Google on every page you load. The data would still be in your storage, but retrieved from the Google sheet instead of you syncing it manually.
Comment has been collapsed.
it seems that the "hidden" game category category filter isn't working in the decrypted giveaway popup, will test on other places to see if it works somewhere else
Comment has been collapsed.
it wasn't syncing correctly probably, it's working now, if i do get this error again will check the console and report back
Comment has been collapsed.
If the "Hidden" tag appears but the game isn't filtered it's most likely a bug, but if the "Hidden" tag doesn't even appear, then it's a sync issue, yes.
Comment has been collapsed.
it isn't filtering all the games with the hidden tag on the train extractor, tested on the gigantic train linked by pilda, it also isn't loading the hide giveaway button on the giveaways that were not hidden previously
Comment has been collapsed.
Are the errors in the console? The "not loading the hide giveaway button" part isn't a bug, the script just currently is unable to add that button. I'll look into that some other time.
Comment has been collapsed.
only this error:
TypeError: tge.set is null ESGST.user.js:11305:13and a bunch of mixed content ones
FF+GM
Comment has been collapsed.
am I the only one for whom Tampermonkey crashes every 5 min?
Back to Superfox ─=≡Σ((( つ＞＜)つ
Comment has been collapsed.
Never crashed for me, and I have every single feature enabled. Guess it depends on how many tabs you have open.
Comment has been collapsed.
Nothing happens. Also tried 5, and 8, and 10, and 12. No crashes. It becomes very slow for sure, which is why I never open more than 5 SG tabs at the same time with this script (also because I don't need to), but 0 crashes. Also, opening too many tabs with this script enabled is kind of asking for a crash, to be honest, because like I mentioned, the script is very heavy, especially if you're performing activities in one of the tabs.
Comment has been collapsed.
strange, try to go on a group or user page that scans for contained groups.
Others reported crashes before too though.
asking for a crash
no, never. From the technical standpoint the script host should never crash. It must not allow that to be possible, otherwise it is at fault for it, always.
Also I have many tabs open in FFGM and it never failed with exactly the same feature-set active. (And I'm using only half the stuff available.)
Just tried some forum pages, 5 out of 5 times the Comment Tracker is working on FFGM. ;-) May rather be a conflict with an option that I don't use I guess.
Comment has been collapsed.
I told you, TM has never crashed for me, and I've used SG intensively before, performing checks in one tab while navigating through others, loading multiple giveaway pages (which are very heavy if Game Categories and Giveaway Groups Loader are enabled), etc... It gets very slow because of the high memory usage, but no crashes.
Odd, last week Comment Tracker rarely loaded on GM and there was always a bunch of random errors in the console. But it appears to be working now. Although I have a feeling not for long.
It always crashes for you exactly after 5 minutes on TM?
Comment has been collapsed.
No, not exactly but at most. Yes I use several tabs. My Chrome,Op installs are basic with hardly anything in it.
But there are 5 others here reporting about TM crashes.
Comment has been collapsed.
I'm not debating whether or not the crashes are valid. I noticed a better performance on GM as well (although I didn't give it much importance because of the errors I was getting and the lack of some features when loading the pages 99% of the time). I was just telling you it never crashed to me.
Comment has been collapsed.
Actually, now that I think about it, the reason why the script might run better on Greasemonkey is because it's not completely compatible, so some features might not load, leading then to the better performance. When I tried Firefox, Comment Tracker would only load a few times, for example, and that feature is quite resource consuming.
Comment has been collapsed.
Never had an issue with Comment Tracker on FF.
We have to face the truth, Chrome/Tampermonkey are simply shit ;-)
It shouldn't be possible to crash it at all through a script, but quite a remarkable feat nonetheless ^^
Comment has been collapsed.
9 out of 10 times I load a page on Firefox, Comment Tracker is nowhere to be seen.
We have to face the truth, each person will have a different experience with each browser/extension. Firefox/Greasemonkey is a huge pile of shit to me. :)
And this script is very heavy and far from optimized for better performance, so I wouldn't jump to immediately blaming the browser. xD
Comment has been collapsed.
this script is very heavy and far from optimized for better performance
nah it's not about performance, crashing should never happen and is a clear fault in TM.
Btw. vanilla FF is indeed junk, try Cyberfox, plus a few essential extensions and it's way better than anything since Opera v12.
Comment has been collapsed.
Have you ever tried Violentmonkey? I still think some of the fault lies with the script, it just eats a lot of memory.
Nah, I'm good with Chrome. It does everything I need perfectly and I don't have any reason to leave it. xD
Comment has been collapsed.
Script broke on VM on Opera long ago, so no. Switched to chrome for the test install because there is at least a popup displays to restart TM.
Are you using mouse gestures?
Also you made Time/Level invisible in gridview on last update for the dark theme. Do you hate Squished or me that much xD
Comment has been collapsed.
I meant Violentmonkey for Chrome. What exactly broke?
I didn't make anything invisible. I don't hate anyone, but I also don't implement the script thinking about themes either. If I have to do something that will break the themes I'll do it. xD
Comment has been collapsed.
Don't remember anymore. But tried and crashed directly on 2nd tab opened rofl xD
I have a lot of user scan data, only thing I can think of. Any way to delete all nornal ones without any from wl/bl?
Also users arent listed on CVM at all there o_O
But what did you (have to) change that makes Time/Level invisible then? ^^
Comment has been collapsed.
Ah, that could be it, I don't have a large data. Yep, the settings menu has offered individual data management for quite a while now.
Had to do some changes to Grid View to add new options to enable it for other places. There are going to be a lot more style changes in the future (some very soon), so expect themes to break a lot more. ^^
Comment has been collapsed.
the settings menu has offered individual data management for quite a while now.
how,where? I don't see a way to delete or at least not a clear naming for that specific part.
expect themes to break a lot more.
so you do hate me xD
I just want to use the site for a few days without interruptions (ಥ﹏ಥ)
Comment has been collapsed.
lol, then don't auto update. Just wait till the theme is caught up then manually update script 😉
Comment has been collapsed.
Settings menu, the option to import/export/delete. You can select the specific data you want to delete.
I didn't even know you used themes. xD I just want to improve the script, and for that, changes need to happen. ^^
Comment has been collapsed.
I didn't even know you used themes.
only the dark one, all white default burns my eyes xD
for that, changes need to happen. ^^
sure, but it seems at least a few breakings can be avoided ^^
Comment has been collapsed.
The Grid View change could not have been avoided or it would have made the icons invisible in the default theme instead. Some of the ones coming could be avoided, yes, but I don't want to avoid them. :P There's too much inconsistency in the script and I'm slowly making things consistent. That includes setting a pattern for class names and cloning SG classes. Class name changing breaks stuff no matter what, and I won't keep using old class names from when the script was still rhSGST just because of themes. xD
Comment has been collapsed.
icons invisible in the default theme instead
I can't even images how,why it ends forcefully breaking either one or the other but not both xD
cloning SG classes.
that in fact would improve things ;-) button&menu on top for example needlesly uses separate non-sg classes which makes extra theming only necessary.
But here take a look, surely that's not intended ^^
Comment has been collapsed.
It would break both, just not equally. Before, the time container was always the first element, so I didn't add a class to it because I could do .esgst-gv-icons:first-child. But with the extension of Grid View to other places, the time container might not always be the first element. It can now be "Source" if using it on Giveaways Encrypter/Decrypter. So I had to name the time container to make sure I was styling the correct element. If I added the extensions without adding a class to the container, the dark theme would have the time invisible in Giveaways Encrypter/Decrypter and the default theme would have the time invisible in the main page.
I don't think I understand your second sentence.
Yeah, that's not intended, but c'mon, you said the icons were invisible, not side-by-side with the image. :P I'll look into it.
Comment has been collapsed.
Giving class names seems not the issue, but the order stuff you mentioned.
Btw. my own dark theme never broke in that regared, only Squished his xD (must mean you don't hate me after-all phew ^^ )
I don't think I understand your second sentence.
using
esgst-header-menu-button
esgst-header-menu-rowinstead of
nav__button-container
nav__rowyou said the icons were invisible, not side-by-side with the image.
both ^^
putting the icons after the image like Squished suggested fixed it.
seems so yep
Comment has been collapsed.
True, but to style things correctly you now need the class names. I didn't even know you had your own dark theme. xD
Yes, I know, but I didn't understand the sentence. It felt like you were saying that cloning SG classes was a good thing, but then what you said after that seems to have contradicted that.
Nope, I remember very clearly you never said the icons were side-by-side with the image. :P
Comment has been collapsed.
didn't even know had your own dark theme
based on a 2year old fork from Squished when he started making his less dark. It works surprisingly resilient, I have to fix stuff way less often than with Squish's newest version.
I am thinking of publicly releasing it sometime too. ^^
cloning SG classes was a good thing
it is. If you change those classes I mentioned to sg ones then I don't need to add styling just for your button up there ;-)
Comment has been collapsed.
But what I'm doing is actually changing SG classes' names to my own while cloning their rules. The header button has already been cloned. I'm still a bit lost, don't mind me, I thought you had to add styling anyway.
Comment has been collapsed.
changing SG classes' names to my own while cloning their rules
huh? Don't really know what you mean with that or how it works.
(my js/css knowledge is limited)
But seems it always clones the default theme. Can't you use sg default class names for the button, or have like both sg&yours?
I thought you had to add styling anyway.
All sg stuff is covered already. New classes need (at least sometimes)
Comment has been collapsed.
What I'm doing is, for example, changing
nav__button-container
nav__rowto
esgst-header-menu-button
esgst-header-menu-rowbecause
- It prevents conflicts between SG's script and mine. The classes from the header menus have an event listener attached to them by SG's script, so if I inject my button with the same class, it doesn't function properly (which is why some users were unable to open the button, when they clicked on it nothing happened). By inserting the button with my own class, but with the same rules from SG's classes, the button looks exactly like the other buttons and I can manipulate it without being interfered by SG's script.
- It reduces clutter on the HTML/CSS injected by my script.
- I can use the same class for SG and ST, without having to differentiate between
.page__heading(SG) and.page_heading(ST), for example. I can just use my cloned class.esgst-page-heading.
But seems it always clones the default theme. Can't you use sg default class names for the button, or have like both sg&yours?
No, because of the reasons explained above.
Soon no element injected by my script will have the same class name as SG. It will be the same class visually, but under a different name. You might have noticed there isn't a single .popup in the script anymore, but a .esgst-popup now. I'll remove all the other .popup__icon, .popup__actions, etc... and add cloned classes .esgst-popup-icon, .esgst-popup-actions, etc...
Comment has been collapsed.
hm makes sense.
Though the cloning seems not able to pick up custom themes sadly.
Comment has been collapsed.
Yeah, it doesn't. I "clone" the classes manually, as in, I copy the style from SG's .css file and paste it in my script. They're not automatically cloned during execution.
But the good news is this doesn't change anything for you guys, really. All you have to do is replace the old class I used with the new. Or add a new class to the style you already have.
Comment has been collapsed.
All you have to do is replace the old class I used with the new.
That is the actual work ^^ for me who doesn't have a clue what I'm doing that can be troublesome xD
Comment has been collapsed.
It's not that complicated. You just need to check the script's commits on GitHub and see what classes changed from one file to the other and then replace them. xD
Comment has been collapsed.
I'm not getting that in the latest. Maybe putting the icons after the image like Squished suggested fixed it.
Comment has been collapsed.
Deleted wl,bl data. Keeps crashing. I give up on C/O even for testing now.
Comment has been collapsed.
Does C/O mean Chrome? I'm not familiar with any of these initials you use. :P Well, I don't know what to tell ya, it might be TM then. Weird that it never crashes for me, though. And I think if it was crashing for more people they would probably have reported it (you mentioned there were only 5).
Comment has been collapsed.
C - Chrome, O - Opera, GM;TM;VM - all the monkeys ;-)
there were only 5
I simply searched the thread for 'crashes'
Possibly caused by only 1 feature, or more people use FF ¯\_(ツ)_/¯
Comment has been collapsed.
Ah, I see. Yeah, I'm familiar with the monkeys, I was just a bit confused when you used it together with the browse, like CVM. :P
I think some of the crashes reported in this thread are not happening anymore, as they were related to something else that was already fixed.
If it was caused by 1 feature I would probably be affected by it, as I have everything enabled, unless it's caused by a lack of a feature. But I fail to see how it's related to a feature if the same doesn't happen on Firefox. Unless... have you tried with Tampermonkey for Firefox?
Comment has been collapsed.
you tried with Tampermonkey for Firefox?
oh god no, I won't touch that junk xD
need to update my main install now due to cg screwing up the site layout (again -.- ) with the poll at the top
and need to get you to fix newly broken stuff in the script first :P
Comment has been collapsed.
Well, there's your answer. :P
cg didn't move the poll to the top though. It's just like it was before.
What newly broken stuff?
Comment has been collapsed.
cg didn't move the poll to the top though
of-course I know ;-) but the disc.-to-top option does that, hence the need to update, but.. just because the useless poll got added
(and the new disc.preview design is shit too, but hard to get back to previous >.> )
What newly broken stuff?
noticed strangeness with the wl checker,
when having 'show bl..' disabled then it doesn't correctly detect wl's at all
but actually I don't use that option, only noticed that on the test install w/o knowing about that being not selected
Comment has been collapsed.
Odd, that option should have no impact on the check.
Comment has been collapsed.
The 'check for wl' option vanishes, it may take it as disabled thus not checking anything.
On another note: one custom change I have is for the enter button to always enter also when there is a description (like it did long ago initially). Intended to put that up on github, but need to find a username first xD and also code the leave button inside the popup too ^^
Comment has been collapsed.
Oh, nice catch. Yeah, if it doesn't appear and you had never enabled it before, its default value is disabled so it won't check anything. Major flaw in the logic, thanks for spotting it. :) Can't believe no one else noticed it before. I guess not many people disable that option.
Looks like none of the changes I made to the Enter/Leave Giveaway Button mattered. They're all being requested back. :P Will change it later.
Comment has been collapsed.
Having to click enter twice is less comfortable (and afair never requested) and may have contributed to lower acceptance of the popup appearing. But I won't argue about that anymore.
Having the leave button inside is useful though.
Comment has been collapsed.
You still click twice no matter what because you have to close the popup, all that changes is where you click. And I know it wasn't requested, but that was the best way to do it for me because it did everything in a single request. Entering first and then opening the popup could lead to 2 requests if the user decides to leave a comment or leave the giveaway. But one extra request doesn't sound too bad, and I don't think it would happen often, so I'll change it back, you're not the first person to complain about it anyway.
Comment has been collapsed.
all that changes is where you click.
yes but that is a big difference having to click another small button or just anywhere on the screen. 2nd is way more relaxed.
could lead to 2 requests if the user decides to leave a comment or leave the giveaway.
For me that happens at maybe 1 out of 15 times, so it's not too worrisome. Can also be improved by having the comment box hidden first and expandable on demand.
not the first person to complain about it anyway.
not complaining, contributing :P
Put line 8083 after 8035, fixed ^^
-
Ah right, another thing I have added is opening GA/User from the desc.popup in new tabs with
popup = createPopup_v6(`fa-file-text-o`, `<a href="${giveaway.url}" target="_blank"> <span>${giveaway.name}</span> </a> by <a href="/user/${giveaway.creator}" target="_blank" >${giveaway.creator} </a>`, true);Comment has been collapsed.
Can also be improved by having the comment box hidden first and expandable on demand.
That wouldn't change anything.
Not sure what lines you're referencing there because I have a different version than yours, but if you're talking about the suggestion you made, I already changed it, and I don't think a simple line change would do anything. I had to rewrite the entire function. :P
Some people don't like things opening in new tabs, so I'm not adding that. Easier to mouse click it.
Comment has been collapsed.
That wouldn't change anything.
? would save opening the ga.
I don't think a simple line change would do anything
it does for the entering part, was all that was needed for me to have it working ^^
(haven't done the leave button yet)
Comment has been collapsed.
How? Comment box has nothing to do with opening the giveaway, it makes a POST request to SG. Description opens the giveaway.
Well, I don't think it would work for all cases. I changed it in the latest update and added the leave button as well.
Comment has been collapsed.
Comment box has nothing to do with opening the giveaway
It was about saving another intermediate request of having to open the giveaway after seeing the description popup.
added the leave button as well.
👍
Comment has been collapsed.
Doesn't change anything. The box being there from the beginning doesn't add another request. Only if you type something in it and press the button.
Comment has been collapsed.
I mean: desc. pops up, user decides to comment, needs to open full ga, writes comment
step3 can be saved
Comment has been collapsed.
Ah, I thought you were talking about something completely different. Why not just enable the option to show the comment box?
Comment has been collapsed.
Any way to clear checked users without checking them?
Comment has been collapsed.
which option is meant for that, the ? only show 'undefined' for user stuff
but still: Any way to delete all nornal checked users without any that wl/bl'ed? Seems not possible -> feature request ;-)
Comment has been collapsed.
The first 8 options are all user data. If you want to delete all user data except for Whitelist/Blacklist Checker data, just select all except that one.
Ah, you weren't very specific. Yeah, that's not possible, but it was already requested, and I'll work on it one day.
Comment has been collapsed.
+1
that's what i'm looking for also.. till then i too have a really large data file and it crashes rather frequently here also. not quite as bad as it is for you by the sounds of it, but still rather annoying and hard to avoid.
Comment has been collapsed.
I cleared that completely to test, but crashes remained.
Comment has been collapsed.
Ah, wasn't aware it was still crashing for you. I don't think it would change anything though, since Tristar deleted their data and nothing changed. It's probably just the script itself consuming too much memory and Tampermonkey not handling that like Greasemonkey and letting the script eat as much as it wants. Have you ever tested it on Firefox?
Comment has been collapsed.
tbh it's extremely random on both the crashes and the memory/cpu usage.
another annoying thing the script does is locks up other websites from opening up a dialog box. i am not allowed to have chrome opened up with a steamgifts.com tab at all and upload an image to imgur via their file selection dialog box. it just never loads. i have to exit out of chrome, allow the process to quit, then open up a fresh browser and upload the image before i even touch steamgifts.com.
Comment has been collapsed.
That's odd, I can upload images just fine with the script open (currently using 2 tabs). Wonder why none of these things happening to you guys happen to me. It can't be storage size, if Tristar deleted theirs and nothing changed. Or maybe it's the number of tabs, like I thought initially.
Comment has been collapsed.
i can have the number of SG tabs at 0 and it still won't let me upload if i have recently had a SG tab open. it takes the script 5mins+ to actually finish executing/writing (idk) before i can return to normal browser usage.
Comment has been collapsed.
I really, really want to thank for "Train Giveaways Extractor". IT'S AMAIZING!!!
Comment has been collapsed.
Can we get the gridview icons div after the image ;)
Comment has been collapsed.
Derp i knew i should have waited, i just got done correcting the other way lol.
Comment has been collapsed.
you forgot your popup gridview margin 😉 but yeah this should work much better now that it is in the natural order.
Comment has been collapsed.
Ah, yeah, they should be the same margin now that it comes after the image, so I'll remove that rule.
Comment has been collapsed.
Great addon! thanks!
Issue report: fail to extract train content from page: https://www.steamgifts.com/discussion/J2jSI/
Not extracted from the discussion page, of course.
Comment has been collapsed.
Yeah, there is currently a bug with giveaways that have not started yet, will see if I can fix it in the next couple hours.
Comment has been collapsed.
Decrypted giveaway gridview bug on user profile page
Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
at setGvContainer (eval at E_c (:3:221), <anonymous>:7664:17)
at Array.setGvContainers (eval at E_c (:3:221), <anonymous>:7572:17)
at Array.loadGiveawayFeatures (eval at E_c (:3:221), <anonymous>:25910:38)
at loadEndlessFeatures (eval at E_c (:3:221), <anonymous>:27031:37)
at eval (eval at E_c (:3:221), <anonymous>:8652:29)
at Function.onload (eval at E_c (:3:221), <anonymous>:4863:17)
at <anonymous>:2:398
at eval (eval at exec_fn (:1:108), <anonymous>:30:494)Comment has been collapsed.
I believe all popup features are currently bugged out in the user page. I'm aware of it, but not really my priority right now, it's a bit complex to fix it.
Comment has been collapsed.
Community poll got me thinking maybe the community voted giveaways will make a comeback, so if you want to future proof gridview icons 😉
Comment has been collapsed.
I'm actually planning on adding an option to extend Grid View to the profile pages, so that page might be a good place to test it, thanks. :)
Comment has been collapsed.
Can we have option to get back to view last discussions like it was before site feature "community poll"?
Comment has been collapsed.
There is an option in the settings to switch it from top to sidebar or off completely.
Comment has been collapsed.
Wouldn't be completely the same, since some information is missing from the new look, so no.
Comment has been collapsed.
But maybe you can add missing information, like discussion category and created time? It would be very useful, thanks.
Comment has been collapsed.
No, that would require making 5 requests every time you load the main page. If you dislike how big the new design is, try changing it to the sidebar.
Comment has been collapsed.
And there I was thinking of making such a script just to protest ;-)
Actually it needs only 1 request -> https://www.steamgifts.com/discussions ^^
Comment has been collapsed.
Ah, but of course, I'm a bit slow today. Will add it then. What would happen to Deals though? Just remove it? Or make it double-tab like on the sidebar?
Comment has been collapsed.
Only got the idea of a single request right now too, thought of 10 being needed past days ^^
I'm not sure how to design it though either, there is too little space to fit all in, esp with exact timestamps. Haven't come up with a good idea yet.
Comment has been collapsed.
Sidebar view same as on top. Both without needed information. But no problem.
Comment has been collapsed.
Doesn't seem to be the case. ESGST is loaded standalone and it's still the same problem. :/ Thanks for the quick reply though :)
Comment has been collapsed.
Thanks for the script, it's very useful.
Just one minor thing which bother me, how can we access to the list of GA someone won when we activated the "SGtools link" feature on your script? If I click on "Gift Won" on someones profile, it open the SGtools link. Accessing the original page is needed for an other script I'm using "Do You Even Play, Bro?". Don't worry i found another alternative, it was just to let you know about this, as it might also bother some other users too.
Anyway, thanks :)
EDIT : nevermind, clicking on the number and not "GA Won" work >_<"
Comment has been collapsed.
Is it possible to make a button on SteamTrades to bump all trades that you have active now? Thanks for the great extension btw :D
Comment has been collapsed.
Doesn't seem to work as planned (Even after clicking the "Bump All" button, the trades can still be bumped. (Normally, you can only bump a trade every 1 hour.)
Also, would be good to make it a labelled button instead of just a small sign (I had a hard time finding it, tbh) :P
Comment has been collapsed.
Weird, it worked for me when I tested. I'll test again in 1 hour.
I don't like adding labels to the heading buttons in this script. But once you find it, you know where it is. :P
Comment has been collapsed.
Yup it works now, thanks!
Maybe you can add in an option for auto-bump every hour? :D
Comment has been collapsed.
That would require you to leave ST open and I'm assuming that's not what you want?
Comment has been collapsed.
Honestly, I'm fine with that (I leave my CSGO Lounge trade page open so the bot can auto-bump it :D )
Is there such a function already? (Leaving the ST trade page open to auto-bump it every hour)
Comment has been collapsed.
Added the option. It works with either SG or ST open.
Comment has been collapsed.
Yup, thanks, works really well for me :D
Is it possible to edit it such that it refreshes the page whenever it successfully bumps the trade? I was very confused as to whether it could successfully bump the trades for a while :P
Comment has been collapsed.
one small thing i keep forgetting to mention....
the "mark all comments in this page as read" button needs to have the spinning "busy" identifying icon to know when everything really has been marked and stored as marked in the data. there are several times i click that, all of the comments fade out as read, but then when i refresh the /discussions page, they still show as unread because i clicked away from the page to fast not knowing it was still busy.
Comment has been collapsed.
Added an option (2.5.1) to Giveaway Filters that allows you to hide giveaways in the main page.Huh, where is the difference to SG's built-in feature? ^^
Comment has been collapsed.
This hides giveaways, not games. For example, there is a giveaway for a game you want, but you can't enter the giveaway for some reason (region restrictions or a package and you don't fit the creator's request, for example) or you just don't want to see it, you hide that giveaway.
Comment has been collapsed.
Oooh, it's for individual GAs and not all of a kind. Thanks for explaining.
Comment has been collapsed.
Bug report: option
Search for the first unread comment in reverse order is doing the opposite
Feature suggestion: User popup displaying suspensions too
and I'm amazed how you sped up sync so much, how did you do that? ^^
Comment has been collapsed.
That option was working fine for me when I last used it. Where is it getting the comment from? If from page 1, that's expected.
Feature suggestion: User popup displaying suspensions too
How? I don't think there's a way to publicly access a user's suspensions.
and I'm amazed how you sped up sync so much, how did you do that? ^^
- Removed request limit for sync, since it's not a frequent activity, so it shouldn't stress SG servers that much.
- Changed the sync to save all users at once, instead of saving each user at a time, like it was before.
Comment has been collapsed.
That option was working fine for me when I last used it
it says "from newest to oldest"
but does that when being disabled
when enabled it makes 'oldest to newest'
it's simply reversed, either description or functionality ;-)
I don't think there's a way to publicly access a user's suspensions.
um, I mean that a user is suspended and how long, it's on the profile after-all ;-)
Removed request limit for sync
ah, yes, that does the trick ^^
Comment has been collapsed.
Or maybe you're using reverse scrolling?
Ah, ok, you weren't very specific. :) Do you happen to know a suspended user so I can test that?
Comment has been collapsed.
Or maybe you're using reverse scrolling?
nope, believe me it switches around to do opposite to what it says ^^
happen to know a suspended user
wouldn't that be calling out? I don't even know anymore
maybe you want to check our vickinachi, it is a new trend in RPG games. *wink wink*
Comment has been collapsed.
Ok, I'm having a hard time believing it because I intensively tested that feature a while ago and it was working fine, but if you say so, I'll test again later. ^^
Well, I don't know either, the calling out rule is so vague, but you could have linked it to me privately. :P
Comment has been collapsed.
using reverse scrolling the option doesn't work at all, always goes to the oldest comment
but I only told you about the GOTY of all times :3
Comment has been collapsed.
it functions just fine, except inside the settings menu it should say:
"Search for the first unread comment in reverse order (from oldest page to newest page)."
it does currently state from newest to oldest, and it doesn't clarify that it only does it on a "per page" basis. ;)
@Tristar - there is one exception though. if the op is not marked as read, it will take you to the op of page1 instead of the last pages first comment.
Comment has been collapsed.
Thanks a lot for adding 2.5.1, any plans to bring this functionality also to the discussion area?
Some little bug with the feature: if you have a GA open, which you have hidden the upper area with the GA info disappears (think it might be `featuredouter-wrap featuredouter-wrap--giveaway'). Not something that should happen often but might want to fix it anyway.
I think it might also be a good idea to add an option to filter the hidden GA's, in case of hiding it accidentally etc.
And out of curiosity, do the hidden GA's have an "expiration date" ? Might be worth a consideration if not, optimization wise; no need to have GA's in the list that have ended.
Also enjoying the new default behavior of the enter pop ups with description ; 33% more efficient :D
Btw, is it normal that the decrypter can't handle GA's created by oneself?
Comment has been collapsed.
I could do that (the option to hide discussions), yes.
Thanks for the bug report.
Couldn't you then just go to the settings menu and unhide it? It's a bit complicated to add a filter to that because the giveaways are completely removed from the page, not just hidden.
Currently there's no expiration date, but I do plan on removing giveaways as they end later.
What do you mean? It's not decrypting created giveaways? Errors in console?
Comment has been collapsed.
The filtering is not a big deal so if it is too much effort, just forget i brought it up :)
Well the 3 GA's i added to my previous post don't get loaded(they are not just filtered away), the decrypter button is green and stays this way also after pressing and trying to load. No errors on console.
Nevermind that they loaded now, seems to have been the same problem the train extractor had previously, it can't handle GA's that haven't started yet
Comment has been collapsed.
Fixed the bug that was removing the heading of the giveaways and hidden giveaways now expire when they end. :)
Will look into the bug for giveaways that haven't started later.
Comment has been collapsed.
In the current version the heading disappears, when using the hide button (the standard SG one). Relaoding fixes the problem, though.
Comment has been collapsed.
unsent gift sender still fails to send games to whitelisted entries when it's a group+whitelist giveaway.
(they fail from not being inside of the group)
Comment has been collapsed.
and another small thing i realized...
https://www.steamgifts.com/messages "Mark all comments in this page as read" doesn't do anything at all. (no error either)
Comment has been collapsed.
I haven't finished rewriting it. Every time I go back to it, something comes up in this thread and I have to focus on that instead. :P Will see if I can finally go through with it tomorrow.
Comment has been collapsed.
ahh okay, it's no biggie really. i just noticed the styling on it was a little different with different buttons and toggles, so I thought it had been already. ^^
Comment has been collapsed.
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.