Probably the same thing that's happening with Discussions Highlighter for you. Same thing was happening to me when testing Firefox. 9 out of 10 times I opened a page and Comment Tracker was nowhere to be found. I don't think I can fix that, or at least I don't know how to. It seems to only happen on Firefox.
Comment has been collapsed.
It happened randomly for me. Yesterday I tried testing on Firefox again and it seemed to be working fine.
Well, yeah, since you use many tabs, unfortunately Tampermonkey is a no-go for you.
Comment has been collapsed.
Yeah, that's what I felt like. And which features don't work is completely random. If you notice the "can't convert to string" errors, every time you reload the page, they happen on a different line. And it's not even this script, I made a test script that only contained the following:
for (i = 0; i < 50; ++i) {
GM_setValue(`test`, JSON.stringify({
a: 2,
b: {
c: 3
}
});
}And this test script gave the same errors (each time you load the page it happens a different amount of times). All I know is the errors happen because of GM_setValue, but why exactly I don't know.
Comment has been collapsed.
There's nothing different about how I write it, even the test I just showed you throws the error. Do the other scripts you use have GM_setValue? And do they use that function frequently?
Comment has been collapsed.
Depends on the browser, I don't control the color of the emojis.
Comment has been collapsed.
it actually depends even more on font type that the browser uses. i can change my font type to where i have colored emojis, or black and white only. depending on "noto serif" = black n' white, or "noto sans" = color for me personally inside of linux anyways.
Comment has been collapsed.
Version v6.Beta.21.0 seems to have broken many things for me. No filters, no Enter/Leave button. no "chance to win %", etc. Any ideas how to get these back (assuming this is not caused by a bug)?
Comment has been collapsed.
OK, what do I look for?
Error in parsing value for ‘display’. Declaration dropped. minified_v23.css:1:3914
Error in parsing value for ‘-webkit-box-align’. Declaration dropped. minified_v23.css:1:12184
Error in parsing value for ‘-webkit-box-align’. Declaration dropped. minified_v23.css:1:15274
Error in parsing value for ‘-webkit-box-align’. Declaration dropped. minified_v23.css:1:21244
Unknown property ‘-moz-osx-font-smoothing’. Declaration dropped. font-awesome.min.css:4:660
Expected color but found ‘undefined’. Error in parsing value for ‘color’. Declaration dropped. www.steamgifts.com:3:7
Expected color but found ‘undefined’. Error in parsing value for ‘background-color’. Declaration dropped. www.steamgifts.com:4:18
Error in parsing value for ‘word-break’. Declaration dropped. www.steamgifts.com:1:27
Comment has been collapsed.
Not sure what I am looking for, but this line was pink and mentioned ESGST:
TypeError: context.getElementsByClassName(...)[1] is undefined[Learn More] ESGST.user.js:26394:34
Comment has been collapsed.
I did see that after doing a shift-reload of the main page, but now when i do it I don't see that error.
If I shift-reload the page with Greasemonkey enabled, and then do the same with it disabled, the front page of steamgifts looks the same (except for the ESGST button at the top), so it is like it is not working on the front page.
If I go to individual GAs I can see all the ESGTS stuff, so it is working there.
Comment has been collapsed.
I'm thinking it could be related to the new Old Active Discussions Design feature, but I tested with it disabled and got no errors. Do you have that enabled?
Comment has been collapsed.
Ah, nevermind, found it. I had Active Discussions On Top/Sidebar enabled as well so I didn't see the bug. Will fix in a few minutes.
Comment has been collapsed.
I'm affected by this also and no errors on the console related to a script only css ones like the ones posted by SpaceClick
gridview isn't working too
Comment has been collapsed.
Only on the main page? Also no errors on Ctrl + Shift + J?
Comment has been collapsed.
main page only apparently, "Old Active Discussions Design" and "Active Discussions On Top/Sidebar" disabled, TM or GM on FF, no difference
Comment has been collapsed.
TypeError: context.getElementsByClassName(...)[1] is undefined ESGST.user.js:26394:34when using endless scrolling on any discussion, comment tracker only working on the first page to load
Comment has been collapsed.
this gap makes the giveaway hover info disappear if the mouse is not moved fast enough
Comment has been collapsed.
chrome 60 audit with ESGST (performance 9), then without ESGST (performance 61) >>
Comment has been collapsed.
How do you do that? If I run an audit I don't get the circles at the top with that information below them.
Comment has been collapsed.
it's new the the chrome 60 that rolled out yesterday, idk if you're updated to it yet or not. it's inside the console though, i had to open up the >> and select "audits" :D
Comment has been collapsed.
yeah, i kinda figured i'd be one of the first ones to get it being in linux. ^^
Comment has been collapsed.
First I got 0 performance with ESGST enabled, then disabled it and got 78 performance, then enabled it again and got 69 performance. The performance count seems to be related simply to how long it takes the page to load.
Comment has been collapsed.
yeah, that's what i gathered too. it isn't really a reliable way to audit.
Comment has been collapsed.
Just finished rewritting Unsent Gifts Sender. Tested it a lot, but I could still have missed some bug, let me know if it's working fine. :)
Comment has been collapsed.
excellent. i got a batch of them ending in a few hours i'll use it on. ^^
(unfortunately not a whitelist mixed in GA though, but in time i'll test that too)
thanks again =)
Comment has been collapsed.
Ok, also let me know about the Inbox Winners Highlighter bug. :)
Comment has been collapsed.
well... i did just run across one winner that's comment is not being highlighted. so i guess not perfect.. but it's occurring far less frequently at least.
(sent via the unsent gift sender)
Comment has been collapsed.
Do you remember what settings you had enabled when you send the gifts to that winner?
Comment has been collapsed.
yes, i almost always use these settings as the default. (except with one specific group, i'll start to use the group difference checker)
Comment has been collapsed.
Ok, I'll check the code again, I thought I had implemented it perfectly. :/
Comment has been collapsed.
sounds good.. just thought of a feature enhancement or kinda a side feature. not sure it could be considered an enhancement since it would be on a separate page then the feature it would enhance. but..
"ignore this users infractions prior to this date" (for the unsent sender purposes) -- it would be good for those few users who have old infractions that i'm in group/groups with, they get a pass if their only rulebreak(s) are prior to me toggling that on, on their profile page. similar to the way the whitelist toggle option gets a free pass, but it would be on a per chosen user basis.
Comment has been collapsed.
+1 to marlop's report. You add a
margin-top: 2px;to
giveaway__summary esgst-gv-popout global__image-outer-wrapwhich creates the gap. Can't fix it per css as that screws up placement of the boxes on the lower screen part.
E: actually it seems thumbnail size is wrong and causing this
E2: ah no, time/level is positioned too low
Comment has been collapsed.
geez not the theme accusations again, I rechecked w/o any themes before and there is still a 2 pixel gap
Comment has been collapsed.
How else would you explain why there's no more gap for me?
Comment has been collapsed.
for whatever reason chrome cuts off the bottom, ff doesn't
the time/level boxes are positioned too low
Comment has been collapsed.
Oh boy, don't tell me I'm gonna have to open Firefox to fix this. :/
Comment has been collapsed.
That would mess up Chrome then. And I cannot locate anywhere on the script where a 2px margin is added, so that's probably related to Firefox as well.
Comment has been collapsed.
That would mess up Chrome then
why?
where a 2px margin is added,
not directly, it orients itself at the most bottom item and those are the time/level boxes that go lower than the game picture is
Comment has been collapsed.
? If I move stuff 2px to the top, the gap will be gone from Firefox, but now there will be a gap on Chrome.
Exactly, but it only goes lower on Firefox.
Comment has been collapsed.
It won't as it correctly takes the picture as the lowest point then.
Only the time/level boxes are to be moved higher, they are too low atm.
Comment has been collapsed.
Like I said, they are not low on Chrome. They're perfectly aligned with the image. I'll open Firefox later to see what I can do.
Comment has been collapsed.
then it's the height, 18 on C, 20 on FF, fonts are equal on both
Can you enforce the height limit somehow?
Comment has been collapsed.
Can you tell me the code line that handles the positioning/size? Then I can take a look too.
Comment has been collapsed.
It's done by CSS. There is a margin: -18px 0 0 !important; rule on .esgst-gv-icons. See if adding height: 18px; or max-height: 18px; or line-height: 18px; to it corrects the gap.
Comment has been collapsed.
not sure why but it's still there, group or whitelist icons don't make it bigger anymore though
Comment has been collapsed.
Also, nowhere on my script is there a margin-top: 2px; added to that popout.
Comment has been collapsed.
it's using that attribute for positioning, when hovering over items at the bottom of the window the margin-top gets set to -252.8px
Comment has been collapsed.
Can you add a class on the stuff that the image borders get applied to so i can target them without messing up the regular ones 😀
Comment has been collapsed.
Sure, added. .esgst-ib-user to user avatars and .esgst-ib-game to game avatars. :)
Comment has been collapsed.
Suggestion: Estimate the chance of winning based on the amount of time left and the number of entries already entered.
This will keep the brand new ones from shooting to the top when sorting by chance.
chance = entries > 0 ? Math.round(giveaway.copies / (entries / (Date.now()-giveaway.startTime) * (giveaway.endTime-giveaway.startTime)) * 10000 ) / 100 : 100;This works well on the main page. I haven't checked all pages to see if it breaks anything.
Comment has been collapsed.
I have a feature tweak to suggest, regarding Giveaway Filters. Is it possible for the script to fetch the selected giveaways from filters from the following pages, instead of one specific page, up to a cap of 50 per page? To make this seem more clear since my explanation might be inaccurate. Let's suppose I only allow Package Giveaways to be shown, but the ones that are shown are from the same giveaway page and may be let's say 2-3, but what I would suggest is that giveaways are brought up from next pages(maybe have an option to set pages or even a time period) and the maximum number of them shown would be 50 per each page. I hope I didn't make this any more complicated than it may sound and also the frequent updates and useful features that come with them are really appreciated!
Comment has been collapsed.
I plan on removing pages from Endless Scrolling, so this suggestion would be quite simple to implement with that. :)
Comment has been collapsed.
plan on removing pages from Endless Scrolling
only for main GAs, or also forum,user,group pages?
Comment has been collapsed.
Switchable?
It's good for the main page, but for the forum I'd prefer to keep those.
Comment has been collapsed.
I mean simply removing the "Page X" heading at the beginning of each page to make the contents blend, so it would "remove the pages" just visually, to make it appear as it if you were actually endlessly scrolling (the contents blending and stuff). Would that be a problem for you?
I also think that would be nice for the refresh function and the Discussions Sorter, since they currently work on a page-by-page basis. It's a bit pointless to open 3 pages, for example, and when asking to refresh only the current one refreshes, in my opinion. I would prefer if all open pages were refreshed.
I'm still thinking about it though, so if you have any arguments that keeping it as pages for the forums is better, I'm happy to hear them. :)
Comment has been collapsed.
I'm actually going through bigger threads page by page to use the mark all read button per page as it can be too much to read through everything in one go and clicking each comment is too bothersome.
(A mark-read-till-here button would be nice)
Same goes for the page reload, though I can see that loading all pages being useful in cases too. 2 buttons can be a solution here.
Last point is visual orientation that those headers give. I guess I'll need to try the new variant to see if it works out fine.
Comment has been collapsed.
Adding two buttons would be fairly simple, I like that idea.
You would still have the pagination changing as you scroll down the page at the top, so you could use that for orientation. I'd just like to blend the pages because a lot of features would benefit from that.
Comment has been collapsed.
Own GAs are missing the hide button, or better yet making them filterable would be very beneficial.
Comment has been collapsed.
not sure if it was there before but now the winning chance shows up for finished GAs on user pages
Comment has been collapsed.
then the new coloring surprised me, but is it useful to have the chance displayed for finished GAs?
Comment has been collapsed.
Some people might like seeing that data. Also if they entered a giveaway and didn't win it, for example, they might want to see what were they chances when the giveaway ended.
Comment has been collapsed.
Yeah, giveaway features aren't loaded if there isn't a link to the giveaway. I should change that for some of them later.
Comment has been collapsed.
The advanced formula shouldn't apply to past gibs, leads to weird results ^^
Comment has been collapsed.
Yeah, I have to think a bit about how the formula for that would be. :P
Since for chance the default one was
copies / entriesand the advanced one was
copies / (entries / (currentTime - startTime) * (endTime - startTime))and for ratio the default one is
entries / copieswould it be simply the opposite of the chance one?
(entries / (currentTime - startTime) * (endTime - startTime)) / copiesI'm not good at coming up with formulas for stuff. xD
Comment has been collapsed.
Hey, did you delete all your data or just your user data when you were testing the crash bug before? I'm starting to think it's really related to the storage size. Either the storage size or the use of GM_setValue/GM_getValue. Do you get any can't convert to string errors when using the script on Firefox (these errors are only visible through Ctrl + Shift + J)?
Wish I could switch to localStorage to test, but unfortunately that doesn't work cross-domain, so the data wouldn't be available between SG and ST.
Comment has been collapsed.
Only wl/bl checker data.
Console shows no such errors for me.
Comment has been collapsed.
i strongly think it's storage size related tbh. cause after some updates my export is smaller and at those times, it's not nearly as bad at crashes. and other updates my export is larger, and those times it can't handle near as many tabs before crashing.
currently it's a little lower that normal.
Comment has been collapsed.
Yeah, I think so too, I intentionally caused my storage to increase and had to restart my computer because everything froze as soon as I opened any SG tab. And my storage is currently less than 2 MB, so that would explain why I've never experienced crashes. I'll have to think of something to reduce the size.
Comment has been collapsed.
The simplified version of Comment Tracker now counts all comments as read if the discussion hasn't been visited yet.
I, for one, kinda liked it better when it said 9 (+9) so I know I hadn't seen it.
Oh, and great work btw. I really appreciate it =)
Comment has been collapsed.
I have trouble with move cursor on popup menu after i pick giveaway in gridview. Window just closing, be need to search point where you can move mouse on it.
Style trouble.
Comment has been collapsed.
latest updates unsent gift sender seems flawless on all i know to test so far. ^^
only thing i still haven't tested is group+whitelist GAs wl entries rather than group, but i setup a few of those to end in 48hr. will let you know on that one then. ;)
Comment has been collapsed.
no, not yet. i had forgotten about that. will test that soon also. =)
Comment has been collapsed.
whitelist entry in a mixed group+whitelist is now working properly and sending with the unsent gift sender. ^^
only thing still untested is the gift difference, which i had setup a few to end in another 48hr to test that. ;)
Comment has been collapsed.
With 4.2.7.2 (Automatically mark comments as read in the inbox when clicking on the "Mark as Read" button.) enabled, the submit comment button is overlaid with the mark as read button, so I can't actually submit anything (in GA's if that's not clear anyway).
And would it be possible to add the hide button to the train extractor or is there any reason it was left out?
Comment has been collapsed.
Ah, thanks for noticing that. Will fix it in the next version.
No particular reason, I just have to implement my own button because SG's doesn't work if I bring it from the loaded giveaways. Will do it later.
Comment has been collapsed.
Ah, the way you took the screenshot made me feel like you were focusing on the white space. :P Do you have advanced formula enabled?
Comment has been collapsed.
Type/Level are loaded after Chance, so it might take a while for them to appear. But if it takes too long, it's probably the Firefox issue.
Comment has been collapsed.
I already made an issue some time ago. I am not sure if it was also about the entered page or about the Created one. Entered is OK for me, but Created is similar to the HarrisMA picture. I have it in Google Chrome and waited several minutes.
Comment has been collapsed.
Many thanks for adding the colored chance options Rafael!
I've been editing the source to use my own version of colored chances ever since I started using your script. And with the many changes recently... :D
Comment has been collapsed.
You're welcome! :)
Did you ever suggest it before? I have a feeling someone did, but I never got around to doing it, and I often forget suggestions if they're not posted on GitHub. :P
Comment has been collapsed.
Yeah, I suggested it when I discovered your script; quite a few months ago now. :)
I'll try and remember using GitHub in the future.
Comment has been collapsed.
Lately I've been on top of suggestions in this thread though, so it's no problem if you can't use GitHub. :)
Comment has been collapsed.
I did awhile ago too ^^
I have more too :3
a 2nd mark as read button then moves to the next unread comment
(and a 3rd for mark all till here)
Comment has been collapsed.
Indicate if there are unentered wishlist giveaways open.
Is it possible to add an sub option like:
"Ignore giveaways that you did visit but didn't enter."
Reason: Some wishlisted giveaways I won't enter because group restrictions and some others I can't because levels.
Comment has been collapsed.
Yes, will do it later. I also plan on enhancing the feature to look for unhidden/unfiltered giveaways from Giveaway Filters.
Comment has been collapsed.
Thanks! What is the frequency that ESGST reads the wishlist to identify a new giveaway?
Comment has been collapsed.
It's the Header Refresher frequency, every 60 seconds.
Comment has been collapsed.
How about link the:
"Giveaways Filters > Enable the option to hide giveaways"
or
"Giveaways/Discussions/Tickets/Trades Tracker > Fade visited giveaways"
to the
"Header Refresher > Indicate if there are unentered wishlist giveaways open."
to make the wishlist heart disappear when you did already visit the giveaway?
Comment has been collapsed.
Yes, that's what I had in mind, just haven't had the time to do it yet.
Comment has been collapsed.
It is probably not necessary to check if items are "Bundled" when looking at The Bundle List.
Comment has been collapsed.
The headings in "Giveaways created" and "Giveawways won" are not in order with the latest update.
Comment has been collapsed.
Could it be that "Pagination Navigation On Top" is always enabled, regardless of the actual setting state?
Comment has been collapsed.
The feature is automatically enabled if Endless Scrolling is enabled, do you have that?
Comment has been collapsed.
Both Endless Scrolling (#16) and Pagination Navigation On Top (#8) are disabled, yet the page numbers are at the top, above comments.
Comment has been collapsed.
sry if i missed something somewhere, but where did my little heading button go to add a new comment to a page? (popup style)
it looks as if searching for a specific user comment has replaced it.
edit: added photo to show my endless scrolling settings.
Comment has been collapsed.
It appears fine for me. That feature is not related to Endless Scrolling though, it's Comments.5 Reply Box Popup.
Comment has been collapsed.
that was it, thank you! odd that it disabled itself though.
Comment has been collapsed.
There was actually a bug that was making the feature load even when disabled, so that's why you were able to see it even with it disabled.
Comment has been collapsed.
ahh, okay. that sounds accurate, because it just appeared for me one day. i found it very useful though and kept using it. ^^
Comment has been collapsed.
for anyone that wants it....
a fresh bundlelist export ^^
Comment has been collapsed.
Request: can you use css variables on the level progress visualizer css so themes can change it ;)
Example
.esgst-lpv-container {
background-image: linear-gradient(to right, var(--level-bar, #609f60) ${fullBar}, transparent ${fullBar}), var(--nav-button, linear-gradient(#8a92a1 0px, #757e8f 8px, #4e5666 100%)) !important;
}Comment has been collapsed.
That's what I added you on Steam to discuss, I wasn't sure how it would be possible to make themes work with the new changes, but wow, you can use variables in CSS? You learn something new every day. :P Will add it to the next version.
Comment has been collapsed.
Will have to test later but i don't see a problem in the code. Would be good practice to have variable names unique to your script though to eliminate the chance somebody else uses the same name.
Edit: tested and works as expected.
Comment has been collapsed.
Ah, I thought the variables only worked under .esgst-lpv-container, or at least that's what I got from my testing. I'll add a esgst-lpv- prefix in the next version.
Comment has been collapsed.
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.