I'm getting those two errors in the latest version(FF+GM):
TypeError: savedUsers.steamIds is undefined ESGST.user.js:4001:13may be sync related
esgst.users.steamIds is undefined ESGST.user.js:28189:13may be usertags related
Comment has been collapsed.
Can you try exporting your user data to see if everything looks fine? Or does the menu not even load?
Comment has been collapsed.
the first one doesn't do nothing that i can see, the second breaks gridview.
what should i be looking for in the export?
Comment has been collapsed.
Is there a "steamIds" key in there? Did you recently import data? Or did it just stop working immediately when you updated?
Comment has been collapsed.
no "steamIds" anywhere that i could find, i tried enabling the user tags only after the last update so don't know when the storage corrupted, i did make a import about one week ago i think, where should it be(under which key)?(I assume that placing it in the correct place even if empty would fix the errors)
Comment has been collapsed.
The JSON should look like this:
{
"users": {}
"steamIds": {}
}But I'm afraid just placing it empty will not show your data.
You could use this function to correct that:
correctData();
function correctData() {
var savedUsers = JSON.parse(GM_getValue(`users`));
savedUsers.steamIds = {};
for (var key in savedUsers.users) {
savedUsers.steamIds[savedUsers.users[key].username] = key;
}
GM_setValue(`users`, JSON.stringify(savedUsers));
}Backup first just in case.
I think there's currently a bug while importing user data without "Merge" enabled that erases steamIds, and that property is used for locating the users in the storage from SG. I'll look into it later.
Comment has been collapsed.
when i did the import(to fix something i broke) i did it without enabling the merge option, will try your code and report back
Comment has been collapsed.
I just fixed it, importing without "Merge" enabled should now import correctly.
Comment has been collapsed.
It worked :D
Did you edit your comment? the code i copied had a ")" missing but the code in your comment is correct *scratches head*
Comment has been collapsed.
Nice. xD
Yeah, I edited it in less than 2 minutes after I posted. When you edit a comment in less than 2 minutes (or 3, I don't remember), it doesn't add the "*". :P
Comment has been collapsed.
It's 3 minutes if I'm not mistaken, I thought so but could also be a bug in the program that manages my clipboard so better ask :P
Comment has been collapsed.
I updated to the latest version and I noticed two things.
-
The star for Encrypter/Decrypter's giveaways in the top bar is not showing up in pages that don't have an encrypted giveaway anymore, it used to always be on the top bar and change to green if there was an encrypted giveaway in that page. Was it changed back to only showing up when there is an encrypted giveaway?
-
The other thing is that I'm confused with is the redesign of the sorting feature.
I used to sort the winning chances in the entered giveaways page. What does the enable do? I was thinking that with it enabled it would auto sort every page, so with endless scroll active it would auto sort page two when you scroll down, and then page 3 and so on, but nothing happens. To sort page 2 I need to click the icon and select again what type of sorting I want and then repeat for page 3 and page 4, which is a bit annoying because now each sort takes double the clicking and going down a list.
Also, if you sort page 1 by "chance - ascending", you cannot just go to page 2 and click it again, you can either click enable or click another sort and then click the "chance - ascending" again, but if you clicked enable and go to page 3 then you either disable and enable it again, or click another sort and click the "chance - ascending" again. So it feels really clunky.
Am I missing something here?
Comment has been collapsed.
- Are there errors in the console? The star shows up fine for me everywhere.
- Yeah, I have to enhance the feature. "Enable" is currently a bit useless, it simply triggers the selected sort.
Comment has been collapsed.
-
No errors. I checked in multiple pages, from ones that are showing the star to pages not showing the star.
-
I would suggest the enable to be an auto sorter, if it's enable it will sort all the pages so the current sort option. But this might be an issue if it's applying to all pages equally, since the user might now want giveaways/new to be sorted, but might want giveaways/entered sorted.
The other option that I thought of was using 4 icons, one for each type of sort. And if the button would have a default, like descending, but if you click again it would sort ascending. So Game Name could be an A-Z's icon, End Time could be a clock, Entries could be a # symbol and Chance could be a % symbol. But this would take more space, but would only need one click to sort, specially if in the options there is an option to set the default for each sorting, like put the default for game name to be descending, but chance to be ascending.
Comment has been collapsed.
And in all pages showing the star there is a decrypted giveaway?
Comment has been collapsed.
This page (page 42) is showing the star and has an encrypted giveaway, page 41 also has the star and has an EG, page 40 same thing, same for page 39... OMG, I picked the worse thread to check, lol. Page 37, no star and no EG.
Comment has been collapsed.
this page (42) no star here. -- so it's not even all that constant.
Comment has been collapsed.
Can't find the cause yet, page 37 shows the star fine for me. It's so weird that this is happening, I didn't even touch the button in the last update.
Comment has been collapsed.
From d3m4n's comment, it seems that it's even more random than what I thought. I thought that it was only not showing in pages without an EG linked, but it seems that for him it's also not showing in pages with an EG linked.
Edit: Also, it might not have been in the last last update, since when I updated I had "last updated" at 27h, so it could have been a change from version 22.1 to now. And maybe this bug was already present in previous versions and I just didn't noticed, but noticed right away when I updated 5h ago.
Comment has been collapsed.
it's working again for me in the latest update now. (23.3)
Comment has been collapsed.
it's working again for me in the latest update now. (23.3)
Comment has been collapsed.
the filter is no longer working for me on the decrypter or train extractor, but the star icon appears at all times again for me.
(all i want filtered is owned content)
edit: "show only" the "owned" works, but the reverse in hiding the "owned" does not work.
Comment has been collapsed.
I don't have the star icon in multiple pages that I looked at, like the entered giveaways page, the new giveaways, messages, main discussion page, ...
I have the icon on this page (42) but there is an EG here.
Maybe there is a conflict with that feature and another feature of the script?
Comment has been collapsed.
Maybe there is a conflict with that feature and another feature of the script?
it's very very possible. there are so many different combinations of features being turned on/off, that i'm sure there are still several bugs in feature compatibility. though i didn't change any settings personally since the last update.
Comment has been collapsed.
Would explain why it happens for some but not others, while users have the same version and no errors pop out.
Comment has been collapsed.
Just woke up and the star icon is working again in every page, I thought maybe there was an update that fixed it, so I went to TM's dashboard to check, but I'm still in 23.3 (last update was 34h ago). Have no idea what fixed it.
This bug is so weird.
Comment has been collapsed.
yeah that is weird. afaik revil didn't do anything to fix it either. ^^
but... glad it's working for you also again. =)
Comment has been collapsed.
I don't think using 4 icons would be a good thing, it would add too much clutter to the heading. Plus, it's impossible to sort by two methods at the same time, so it doesn't make much sense. I think your first suggestion is better.
Comment has been collapsed.
Yeah, I figured that you wouldn't like 4 icons :P
I started using the new feature of using colors for chance intervals, since it works for what I want (showing me when the chance is below a certain number to leave those GA in case I need points for something else) and I don't need to do a lot of clicking, and it works with endless scrolling.
Comment has been collapsed.
Added an option (Comments.7.1) to Reply From Inbox that keeps the replies in the inbox page when refreshing (closes #179).
&&
All checkers now show how many pages there are left to check (closes #53).
very nice enhancements. =)
Bundles are now synced from a Google Sheet database that is updated daily.
extremely nice here. it also made it feel a lot lighter, idk if it really is now or not, but it feels snappier on loads. ^^
i also can confirm Nyx's #1 report. the decrypter isn't loading the * at the top anymore if there isn't a encrypted on the current page.
Comment has been collapsed.
Yep, it works in discussions, although it's currently bugged if the discussion leads to a train with more than 50 giveaways.
Comment has been collapsed.
Is there any way to hide the mass giveaways from main page?
*"Hidden Featured Container" doesn't hide them... It only hides the latest giveaway I believe.
Comment has been collapsed.
Hi, there's actually a way: use Giveaway Filters and select the option to hide pinned giveaways.
Comment has been collapsed.
That do the trick. Actually, great filter option. I just found what I was looking for a long time ago! thank you!
Comment has been collapsed.
"Please remember, all games you receive need to be activated on your corresponding Steam account to remain in good standing. Users failing to do so will receive a suspension."
Is the above warning, on https://www.steamgifts.com/giveaways/won, an indication that I have failed to activate a game, or just a general warning?
Comment has been collapsed.
General warning. That message isn't added by the script though, it's from SG (I got a bit confused by you asking that in this thread :P).
Comment has been collapsed.
: )
I have inadvertently failed to activate a game once in the past, and only realized it when another user pointed it out. If the script has the potential to do such a check, if might make a nice feature in a future version.
Comment has been collapsed.
On a side not there is an error on giveaway groups loader setting 16.2 that hides this warning.
TypeError: Cannot read property 'add' of undefined
at setGglButton (eval at E_c (:3:221), <anonymous>:9888:37)
at Array.setGglButtons (eval at E_c (:3:221), <anonymous>:9882:13)
at loadGiveawayFeatures (eval at E_c (:3:221), <anonymous>:28128:38)
at Array.startGiveawayFeatures (eval at E_c (:3:221), <anonymous>:28115:13)
at loadFeatures (eval at E_c (:3:221), <anonymous>:3754:31)
at loadEsgst (eval at E_c (:3:221), <anonymous>:3132:25)
at eval (eval at E_c (:3:221), <anonymous>:417:5)
at Window.tms_1914d076_015f_45f3_8386_b5369dfb6c0f (eval at E_c (:3:221), <anonymous>:29823:3)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)Comment has been collapsed.
Not sure if this is a bug or not but on someone's profile on whitelist giveaways there is an "Enter" button even though I already have the title (and SteamGifts detects it properly)
Comment has been collapsed.
If you have not synced through the settings menu the script cannot detect your owned games.
Comment has been collapsed.
Nah, I don't think I mention that you have to sync in the description of the feature. The script is not very well documented for new users, so it can be a bit confusing if you're starting to use it now. :)
Comment has been collapsed.
This keeps loading up, every 30 seconds
https://www.steamgifts.com/esgst-sync
Btw, did esgst replace rhGST? What happens to comments on people profiles etc. if I remove rhGST?
Edit: Weird, not it says "syncing your steam groups..."
Before it was always an empty page.
Comment has been collapsed.
Oh boy, yes, ESGST replaced rhSGST a very long time ago, so rhSGST is very old and there isn't support for it anymore. You're gonna have to update to oldest versions before coming to v6 if you want to keep your data. You can find old versions here. Were you in v3? I suggest updating to v4, then v5, then v6, then the current. Loading a SG page every time you update, of course. It might be a bit complicated, you might have to export from the previous version and import to the new version for it to work completely.
That's the automatic sync, to disable it you have to go to the settings menu and set a sync frequency of 0.
Comment has been collapsed.
I have both installed atm.
Does that mean I should deinstall ESGST then manually install v3, v4 etc so the data can be imported by ESGST from rhSGST?
Comment has been collapsed.
Yes, uninstall ESGST. Because of the name change, you will have to either:
- Edit the metadata of rhSGST before updating (by changing @name and @namespace to ESGST).
- Or export the data from rhSGST and import it into ESGST.
And then go up one version at a time, v4, v5, v6.Beta.0.0 and then the current.
Or if you want to save all that trouble we can try to edit the exported file from rhSGST to make it compatible with ESGST.
Comment has been collapsed.
In the "create new giveaway" screen there is a "create giveaway" button (next to "review giveaway", both at the top and bottom) that seems to belong to ESGST, but I can't find the setting to disable it. My bad or little bug?
Comment has been collapsed.
So I guess there is no way to remove that button without disabling templates.
It would have helped me because sometimes I apply a template and then click on review only to check a game's CV, or even when I create a proper GA I always prefer to review it to be sure of everything, and the presence of the immediate confirmation button scares me a bit, but maybe it's not so important. :)
Comment has been collapsed.
clearly we should wait and see if CG add's a "free list" similarly to the way "bundle list" is done, but either way, eventually.... do you think we could have those labeled with a "Free" category to help identify them?
cause personally if a game isn't currently categorized as "Bundled", i think a lot longer and harder if i want to even enter into the giveaway. but, the same will be extended for "Free" games as well. for instance "dead by daylight" is not tagged with bundled, but it has been free, so i don't really have to think twice on trying to win that one.
Comment has been collapsed.
I was thinking of building another Google Sheet database for that and use that SG discussion with the list of the games to fill it up. I'll see if I can do that later today.
Comment has been collapsed.
that list won't remain accurate as to what is/was free from here out though. since the change, i'm pretty sure it will be abandoned.
Comment has been collapsed.
There seems to be a bug with the recently updated filters, whenever I check owned games to not be shown they are shown, whereas when I check for owned games only to be shown, they are not, acting reverse.
Comment has been collapsed.
They're working fine for me. Does it happen on any page or somewhere specifically?
Comment has been collapsed.
ahh yeah, this was what i tried saying earlier, but said incorrectly. train extractor + decrypted giveaways "show only" "owned" hides all owned instead.
edit: fixed in 23.4
Comment has been collapsed.
Added a button to Giveaway Filters that allows you to enable/disable all filters for the current page
The additional row takes away on vertical space. Possible to put the button beside the 'expand filters' row instead?
Prevented "Bundled" category in Game Categories from loading in the bundle list page.
That was actually useful to see items missing from the sync.
--
Can the on button of the GA sorter be placed directly on the visible row? I liked the previous way of quickly sorting on/off with the old button.
--
'Giveaway Templates' buttons show up despite being disabled.
--
please add a button to delete 'dead weight' wl/bl checker users that are in a neutral state ^^
Comment has been collapsed.
The additional row takes away on vertical space. Possible to put the button beside the 'expand filters' row instead?
I don't even know what you mean by that, put the "Save" button inside the "Expand filters" button? That would be quite ugly, I think. But the "Legend" row already takes away on vertical space anyway, so I should probably just try to reduce the width taken by the basic filters or add short names to the other filters.
That was actually useful to see items missing from the sync.
Is there even a use for this with the Bundle API? It updates daily and you can just go to https://script.google.com/macros/s/AKfycbwJK-7RBh5ghaKprEsmx4DQ6CyXc_3_9eYiOCu3yhI6W4B3W4YN/exec?recent=true to see recently added games.
Can the on button of the GA sorter be placed directly on the visible row? I liked the previous way of quickly sorting on/off with the old button.
Do you mean the "Auto Sort" switch? No, it doesn't make sense, as that switch doesn't sort anything. If you mean the "Sort" button, then yes, I can.
Comment has been collapsed.
I think I need to illustrate the first, see pic ^^
Bundle API
huh, how did that sneak in, never knew :D
mean the "Sort" button
yes, like it worked previously, a quick single click to sort it and another to return to normal, without opening a menu/popu first
Comment has been collapsed.
I think I need to illustrate the first, see pic ^^
Ah, ok. But I still think that would be very ugly. I actually plan on moving the entire filters feature to the main page heading, so that it scrolls along with the page for users using Fixed Main Page Heading.
huh, how did that sneak in, never knew :D
v6.Beta.23.0 introduced it: https://www.steamgifts.com/discussion/qcvQE/
yes, like it worked previously, a quick single click to sort it and another to return to normal, without opening a menu/popu first
It never returned to normal though. :P Once sorted you have to reload the page to restore the original order.
Comment has been collapsed.
filters feature
can it then be 'click to expand' on that 'legend' row instead of being separate?
never returned to normal though.
consider it a feature request then haha ;-)
Comment has been collapsed.
can it then be 'click to expand' on that 'legend' row instead of being separate?
What? The "Legend" row isn't separate. I'll do some changes to the feature later and then you check it out.
Comment has been collapsed.
idk where the other message went, and don't feel like tracking it down but...
i'm semi-pleased to report that the "gift difference" check on the "unsent gift sender" works beautifully and caught a -1 gift difference in a group that requires +8 difference right away. =)
only semi, cause now i gotta deal with it... xD
edit: ahh, actually much more pleased then initially thought.. that user gets a pass on that since they hadn't won their first 8 giveaways yet. ^^
Comment has been collapsed.
Can it be that the Owned Filter doesn't work right now? (I synched just to make sure that was the problem but it made no change.)
On both the encrypted giveaways and train extractor popups I have it set to filter out owned games but it still shows them.
See screenshot; I own all the encrypted games.
Edit: I enabled 7.4 Game Categories just to see and Owned was still listed there as number 7. However, even enabling that doesn't make the filter work, the games do correctly get a green 'Owned' tag though.
Comment has been collapsed.
10 Sync > "Bundles" still exists, though should now be invalid.
Comment has been collapsed.
Assuming you don't use automatic sync, you could enable it and leave only "Bundles" checked, so that you don't have to manually sync it every time. This actually gave me an idea of adding the possibility of having multiple automatic syncs set for different times/types.
Comment has been collapsed.
i do use auto-sync. but only on a 7day basis, and i usually manually sync before it ever occurs. the bundle list is something i prefer to be updated more then once a week for certain though.
Comment has been collapsed.
Syncing either bl or wl deletes data of the not synced one
example: sync wl, makes bl symbols disappear
-
new header stuff screws up dark theme (the bar increases width every-time when switching from fixed to floating position), but I guess that's in the theme to be fixed, though I don't know where to even start looking lol
Comment has been collapsed.
Themes are updated now but i never came across that problem, might only be in your version.
Comment has been collapsed.
It was there too, need to check your changes I guess ^^
Comment has been collapsed.
I understand what you are talking about now, corrected in version 1.4.6.2
Comment has been collapsed.
You set the min/max width and a calculation on width on the giveaway filter container, everything but min-width will depend on if you use fixed page width in the script or if you use fullscreen width like the default css. I just tossed up a quick max-width on the script version the rest i am doing today. The next update will just be these fixes so it will be easy to do a diff on the css or look at the diff on greasy fork.
Comment has been collapsed.
Usterstyles seems not to provide any diffs or history at all, any way to get those for the css?
Are calculations with css only even possible?
Comment has been collapsed.
Moving filters to ga section so they float breaks site. When first loaded site everything is fine. Then I scroll down and up and it widens site to full width of browser. But when I scroll down and up again it widens site even more beyond browser's max width. It probably happens because filters box is too wide. You will have to move legend or make filter box matching screen sizes for different resolutions.
Comment has been collapsed.
No that is the dark style causing that. It is mostly fixed in the latest version, i will correct the rest later.
Comment has been collapsed.
I updated style and most is fixed. Just in case here are screenschots: http://imgur.com/a/w7wqQ
Comment has been collapsed.
dark theme issue, same one reported by tristar above you and already fixed by SquishedPotatoe, you might need to force update it
Comment has been collapsed.
Ah, I use ST, so my menu is a bit different, which is why I use the notation "Users.16" in the changelog.
Comment has been collapsed.
Some strange thing with Entries Remover.
When it's automatically triggered upon SG sync it only searches for entries to remove on EVEN pages (2,4,6,8...)
When it's runned manually from Entered GAs page it only searches for entries to remove on ODD pages (1,3,5,7...)
At first i thought that it's only bug of displaying, but different syncs removed different entries
I'm using firefox + Greasemonkey
Comment has been collapsed.
No bugs this time, but I want to throw some requests/suggestions in the room :)
Would it be possible to add:
- a second timestamp for posts that have been edited, which shows when they had been so last. SGT frog does this already, but I'm trying to reduce the number of active scripts :)
- a filter function to the discussion area. F.e. only show unread threads, threads with new comments, highlighted threads ....
I know there is already a way to show only the highlighted ones, but I was wondering if it might be possible to do so on the discussion page, in a way more like filtering for the GAs work, instead of showing them in a popup.
Comment has been collapsed.
Accurate Timestamps already does that, unless you want just the basic timestamp.
Comment has been collapsed.
Ah well :P
I actually checked the options menu before posting to see if I had missed something which is already there, but I only checked the tooltip of the feature, never actually tried it and thought it was only replacing the "... ago" with timestamps...
Nevermind that point then:)
Comment has been collapsed.
a filter function to the discussion area. F.e. only show unread threads, threads with new comments, highlighted threads ....
I know there is already a way to show only the highlighted ones, but I was wondering if it might be possible to do so on the discussion page, in a way more like filtering for the GAs work, instead of showing them in a popup.
I wanted to ask for this too. It would be really helpful. Some other filters could be the date created (we could use it to hide necromanted topics for example) or show only unvisited threads.
Comment has been collapsed.
Hi, exception filter for wishlist is not working. Setting something in basic filters hides wishlisted games. :(
Comment has been collapsed.
Hi, sorry for the late response. Is this still happening? Is it possible you haven't synced your wishlist through the settings menu?
Comment has been collapsed.
Hi, no problem. :)
Yes, it is still happening. To be sure, I synced my wishlist in ESGST just now, but it still happens, so probably it's not cause.
Comment has been collapsed.
When syncing, the script will now show a list of missing/new groups/games (closes #268).
awesome change! ^^
thanks
Comment has been collapsed.
"Winning chance" is displayed on the GA page for public GAs but not for "Invite only" GAs.
Comment has been collapsed.
To be more precise
if (((giveaway.inviteOnly && giveaway.ended) || !giveaway.inviteOnly) && !giveaway.innerWrap.getElementsByClassName(`esgst-gwc`)[0])means it will only run on non-invite giveaways and ended invite giveaways, so started invite giveaways will never pass that statement.
Comment has been collapsed.
If it is intentional (which I doubt) then I hope it can be changed.
Comment has been collapsed.
Not intentional ;) and can be changed.
if (((giveaway.inviteOnly && giveaway.ended) || !giveaway.inviteOnly || giveaway.started) && !giveaway.innerWrap.getElementsByClassName(`esgst-gwc`)[0])Comment has been collapsed.
That would actually lead to bugs in the profile page for invite only giveaways that have started, because they show "Invite Only" instead of the game title and number of copies until they end. But anyway, I fixed it properly in the latest update.
Comment has been collapsed.
Yeah it occurred to me later that there must be a reason why the invite stuff was even in there to begin with, but i was not about to go looking :P
Comment has been collapsed.
Nope, that was to fix a bug that was not showing the chance/ratio for ended invite only giveaways in user profiles. I didn't realize I had actually created another bug while fixing the other one. :P
Comment has been collapsed.
I don't think it was reported that they were not appearing in popups. But yeah, I see that there's a flaw in the statement which doesn't show them unless the giveaway comes from the main page, will fix later. :)
Comment has been collapsed.
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.