Seems the wl checker returns many false positives when scanning a list (like group users page) for users who only have shared wl-group ga. When rechecking the single user with cache clearing enabled it suddenly gives the correct result.
It may be related to the unresolved undetected-group bug.
--
Are you planning to do this change:
Comment has been collapsed.
Did you check the latest version? I already redesigned Giveaway Filters.
Comment has been collapsed.
The 2nd bar is still there. What I mean is having it completely hidden when not expa´nded and the expand/collapse button be placed on the legend/heading bar.
Comment has been collapsed.
I don't think I'll be doing that, no. There wouldn't be a place to put the "X giveaways filtered" count, among other reasons. It's just better as a separate bar and I highly doubt it's bothering you that much, since it takes literally 21px of height. :P
Also, it's quite confusing when you refer to it as "legend bar". I can't really understand how it's related to the "legend" term.
Comment has been collapsed.
I don't even know how to call it xD you used that term some bit above
And yes, every bit of useless vertical space waste is to be tackled ;-)
You had that "X giveaways filtered" not on the 2nd bar just the version before either
and I was secretly hoping that would eliminate the css issue, stuck on 23.3 now until I go through 1284 to solve that (ಥ﹏ಥ)
Comment has been collapsed.
The area around the bar just needs a :not(.esgst-gf-container) added to the .page__heading ~ div:not section or are you talking about the width issue from before?
Comment has been collapsed.
talking about the width issue
yes.
What is the code you mentioned doing?
Comment has been collapsed.
- background-color
- border
- border-radius
- min-width
- margin-bottom
- margin-top
- padding
of the area around the bar.
Comment has been collapsed.
The width issue for the fixed page width setting i posted for version 1.4.6.3 was
.sidebar--wide + div .esgst-fmph, .sidebar--wide + div .esgst-fmph-background, .sidebar--wide + div .esgst-gf-container-fixed {
max-width: 1041px;
}
.esgst-gv-view {
min-width: 870px!important;
}
.sidebar--wide + div .esgst-gf-container {
width: 100% !important;
}
.sidebar + div .esgst-fmph-background, .sidebar + div .esgst-fmph, .sidebar--wide + div .esgst-gf-container-fixed {
min-width: 872px !important;
width: calc(100% - 281px) !important;
}
.sidebar--wide + div .esgst-fmph-background, .sidebar--wide + div .esgst-fmph, .sidebar--wide + div .esgst-gf-container-fixed {
width: calc(100% - 409px) !important;
}Comment has been collapsed.
Looking at the older CSS you said you were using before the main problem is .widget-container > div:not(:first-child) the margin should be removed and the padding set to 0.
.widget-container > div:not(:first-child) {
border-left: none !important;
box-shadow: none !important;
padding-left: 0px !important;
}Comment has been collapsed.
By "legend" I was referring to the legend area inside the giveaway filters (the one with the icons and the text explaining what they mean). I just call it heading as that's what makes the most sense and is also how cg calls it in his classes. :P
Well, I wouldn't call it useless. It shows you how many giveaways are filtered.
You had that "X giveaways filtered" not on the 2nd bar just the version before either
That was before the filters were moved to the main heading. Before, it had a whole heading to the feature, so there was no problem in putting the "X giveaways filtered" there, but now it shares the main heading with other features that already take a lot of space, so there's no room for "X giveaways filtered" there.
23.3 still doesn't seem like that much to me, but what CSS issue?
Comment has been collapsed.
I can confirm what SpaceClick said above; the winning chance is no longer displayed on Invite Only giveaways.
Comment has been collapsed.
Comment has been collapsed.
What about a queue feature?
When you don't have enough points to enter a giveaway, you'll just add it to a queue, that sorts all the queued giveaways by time left? Maybe also add an autojoin feature for queued giveaways, if that isn't against the rules.. :)
Comment has been collapsed.
i'm pretty sure i won't be needing to filter groups with or without presets. btw, where do i turn off the preset feature? i certainly won't need it.
Comment has been collapsed.
There's no way to turn it off, the feature has been redesigned to work only with presets. If you open the filters panel you will see that the preset field will have something like "Default[Name]" in it. So the default settings you use are also a preset and there's no way for you to save any modifications you make without saving the preset.
Comment has been collapsed.
You can just deactivate the filters switch, can't you?
Comment has been collapsed.
i like the filter switch, it's just this preset thing i think is a little weird. i just prefer the way i sat it up, idc to change it with some weird preset template settings (other than the on/off toggle).
Comment has been collapsed.
The bug with the star in the top bar returned.
I was thinking that it was due to a new update of the script, so I went to check the TM's dashboard to check. However I was still using the version 23.3. So in the same week while I was in 23.3 the star disappeared, returned and then disappeared again.
So I thought, maybe the new version fixed it. Updated to 23.6, but still no star in pages that don't have any EG linked in them. T_T
This bug is so random.
Comment has been collapsed.
I still don't understand why there are no errors in the console and why it appears to only be affecting you and d3m4n. Just to be sure, you have clicked in the star when it is green, right? And I forgot what browser you're on, Firefox?
Comment has been collapsed.
Wait, you need to click the green star for it to show up in other places? I went to page 43 of this thread that had EG and clicked the star, came back to this page (44 with no EG) and got the black star back.
I usually click the stars in the comments and very rarely click the green star. So that might explain why it keeps showing up and disappearing, but does it work like that?
I'm using Chrome.
Comment has been collapsed.
Of course, if you don't click the star it cannot decrypt the giveaways and therefore does not add them to the storage. The stars in the comments are simply links, so they don't need any information. By clicking on the header star, the script needs to know the ending date of the giveaways, so you have to click on the star for that information to be retrieved and stored.
Comment has been collapsed.
Oh, so I should click the star at the top from time to time...
Comment has been collapsed.
If you want to store the giveaways, you have to click it every time it's green. If you don't use the star though, there's no need for doing that.
Comment has been collapsed.
I don't see any star either.
Here on page 43 and in the "don't like bots" thread, where I'm positive there are encrypted GA's.
Only place I see the star is on my profile page and on the main SG page.
Comment has been collapsed.
If you're on Firefox, that might be expected, as other users have reported issues with the script on Firefox. If not, check the console.
Comment has been collapsed.
Comment has been collapsed.
profile.sentRowRight.firstElementChild.getAttribute(...) is nullI have a feeling cg changed something again
Comment has been collapsed.
Hi!
There seems to be some bug in importing games with multiple keys. When i try to import this for example in import page: Super Rude Bear Resurrection XXXXX-XXXXX-XXXXX XXXXX-XXXXX-XXXXX XXXXX-XXXXX-XXXXX i get this error message: Super Rude Bear Resurrection XXXXX-XXXXX-XXXXX was not found! Please correct the title of the game and click on "Import" again to continue importing (it must be exactly like on Steam).
And i i remove it to only Super Rude Bear Resurrection XXXXX-XXXXX-XXXXX it works fine.
Comment has been collapsed.
Follow the format. It should be:
Super Rude Bear Resurrection XXXXX-XXXXX-XXXXX
Super Rude Bear Resurrection XXXXX-XXXXX-XXXXX
Super Rude Bear Resurrection XXXXX-XXXXX-XXXXX
Comment has been collapsed.
Yeah i know that works too but previously that worked what i just posted too and in instructions it says that too. But i will use that method from now on then. :]
Thanks for the info!
Comment has been collapsed.
Nope, the instructions say how I just posted. I don't see how it would have ever worked that way before, it's literally impossible.
The instructions:
Portal
Portal ABCDE-FGHIJ-KLMNO
Portal ABCDE-FGHIJ-PQRST
Portal (2 Copies)
Portal ABCDE-FGHIJ-UVWXY
Comment has been collapsed.
I must have read that wrong. But i really still strongly believe that my method worked before. But thanks for correcting me! :]
Comment has been collapsed.
Thank you very much for your awesome work. This is definitely the best SG script I´ve ever used.
Would it be possible to add an option to hide single discussions like it is already possible with giveaways?
Browsing the discussions would be much more enjoyable with the ability to hide shitposts etc :)
Comment has been collapsed.
Hmm, my (many) user tags appear to have vanished. They were here a day or two ago. I'm not sure what changed; nothing on this end, so far as I know. Firefox 54.0.1. I can see a few of the oldest tags on the list of discussions, but not newer ones, and many/most of the notes on users have gone too (I use tags and notes to keep track of who has won from me, whom I've won from, and what we've all won).
Comment has been collapsed.
OK, I see the tags in some places, but they have all vanished from my user page, where I'm also not seeing the icon for user tags at all. I'm going to do a full shutdown and come back in to see if that fixes things, I may have been hasty in posting.
Comment has been collapsed.
What version were you on and what version are you now? Try exporting your data and seeing if the tags are there. Do you have backups that you can import?
Comment has been collapsed.
Working on it now. I think what happened is that I was running rhGST and ESGST, and all my settings were in rhGST. I've exported data and am now working on the ESGST settings - if I import that data back in, are we likely to have success?
Comment has been collapsed.
Looks like it worked - thanks for pointing me in the right direction. I've disabled rhGST now, and will work in ESGST from now on. And paying a little more attention on my part might also not be amiss. Thanks for your patience! (I actually wasn't aware that I could export the data, until you suggested it.)
Comment has been collapsed.
You exported from rhSGST and imported into ESGST and it worked? Well, that's new. rhSGST is an extremely old version and I haven't supported it for a few months now, so I'm really surprised to hear that you were able to export from one into the other without any problems. Usually people have to go through a lot of steps to update when they are coming to ESGST this late.
Comment has been collapsed.
Lucky I guess. Perhaps it's because of my simplistic use of rhGST - really only user tags and user notes, with a couple of tweaks (endless scroll off, that sort of thing). The first few times I tried to import the notes and tags there was no response, and then when I thought about it I tried exporting all data choices, even though most of them were not used, and imported all fields as well with the merge option chosen. ESGST had been running here for months, but I guess it was probably only actively handling one or two minor adjustments, if anything at all.
In any case, it did work!
Comment has been collapsed.
Dont think it was like this before the steamgifts stats update. But should the button for "find not received giveaways" come up if you have 0 not received.
On my page it came up and found 0/2 when I searched. And I guess its because I have 2 awaiting feedback.
Comment has been collapsed.
Sorry, I forgot about this. Can you reply here when you have awaiting feedback again so I can test? Or do you know a user who currently has awaiting feedback that I can use to test this?
Comment has been collapsed.
Any chance that we can get "winning chance" back on the GA page for active invite-only GAs?
https://www.steamgifts.com/go/comment/5tKkOm6
Thanks!
Comment has been collapsed.
What browser are you on? The script is currently known to be a bit buggy in Firefox/Greasemonkey.
Comment has been collapsed.
Ah, yes, just checked your username history. xD
Did Firefox went through any updates lately that would affect the sudden changes? I have in mind to stop using GM_setValue/GM_getValue and go back to using localStorage, not sure if I'm gonna do it yet, as it would mean data would not be shared between SG and ST, but that seems to be the only solution to all problems. We'll see, but unfortunately I don't think I can do anything at the moment.
Also, did you keep an eye on the console while those things were happening for errors (anything besides the "can't convert to string" errors)?
Comment has been collapsed.
Interesting, so it looks like I won't need to remove GM_setValue/GM_getValue after all. Wonder what caused the corruption though.
Comment has been collapsed.
I don't have Space Cat anymore when I win, am I the only one with this problem ?
Comment has been collapsed.
Are you sure this is related to this script? Try disabling it when you win something.
Comment has been collapsed.
Well, I won 2 times since I have it installed, and 2 times I don't have the cat. Last time I got the syncing page opening at the same time, so i thought it was because of it, but today i didn't got the sync page nor Space Cat. I disabled all the script I had, since this one cover everything (great job :D). I don't know what else could prevent Space Cat...
Also, it a bit difficult to know when I'm gonna win ^^ I'm going to try to disable it each time I leave the site and enabled it when i come back.
Comment has been collapsed.
If this is related to the script, it's a really hard bug to test because I would have to win something to try to figure out why it's happening. I'll see if I get lucky. xD You can also leave the script enabled and check the console when it happens.
Comment has been collapsed.
well... when the script is fetching pages for functions, if a win happened during a fetch, wouldn't it kill the cat popup technically? chances of it happening are pretty slim, but it'd be the same thing as multi-tabbing and having the cat popup on a page you just closed without looking at.
Comment has been collapsed.
Interesting point. So if that's what's happening I could look for the popup when fetching any page and then show it on the current page. Of course I would still need to win something or have someone win something and let me know the class name of the popup, so I can know what to look for.
Comment has been collapsed.
Confirmed win popup
<div class="popup popup--gift-received" style="left: 714.5px; position: absolute; top: 236px; z-index: 9999; opacity: 1; display: block;">
<img src="https://cdn.steamgifts.com/img/winner/animated/1.gif">
<p class="popup__heading"><span class="popup__heading__bold">Congratulations!</span><br>You won a new gift.</p>
<a href="/giveaways/won" class="form__submit-button"><i class="fa fa-arrow-circle-right"></i> View Gift</a>
<p class="popup__actions">
<span class="b-close">Close</span>
</p>
</div>BTW if anyone is curious about the patreon winning gifs the numbers go from 1.gif to 43.gif
Comment has been collapsed.
Quick suggestion - is there also possible to add an "Ended" filter for Giveaway Filters? Would come in handy in pop up situations, train extractions to be precise.
Comment has been collapsed.
This wonderful script (it is) is showing this on points and level, but only when I enter con threads or giveaways page.
And doesn't show the button to enter on main page (ง •̀_•́)ง
Comment has been collapsed.
Any fix for created / won giveaways from looking like this?
Comment has been collapsed.
I thought so too but this is the only script/extension i run in this page (apart from stylish one which i tried to disable and did not help) which makes it even more stranger :\
Comment has been collapsed.
Whitelist/Blacklist Checker now only stores data if the result is either whitelisted or blacklisted. Any other data will be wiped from the storage.
It's nice but what about the current data of people who are not BLed/WLed? Do I have to delete all the WL/BL data in Manage Data section? I would like the script deleted that in case it doesn't do that.
Comment has been collapsed.
That's what
Any other data will be wiped from the storage.
means. Go to the menu and click the button to manage whitelist/blacklist. You'll see it only has whitelist/blacklist data now. :)
Comment has been collapsed.
Ah just when I was about to manually scrub neutral wl checker data you remove all dead weight, nice ^^
(my site load times have deteriorated heavily, need to find some more tweaks, but this helped a little)
Bug:
in the /giveaways/created page an empty column is created ( esgst-giveaway-panel ) even when option "Created/Entered/Won Giveaway Details" is disabled.
Comment has been collapsed.
esgst-giveaway-panel is related to Giveaway Winning Chance/Ratio.
Comment has been collapsed.
Game category tags are all showing up red for me since last update 6.24.1.
Comment has been collapsed.
Active Discussions on top is now in a too tiny window, has sidebar width.
Comment has been collapsed.
Leave giveaway button on the pop-ups has a plus sign :v I think it's an artifact from when you would enter the giveaway from the pop-up.
Comment has been collapsed.
http://store.steampowered.com/app/91310
Works fine for me.
Comment has been collapsed.
OK, for me too but only if I open it in the same tab. And I open external links always in new tabs. :( Can you add support for opening in new tabs?
Comment has been collapsed.
Just hold Ctrl and click the link. I actually plan on removing this feature from this script and creating a separate script that will do that, as the feature is not related to ESGST and would remove the need to make the script run on Steam pages.
Comment has been collapsed.
Just hold Ctrl and click the link.
It doesn't work for me. I just use middle mouse button for it but both the ways do the same (with the same result). I thought there is a listener on steam that helps the script do the redirection there, no matter how or from where I got there. But it seems it relies on SG page. It's odd.
Comment has been collapsed.
It needs to be Ctrl + Left Mouse. Nothing aside from that will work. You have to click the link for it to work.
Comment has been collapsed.
Ok, it works for me, I just didn't wait long enough for the redirection - sorry. Is a problem to add also support for the middle button?
Comment has been collapsed.
Using the regular Hide Giveaway button on a GA page, the heading, with GA info etc., disappears. (Similar to a now fixed bug with the hide single GAs)
Reloading the page fixes the issue again.
Comment has been collapsed.
By regular do you mean the SG one or the one-click one? I think I fixed it if you're talking about the one-click one.
Comment has been collapsed.
Yes, it was the one-click one, just checked with the current version and it is no longer happening.
Thanks :)
Comment has been collapsed.
Is it just me or do GA filters only work for the initial "page" of GAs and then after that it lists GAs that don't conform to the filter and also don't have any of the ESGST features (like "Enter" button, labels, etc.)?
EDIT: Seems to be working now, but it is sporadic. Different filter options seem to work or not work depending on which I select. For instance if I select "Show only" for "Owned" it only works on the first three pages; for the fourth and subsequent pages it just lists all the GAs without any of the ESGST features enabled on each GA.
Firefox console error message:
uncaught exception: unknown (can't convert to string) ESGST.user.js:4175:25
Comment has been collapsed.
You're probably affected by the same Firefox bug that another user had, where some features only work when they want to. Nothing I can do on my end, as far as I know, and Firefox is not my priority at the moment, since the script works perfectly fine on Chrome and I think Opera/Edge as well. Try creating a new Firefox profile and re-installing all add-ons/scripts (that fixed it for the other user).
Comment has been collapsed.
I see, so it is Firefox specific.
After restarting Firefox things do seem to be working. It is probably something to do with low memory and Firefox not being able to handle low memory situations correctly.
Comment has been collapsed.
I have not been affected by the issue even in situations with very little free memory so that shouldn't be a problem.
It's firefox specific, but the reason seems to be a profile corruption of some sort(not caused by ESGST but that it is very sensitive to for some reason), try creating a new profile and using the sync to not loose history/bookmarks/etc.
I did have a bug in a addon 2 years ago that was caused by a corrupted profile and there is no simple way to know that it happened(that i know off,and i did a good amount of googling at the time) other than trying a new profile set up just as the old one was and checking if the error is still present.
Comment has been collapsed.
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.