I upgraded from 23.7 (I think) to 24.2 and all night I have been having the same problem other people have been having; ESGST is loading only sporadically; right now it's not loaded for this page.
In the past I never had any issues like this, I have no idea what could have introduced them. I have not updated Firefox to version 55 yet and haven't installed any new addons.
I well let you know tomorrow if this continues or if it was a one off.
Comment has been collapsed.
Did you try creating a new profile and re-installing all add-ons/scripts? Well, like I said to the other user, I'm not sure there is anything I can do, since it works so sporadically and only affects Firefox. Plus Firefox is not my priority at the moment, so it might take some time until this is fixed.
Comment has been collapsed.
The thing is that it worked just fine till I upgraded ESGST today/yesterday. It seems highly doubtful to me that my profile has become has become corrupted unless that is caused by ESGST (at some point during use), in which case it obviously would only be a temporary fix.
Edit; would I break anything by downgrading to 23.7 to see if that one works?
Comment has been collapsed.
One time I opened Firefox and it was only working when it wanted to. Another time I opened Firefox and it worked fine. The issue is that this appears to be a sporadic bug, so you might think the update is what caused it when it could have been something else completely. And in any case it will be only a temporary fix, since Firefox is not my priority and I don't intend on looking into this anytime soon. By the way, are you on Greasemonkey? Have you tried with Tampermonkey? The other user reported it happened with Tampermonkey as well, but I was quite sure this was a bug related to Greasemonkey after I did a little bit of research, because Greasemonkey is not yet compatible with Firefox 57. But if it truly happens on Tampermonkey as well, that makes me even more confused.
I don't think anything would be broken.
Comment has been collapsed.
the compatibility with FF57 is only relevant if the person is using it (nightly or when it goes to beta or when it gets released in November), but it could be a bug related to e10s aka multi-process or the lack of it, so testing in both situations may shed some light on the origin of the bug
Comment has been collapsed.
and there are some bugs on greasemonkey according to it's github repo, but the main dev isn't fixing most of them because he is doing a rewrite to make it compatible with FF57 because otherwise greasemonkey will not work on FF57 when it gets released. the only reason I'm not using tampermonkey is because it uses way more RAM and CPU for me so I'm sticking to greasemonkey until it gives me trouble.
Comment has been collapsed.
Yes, those bugs are the reason why I thought this was related to Greasemonkey. I know Firefox 57 is not here yet, but maybe the recent versions had some upgrades that are already affecting some features. But if it's also affecting Tampermonkey like another user reported, then it couldn't possibly be related, because Tampermonkey is already compatible with Firefox 57. Anyway, I'm not going to spend time on this bug, I'll wait until Firefox 57 has been released and Greasemonkey has been rewritten to look into it and see if it's still happening.
Comment has been collapsed.
Well, a new day and I downgraded to 23.7 but without the desired result. On this page I do get a mangled warning I am not using the latest version (see screenshot) so at least something of the script is running. No console errors at all though.
I'm gonna grab my laptop and see how/if it's running on there.
Comment has been collapsed.
Writing this on my laptop running 19.7 (and the same version of Firefox as my desktop). ESGST works just fine here. I'm gonna upgrade the few other addons that are out of date and restart Firefox to see if that makes a difference. Then finally I will update ESGST and see what happens.
Comment has been collapsed.
Right now it seems most likely to me that the local storage for whitelist/blacklist is corrupted as I tried to do a check on those a short while ago and it hung on a user a few times. What's the easiest way to empty that when I can't use ESGST?
Comment has been collapsed.
This script uses no local storage. And you could have reported when it hung on a user, that could have been helpful if the bug is related to it. On Greasemonkey the only way is to locate the database on your computer and edit the file manually with an SQLite database editor.
Comment has been collapsed.
I finally had some time and managed to get everything working again but I took the heavy handed approach.
I used this script from the GM_deleteValue page and put it at the very start of the script:
var keys = GM_listValues();
for (var i=0, key=null; key=keys[i]; i++) {
GM_deleteValue(key);
}
That obviously wiped everything from the database and I could have been more surgically and tried to just wipe the whitelist/blacklist part as that was the likely culprit.
Fortunately I still had a JSON backup from 28 July so even the colors are back (re-adding those would have been hell) and everything is fine again.
Is the new "Wipe Storage" button just for bugfixing or is it to remove everything that has been ported to the new system? The changelog is not quite clear on this.
Comment has been collapsed.
Is the new "Wipe Storage" button just for bugfixing or is it to remove everything that has been ported to the new system?
It only uses GM_deleteValue therefore it can not wipe the new local storage, so not for bug fixing just cleaning up after porting to local storage.
Comment has been collapsed.
reference comment
About group loader, I recently found out it seemed working again. But today I noticed that it still have some issues. I doubt it maybe related to some specific groups (its name or ?). You can see the screenshot below: The two giveaways are both whitelist and group type. I am not in any of those groups, and only in the creators' whitelist. The upper one in SS could be loaded successfully and all GAs above it also loaded. But the lower one in SS couldn't be loaded and all GAs above it also failed to load.
Comment has been collapsed.
Oh, just means screenshot, maybe I shouldn't use that. Sorry for the confusion.
Comment has been collapsed.
I'll see if it still happened in th latest version. Because the GAs in the screenshot has ended, I will report if it happens again.
Comment has been collapsed.
By the way, I found the "Game Categories" didn't work anymore after 6.Beta.26.5. I have synced the data (reduced and no CV list), and the console didn't show any errors as well.
Comment has been collapsed.
Yes, I think it's latest version when I upgraded this morning because I notice one of the changes about bundled and unbundled (now are full, reduced and no cv).
Comment has been collapsed.
Is there a esgst_gcCache
data in your localStorage?
Comment has been collapsed.
Did you mean in the directory of greasemonkey or the check the variable in console?
I have checked both. There is no "esgst_gcCache" file in that folder or such variable name in console.
Comment has been collapsed.
localStorage. It's in your browser. It's accessible through the console by localStorage.esgst_gcCache
.
Comment has been collapsed.
Oh, I could see some ESGST related names like esgst_giveaways, esgst_groups, ... But the esgst_gcCache is undefined.
Comment has been collapsed.
I just found the 6.Beta.28.2 fixed that. But there still a little issue that some games showed both FCV and NCV, and some games showed RCV and NCV. Should the three be exclusive?
I know the rating not working for every game, but after I viewed several pages, I didn't see a giveaway showed rating icon. So I am not sure if it really had some problems.
Comment has been collapsed.
FCV and NCV should be exclusive, I'll fix that later, but RCV and NCV should not be exclusive, because a game is added to those lists in different occasions.
Comment has been collapsed.
Yes, maybe they were added in different time, but if a game is both in RCV and NCV, it should be considered as NCV, right?
Comment has been collapsed.
If you hover over the categories, it will show RCV since ... and NCV since ... So yes, it is ultimately NCV, but some people might be interested in knowing the date when it was only RCV. I know I personally like looking at that data to see the time frame from RCV to NCV and also checking to which a certain giveaway belongs (depending on the date that the giveaway was created). But I can add an option to show only NCV if the game is both, there's no problem in that. :)
Comment has been collapsed.
If that is the case, then it's no problem. I previously thought they are just convenient marks to let people know if a game has ever been in a bundle or free. I didn't notice that the date would also showed then you hover the icon.
Comment has been collapsed.
What I mean is, the rating icon originally won't work for every game. In the GA list, I saw some have that icon and some didn't in previous version, but now I can't find any in several page. So I think it probably have some issues loading the rating data, but I am not very sure of that.
Comment has been collapsed.
If the store page of the game is blocked by an age check or a mature content check, the rating cannot be retrieved unless you are logged in and/or you have dismissed those checks currently. Could it be that? If you click on the link to go to the store page of the games that are missing the rating, can you access the page normally? Or maybe the games have not enough rating? You cannot see a single rating?
Comment has been collapsed.
As you can see the screenshot below. I just click the home page of SG and there are no rating icons on the two games (One Piece Burning Blood and War for the Overlord) in the red rectangles. I tried to click the Steam link and those two didn't have any age check or something like that.
Comment has been collapsed.
That's strange. Is your version the same as mine (v6.Beta.28.3)? Maybe my database screwed up again. =.=a
I upgraded from 24.x -> 25.x -> 26.x -> 28.x
Comment has been collapsed.
Same version, maybe double check your settings to see if everything you want is enabled.
Comment has been collapsed.
Yes, I just check the setting and the [SG] - rating is on.
Comment has been collapsed.
According to your screenshot there are no ratings on any game yet you highlighted 2 games only ???
Comment has been collapsed.
I just choose two for examples. One of the other two GA is only a soundtrack DLC, and there are not enough review for rating.
Comment has been collapsed.
I just tried restore my backup data (v6.Beta.25.5), downgraded to that version and the rating works again. Then I upgrade to the last commit version of every day one by one. When I upgraded to the v6.Beta.26.8 on Aug 15, 2017, the rating function was broken. So I tried v6.Beta.26.2, no luck. I saw the change log in v6.Beta.26.8 mentioned "Fixed a bug that was not showing "Rating" category in Game Categories.", but not working for me. And the following version also doesn't help.
Is there anything I could try to find out what's happened and fix this?
Comment has been collapsed.
Did you do this?
Only way I can think of is to debug the script to try to find the source. You could start by going to the line that says
elements = responseHtml.getElementsByClassName(`user_reviews_summary_row`);
and add
console.log(elements);
at the end of it, then check if anything prints in the console.
Comment has been collapsed.
Did you do this?
Actually, at that time I reply I didn't find the esgst_gcCache. So I can't see the content.
And I do insert the console.log into that function getGcCategories(). I found one possible issue is although the parameters of request url have the "l=en", I could see the data printed in console showed some Chinese wording like 好評 (Positive). The function try to find the review pattern matched in "data-store-tooltip" and I found that attribute showed the following content:
"<div class="user_reviews_summary_row" data-store-tooltip="13 篇使用者評論中有 100% 篇給予該遊戲好評。" itemprop="aggregateRating" itemscope="" itemtype="http://schema.org/AggregateRating"><div class="subtitle column">整體:</div>..........
Maybe it didn't find a match because of the language. When I open the steam web page and change the language to English, I could see some of the games showed rating info successfully. But another strange thing is, the console didn't print much when I reload the home page (maybe it will prevent to reload the info again if it is in the cache. But if the cache has the data, it should show the rating info and it didn't).
------- update -------
By the way, I just found I could see the esgst_gcCache, and it looks like:
"{"apps":{"2280":{"achievements":0,"dlc":0,"earlyAccess":0,"genres":"Action","linux":0,"mac":0,"multiplayer":0,"name":"Ultimate Doom","price":5,"rating":"","ratingType":"","removed":0,"steamCloud":1,"tags":"90 年代, 可模組化, 多人, 好評原聲帶, 困難, 快節奏, 科幻, 射擊, 恐怖, 假3D, 動作, 第一人稱射擊, 第一人稱視角, 喪屍, 單人, 惡魔, 經典, 暴力, 懷舊, Gore","tradingCards":0,"lastCheck":1503717187230},"4000":{"achievements":1,"dlc":0,"earlyAccess":0,"genres":"Indie, Simulation","linux":1,"mac":1,"multiplayer":1,"name":"Garry's Mod","price":10,"rating":"","ratingType":"","removed":0,"steamCloud":1,"tags":"大型多人連線, 可模組化, 合作, 多人, 沙盒, 物理, 冒險, 建造, 射擊, 動作, 動畫和模型製作, 第一人稱射擊, 第一人稱視角, 單人, 搞笑, 模組, 模擬, 線上合作, 獨立, 歡樂","tradingCards":1,"lastCheck":1503290513740},.... "9050":{"achievements":0,"dlc":0,"earlyAccess":0,"genres":"Action","linux":0,"mac":0,"multiplayer":1,"name":"DOOM 3","price":5,"rating":"88% (1847)","ratingType":"Positive","removed":0,"steamCloud":1,"tags":"Action, Adventure, Atmospheric, Classic, Co-op, Dark, Demons, First-Person, FPS, Futuristic, Gore, Horror, Mars, Moddable, Multiplayer, Sci-fi, Shooter, Singleplayer, Survival Horror, Zombies","tradingCards":0,"lastCheck":1503719859663},
The one with Chinese tags didn't have the rating value, and the one with English tags did.
As I remove the gcCache and reload the page, I could see most of the rating info.
Comment has been collapsed.
Ever since v6.Beta.31.2 rating should show fine, is this still happening?
Edit: Ahh, in Chinese the percentage comes after the review count. I'll fix it later.
Comment has been collapsed.
I manually remove the original gcCache containing the Chinese and it could showed correctly now. But I have another question:
If the script try to load the games info (the data store in gcCache) and something failed like this issue I encountered (parsing rating info failed, or blocked by the age check), would it try to reload sometimes thereafter? In my case, I need to manually remove the whole cache, so the script would try to load them again since it didn't find the data containing wrong info in gcCache If it could find a game info in gcCache, it seemed not to do so even the data containing some wrong info.
Comment has been collapsed.
Currently it only tries again after 1 week, I'll make some changes to it later.
Comment has been collapsed.
OK, Thanks for your help~ :)
By the way, I am curious about the new sub-option in
Giveaways -> [SG]- Enter/Leave Giveaway Button -> 1.[SG] - Only enable for popups.
I wonder how it works? I also can't find the description in GitHub.
Comment has been collapsed.
Quick question regarding the unsent gifts Sender.
I am currently using it (or trying to) to send the keys from a train I created. At first it was working fine, up until the point where i manually cancelled it, because i remembered that i wanted to check for a few games first if the winner doesn't have it already (packages). There also was 1 rule breaker so I create a reroll ticket and tried to restart again after that.
Now the script is stuck at said rule breaker for 15min+ and nothing else seems to happen. I get no errors on the console and reloaded and starting over doesn't help either. Any idea what the problem is and how to fix it?
Comment has been collapsed.
I'll look into it later. The script is supposed to ignore rerolled winners, there might be a bug there.
Comment has been collapsed.
Check for rules? Yes, the higher the number of games the user has won the longer it takes to check. It simply uses SGTools to check, so it's the same time that it takes to check there.
Comment has been collapsed.
yeah the rules check.
I figured you'd be using SGTools in some way that's why I wondered why I took so long sometimes.
Having said that, it seems so far i had only checked users with a low win number and never noticed that SGTools is actually performing the check live when calling the page and can take some time too.
That explains it then :)
Comment has been collapsed.
Sorry for the late fix, but this should be fixed now.
Comment has been collapsed.
Just wanted to drop a "thank you" here -- finally disabled nearly every feature of SG++ today, since they're all redundant and I'm finally feeling comfortable trusting ESGST with most everything. (I take a long time to convert, nothing wrong on your end. :)) Also, things run a lot faster now that I've disabled all the double-duty. My only holdover now is some user tags from SG++ that I've slowly been copying over. I'm glad to see that exporting data like that is super easy in ESGST should the worst happen though. If I had any complaints/requests, it might be about the bookmarked giveaways -- the interface for that just isn't very fast compared to my previously-used bookmarks script, which would also (optionally) keep bookmarks around after the GA ended. But really... there's a ton of work done in this script of yours, and so, very much... THANK YOU!!! :)
[late edit] Nearly all redundant... had to switch "Hide Entered" filter back on on SG++... looks like I'll be hanging onto that script a bit longer! [/late edit]
Comment has been collapsed.
You're welcome!
Giveaway Bookmarks cannot be made faster at the moment, since the giveaways are retrieved in real time for accurate number of entries/comments. I assume the other script uses cache. The idea of keeping giveaways after they ended has been suggested and I agreed to implement it, just haven't had the time.
Comment has been collapsed.
p.s.
Color blacklisted users instead of adding a heart icon next to their username.
(I think the word here might be not quite right. :D)
Comment has been collapsed.
As to your late edit, this script also has an entered filter. You can find it in the feature Giveaway Filters.
Edit: Ah, and I'm even more late with the reply.
Comment has been collapsed.
Added the option to keep ended giveaways in the list to Giveaway Bookmarks.
Comment has been collapsed.
Latest version isnt loading for me. (firefox/tampermoney V 6.Beta.25.1 )
ERROR: Execution of script 'ESGST' failed! JSON.parse: unexpected character at line 1 column 1 of the JSON data search:4:343
loadEsgst@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 3 > Function:830:41
tms_685eba42_0d7c_48b2_bbc2_dacc81bd76ab/<@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 3 > Function:411:5
tms_685eba42_0d7c_48b2_bbc2_dacc81bd76ab@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 3 > Function:408:2
g</<@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44:2:385
anonymous/<@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 3 > Function:4:1
anonymous/<@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 3 > Function:3:55
anonymous@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 3 > Function:3:2
g</<@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44:2:385
E_c@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44:3:209
da@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 1 > Function:60:417
create@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 1 > Function:69:26
f@https://www.steamgifts.com/discussion/TDyzv/userscript-esgst-v6beta251-new-features-search-magnifying-glass-button/search?page=44 line 1 > Function:16:235
Comment has been collapsed.
+1 with Chrome and tampermonkey (on 2 PCs)
ERROR: Execution of script 'ESGST' failed! Failed to set the 'esgst_entries' property on 'Storage': Setting the value of 'esgst_entries' exceeded the quota.
(anonymous)
(anonymous)
(anonymous)
(anonymous)
E_c
E
create
e
(unknown) Error: Failed to set the 'esgst_entries' property on 'Storage': Setting the value of 'esgst_entries' exceeded the quota.
at loadEsgst (eval at E_c (:3:221), <anonymous>:788:52)
at eval (eval at E_c (:3:221), <anonymous>:410:5)
at Window.tms_5a3b9a55_7416_4fea_bce2_539c4ced4930 (eval at E_c (:3:221), <anonymous>:31022:3)
at <anonymous>:2:398
at eval (eval at E_c (:3:221), <anonymous>:3:1)
at eval (eval at E_c (:3:221), <anonymous>:4:3)
at Object.eval (eval at E_c (:3:221), <anonymous>:31023:6)
at <anonymous>:2:398
at Object.E_c (<anonymous>:3:219)
at E (eval at exec_fn (:1:108), <anonymous>:60:467)
Comment has been collapsed.
:'(
SG without ESGST is :'(
Hitting me, too. I'm honestly a bit surprised at the lack of posts about it.
Comment has been collapsed.
yeah so much missing functionality, on the other hand much faster too (at least for me ):P
I went back to the old version, so it is still possible to use ESGST until this gets resolved klick
But yea, it strange that no one else seems to have these problems. Btw. i had the same problems both with .25 and .25.1 .
Edit;
and since it just updated, same for 25.2 and 25.3
Comment has been collapsed.
localStorage is limited. I believe the maximum size you can store is 5MB or 10MB in some browsers. If you use other SG scripts that use localStorage, you will have to delete the storage of those scripts to free some space. If you don't, then it looks like you have too much data and you'll probably have to delete some.
Comment has been collapsed.
You can use this to let you know the size currently used by your localStorage and how much each property is taking:
var _lsTotal = 0, _xLen, _x;
for (_x in localStorage) {
_xLen = ((localStorage[_x].length + _x.length) * 2);
_lsTotal += _xLen;
console.log(_x.substr(0, 50) + " = " + (_xLen / 1024).toFixed(2) + " KB");
}
console.log("Total = " + (_lsTotal / 1024).toFixed(2) + " KB");
Just enter it on the console.
Comment has been collapsed.
Wow, that's a lot, how were you even able to navigate? I believe a storage that size would constantly freeze the browser. That's all from user data? But it shouldn't affect anything though, user data is not stored in the localStorage.
Comment has been collapsed.
had to use the old version again for re-import, here is the output
APIKey = 0.07 KB
VM891:5 RCE-StoreMethod = 0.04 KB
VM891:5 SGIgnore-SpecificIgnore-Discussions = 9.38 KB
VM891:5 SGIgnore-SpecificIgnore-Giveaways = 1.79 KB
VM891:5 SteamID64 = 0.05 KB
VM891:5 esgst_discussions = 8529.96 KB
VM891:5 esgst_entries = 0.03 KB
VM891:5 esgst_giveaways = 463.80 KB
VM891:5 esgst_groups = 48.26 KB
VM891:5 esgst_replies = 0.03 KB
VM891:5 esgst_rerolls = 0.03 KB
VM891:5 esgst_templates = 1.69 KB
VM891:5 esgst_tickets = 3.08 KB
VM891:5 esgst_winners = 0.19 KB
VM891:5 google_experiment_mod = 0.05 KB
VM891:7 Total = 9058.44 KB
Most is coming from the comment tracker might have to reset this
Edit:
Hm interesting , now the update works but i seem to loose some data, t least my bookmarks are gone.
Comment has been collapsed.
The limit is probably 10MB then. I'll see if I can reduce the size taken by Comment Tracker, but you could also try manually deleting old tracked discussions (although that would take a bit of work). The simplified version of Comment Tracker takes less space too, if you're not that concerned about keeping close track of all comments (it simply lets you know how many new comments have been added since the last time you visited a discussion).
Comment has been collapsed.
If you had not previously updated to 25.0 there was a bug that could replace giveaway data when updating to 25.2. I fixed it in 25.5, you can get your data back by deleting esgst_giveaways
, esgst_discussions
and esgst_tickets
from localStorage (if you haven't wiped the storage through the settings menu). Should probably export first before doing that just in case.
Comment has been collapsed.
After much back and forth i don't seem to be able to get a working version without data loss.
I went back to 24.2 again deleted all comment data and it was working fine then.
Update to 25.5 and now i get the following error:
Edit:
Nevermind that. i deleted tall script data manually via tampermonkey and did a fresh import. Seems to be working now.
Out of curiosity, when I now do a readout of the storage data, the biggest entry is esgst_giveaways = 2161.80 KB
. Which option does this dataset belong to exactly?
Comment has been collapsed.
esgst_giveaways
is related to the "Giveaways" option in the manage data menu. But this data includes bookmarked giveaways data, hidden giveaways data and other data related to giveaways, so I wouldn't recommend deleting it at the moment. I'll add an option later to delete only comment data from the giveaways data.
Comment has been collapsed.
I'm going to revamp all import/export/delete tools, just need some time. :)
Comment has been collapsed.
Ok, now I'm stuck.
The way managed to update on my other PC doesn't seem to work here...
Whenever I update to 25.x i loose all giveaway data(perhaps more, but the other stuff doesn't matter that much) and re-importing doesn't work, I always get an error when trying to.
How do i delete esgst_giveaways, ... from local storage? Have tried more or less everything else without success.
Comment has been collapsed.
You have to update to the latest version, otherwise your data will continue to be overwritten. Just open the localStorage and delete it. You can google how to access the localStorage.
Comment has been collapsed.
I'm having a hard time with this. I misinterpreted MANotorer's instructions. At first I thought you two meant to export my Chrome profile. Did that, no change. Then I thought you meant TamperMonkey. Did that, no help. Then I finally found where it is in ESGST. Did that, no help.
I've never had comment tracker on. I've seen other comments talking about local storage, but that's outside my knowledge base. Can you dumb it down a step? Thank you.
Comment has been collapsed.
Are you saying I have to delete my entire user profile to fix it?
Comment has been collapsed.
The Reset is temporary, but yes. I wiped all Script data (after exporting) and re-imported after without the comment tracker data since it took up too much space.
Here is how i did the update on the PC where i had problem importing the data from the old version after updating to the newest:
First Wiping the data and re.importing without comment tracker data, so the script won't stop working after the update, and then update to the new version.
At this point all was working fine but i didn't have access to the bookmarked GAs. They can be restore like this.
After having done that i have no more problems.
Comment has been collapsed.
Does clicking on the error lead you to a more specific line?
Comment has been collapsed.
the only thing it givees me is this
ERROR: Execution of script 'ESGST' failed! JSON.parse: unexpected character at line 1 column 1 of the JSON data search:4:343
anonymous/< https://www.steamgifts.com/giveaways/search:4:343
anonymous/< https://www.steamgifts.com/giveaways/search:3:55
anonymous https://www.steamgifts.com/giveaways/search:3:2
g</< https://www.steamgifts.com/giveaways/search:2:385
E_c https://www.steamgifts.com/giveaways/search:3:209
da https://www.steamgifts.com/giveaways/search:62:417
create https://www.steamgifts.com/giveaways/search:71:26
f https://www.steamgifts.com/giveaways/search:18:235
doesnt look that helpful to me.
Comment has been collapsed.
Can you check your localStorage for these properties and tell me which ones are missing:
Comment has been collapsed.
None of them
esgst_groups = 15.97 KB
esgst_tickets = 0.03 KB
esgst_entries = 26.29 KB
esgst_replies = 0.03 KB
esgst_giveaways = 0.03 KB
esgst_discussions = 0.04 KB
esgst_templates = 0.03 KB
esgst_rerolls = 0.04 KB
esgst_winners = 0.03 KB
Comment has been collapsed.
Well, if the console doesn't lead you to a direct line I don't know what's happening then. On Chrome, the errors have a link in the top right corner of the error that when clicked brings you to the exact line of the script that's throwing the error. Sometimes you have to reload the page with the console open for it to work properly. I assume it might be similar on Firefox.
Comment has been collapsed.
pretty sure this is the line causing the problem
loadEsgst@https://www.steamgifts.com/ line 3 > Function:823:45
as the 3rd line of the loadEsgst function is the settings Json parse
Comment has been collapsed.
Can you export your settings and see if there are any odd characters at the beginning?
Comment has been collapsed.
Its somthing betwenn lines 394 and 490 causing the issue.
i'll try to narrow it down a bit more for you.
Comment has been collapsed.
Ok so i found two things.
These lines cause the script not to load
esgst.giveaways = localStorage.esgst_giveaways;
esgst.rerolls = localStorage.esgst_rerolls;
esgst.groups = localStorage.esgst_groups;
esgst.winners = localStorage.esgst_winners;
Adding This before each one allows the scrip to load.
if (!localStorage.esgst_giveaways) {
localStorage.esgst_giveaways = GM_getValue(giveaways
);
}
if (!localStorage.esgst_groups) {
localStorage.esgst_groups = GM_getValue(groups
);
}
if (!localStorage.esgst_rerolls) {
localStorage.esgst_rerolls = GM_getValue(rerolls
);
}
if (!localStorage.esgst_winners) {
localStorage.esgst_winners = GM_getValue(winners
);
}
And if these lines are in the script - then i cant get to work at all
else {
esgst.rerolls = JSON.parse(esgst.rerolls);
if (typeof esgst.rerolls === string
) {
localStorage.esgst_rerolls = esgst.rerolls;
esgst.rerolls = JSON.parse(esgst.rerolls);
}
}
and
else {
esgst.winners = JSON.parse(esgst.winners);
if (typeof esgst.winners === string
) {
localStorage.esgst_winners = esgst.winners;
esgst.winners = JSON.parse(esgst.winners);
}
}
Comment has been collapsed.
Can you take a screenshot of your localStorage? Those lines should not cause any errors whatsoever.
Comment has been collapsed.
Are you sure in 25.4? There was a bug in 25.2 or 25.3, but has been fixed. If you haven't wiped your storage through the settings menu, try deleting esgst_discussions
and esgst_tickets
in your localStorage.
Comment has been collapsed.
Check for console errors.
Try googling how to open the localStorage on Firefox, I only know for Chrome. Should be somewhere in the console panel.
Comment has been collapsed.
I saw it, but updating from 25.1 to 25.4 should have worked just fine.
Comment has been collapsed.
Then yeah, you're probably affected by the bug. Just open the localStorage, delete esgst_discussions
and esgst_tickets
and it should go back to normal (if you haven't wiped your storage).
Comment has been collapsed.
You clicked on "Wipe Storage" in the settings menu after updating to 25.2? 25.2 was released an hour ago, if you wiped the storage before that, your data is still there, but if you wiped the storage in the past hour or so, unfortunately your data is gone if you didn't export it.
Comment has been collapsed.
Ok, glad to hear it. Sorry about the data loss, but at least it's not an important type of data (you can always mark the discussions as read again).
Comment has been collapsed.
Hope that now that most of the data has been moved to localStorage the profile corruption thing doesn't happen as often, since the use of GM_setValue/GM_getValue has been decreased.
Comment has been collapsed.
Do you get any errors on the console the moment you click the button to mark the comments as read?
Comment has been collapsed.
Can you move the "mark all comments as read" thing to the bottom of the page or make that an option? Also, I use the checkmark in the discussion list to mark an entire thread as "not interested (anymore)" so that it fades out, but this flag also gets tripped by visiting a thread, even though I might be interested in new comments or updates to the main post. Can you make it so new comments will unfade threads that I didn't explicitly hit the checkmark for or just not auto-fade them in the first place with an option to handle that exclusively manually, or is there a setting for that already that I missed?
Comment has been collapsed.
Well, from a usability standpoint, "mark all" is the main one that seems better at the bottom, but I could see "go to first unread" being handy at the top or the bottom (and I don't know that I personally will ever have much use for the "mark all unread" button so I don't really have an opinion on that). Even if you just moved one button, it's going to render the rest of that horizontal space empty, so you might as well just move that whole bar, no? That would also result in the display of the number of comments right near the number of "results", which are two different numbers because the former is a count of all the comments while the latter only includes replies to the main post (I sometimes check both to remind myself of which is which). So maybe just include an option to display that whole bar at the top, bottom, or both?
Comment has been collapsed.
Hm, I don't know, I don't like the idea of putting the bar at the bottom and it wouldn't look good. It's a heading bar, so it should be at the top. Why not use Fixed Main Page Heading?
Comment has been collapsed.
Well, it's your tool, but if you're willing to just move that one button (or all three), am I not correct in that you'd just be leaving the rest of that horizontal space empty, which just seems like a waste when I think there's some potential utility to it at the top and/or bottom. After all, the bottom of the page is where the "results" # and the page navigation stuff is -- useful header info/controls can just as easily be conceived of as a useful footer instead. To me, the Fixed Main Page Heading is a waste of space in this case because now it's always taking up a chunk of space throughout the entire body of the page (i.e., most of the page) even though it seems to me that it's primarily/only desirable at the top and/or bottom. Whatever you do with it, I see that you made the other change I requested, so it now occurs to me that it would be nice to have another button in that bar for the "visited thread" checkmark. Less importantly, it now also seems to me that it might be nice to have all the options/info shown in the discussion list available within each thread itself, which would then just mean also parenthetically displaying the number of new comments alongside the total.
Comment has been collapsed.
Problem is I don't really want to move anything to the bottom, it would look way too ugly. The pagination is made of text/links, so it looks good at the bottom, adding buttons at the bottom of the page would look horrible. Fixed Main Page Heading only takes 59px of the height and has all the information you can use from the script easily accessible, so I'd hardly call it a "waste of space". Perhaps you should just use the "Home" key to get you to the top where you can access the heading.
Comment has been collapsed.
Well I'm only asking for the option to move it and in fact would probably enable it to appear as a header and footer, given the choice, but maybe I'm pretty much alone in finding that to be a kind of significant usability improvement -- I'm actually surprised no-one else has requested this already since it just seems really natural to me that you would finish reading a page and then, finding yourself at the bottom, would just want to click "mark all read" before possibly clicking to go to the next page. I have been sometimes hitting 'Home' to go back to the top as you've suggested, but it's less than ideal, especially if the initial post is lengthy, to then navigate down to the header before going back to the bottom to hit the page links. Maybe many others who find themselves in this situation are just using the Fixed Main Page Heading, but as I said, it's a "waste of space" to me here only because it's then a constant presence that is of little or no use to me anywhere but the top and/or bottom. Again, maybe I'm being weird in wanting this and I certainly can't complain about a very useful free tool that you continue to put a lot of time and effort into, so you have my sincere thanks whatever you choose to do (or not do, as the case may be).
Comment has been collapsed.
Even as an option, I wouldn't feel comfortable having it on the script because it would look too bad and completely out of place, so I don't think I'll be doing it. But yeah, the majority of users probably have Fixed Main Page Heading enabled, since most features are injected in the heading and therefore easier to access at any point.
But I think a suggestion by another user could make this situation more pleasant for you - they suggested to add a second button below the comments that would act as "mark all comments until here as read". And I'm going to implement that, so you could take advantage of it by using it on the last comment of the page to mark all comments in the page as read.
Comment has been collapsed.
If by header you mean the actual header (where the ESGST menu appears), that would look awful. But if you're talking about the heading with the title of the thread, sure, I can add that.
Comment has been collapsed.
I was busy earlier but have updated now -- the "mark all comments" is as expected but what I wanted instead of a discussion filter was just the checkmark functionality made available within each thread to mark it as visited and fade its title. I don't know how you feel about that or if you had other requests for a filter, but that's my two cents anyway.
Comment has been collapsed.
I've added the checkmark functionality as well, although it doesn't fade the title currently. The filter feature is not related, it's to hide discussions.
Comment has been collapsed.
Added the button to mark all comments until a certain comment as read.
Comment has been collapsed.
hmm.. i haven't been following the changes at all recently, but i got this error now>
(unknown) ERROR: Execution of script 'ESGST' failed! Failed to set the 'esgst_discussions' property on 'Storage': Setting the value of 'esgst_discussions' exceeded the quota.
edit: from the looks of it, i got no choice but to delete my discussion storage and start over till it happens again?
Comment has been collapsed.
Do you have data from other scripts in your localStorage? This piece of code can give you details about what's in your localStorage and how much each data is using:
var _lsTotal = 0, _xLen, _x;
for (_x in localStorage) {
_xLen = ((localStorage[_x].length + _x.length) * 2);
_lsTotal += _xLen;
console.log(_x.substr(0, 50) + " = " + (_xLen / 1024).toFixed(2) + " KB");
}
console.log("Total = " + (_lsTotal / 1024).toFixed(2) + " KB");
Just enter it on the console.
Comment has been collapsed.
Hmm, yeah, then you'll probably have to delete your esgst_discussions
data or manually trim it by removing some old discussions that are no longer important to keep track of. If you export your discussions data, does the size exceed 3MB? I'll try to reduce the size taken by Comment Tracker data later (maybe I could sacrifice removing the feature's ability to detect comment edits), but with the data moving to localStorage I'm afraid I'll have to set some limits to prevent the storage from exceeding its quota.
Comment has been collapsed.
You could try downgrading to a version prior to v25.2, or commenting out the line that's throwing the error, from
localStorage.esgst_discussions = JSON.stringify(comments.discussions);
to
//localStorage.esgst_discussions = JSON.stringify(comments.discussions);
Comment has been collapsed.
Yeah, to export the discussions only way is to downgrade or export through Tampermonkey, as the current version will export from the localStorage.
Comment has been collapsed.
If you still have the discussion data exported we could try to see how much we could reduce it.
Comment has been collapsed.
btw, performance is 10000000x better now! ^^
i can't even purposely crash the browser with a few dozen SG tabs like i easily could before. =)
edit: it plays well with imgur & enhanced steam once again too. :D
(i knew that data was just to much and it was causing those weird issues)
Comment has been collapsed.
I'm going to be experimenting with Google Sheets once again soon to keep Game Categories and Giveaway Groups Loader data, so this data doesn't need to be cached client-side, saving even more data size.
Comment has been collapsed.
the wipe button on settings menu throws this error>
Uncaught SyntaxError: Unexpected token u in JSON at position 0
at JSON.parse (<anonymous>)
at eval (eval at E_c (:3:221), <anonymous>:24916:37)
at set.toggle (eval at E_c (:3:221), <anonymous>:4867:17)
probably due to the way i removed the data already, but i thought i'd use it to clean up whatever might be leftover.
Comment has been collapsed.
Ah, missed this. Yeah, since you removed the data, there's no need to click on the button, but I'll fix the bug later.
Comment has been collapsed.
just tried the latest updates (26.0) revamped export (select all), and it throws the same error as the wipe button. probably related to the same reason, but it seems it's already interfering rather than a future update like i was just predicting. ;)
no rush on it, just another fyi ^^
Comment has been collapsed.
seems so, thank you much! =)
however....
i noticed an error on the /messages page.
VM175:20996 Uncaught TypeError: Cannot convert undefined or null to object
at checkCtComments (eval at E_c (:3:221), <anonymous>:20996:65)
at Window.eval (eval at E_c (:3:221), <anonymous>:20966:17)
at <anonymous>:2:398
at e.string.k.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:54:352)
(unknown side effects)
Comment has been collapsed.
Does clicking the error lead you to an exact line on the script? I hate how the number line is never accurate in the console. :/
Comment has been collapsed.
Ah, I have an idea what it could be. Can you check if any of these properties are null or undefined in your localStorage:
esgst_giveaways
esgst_tickets
Comment has been collapsed.
On Chrome you can open the console, then on the heading there should be a tab called "Application". There you will find the localStorage.
Comment has been collapsed.
I think I found the cause, will push an update in a few minutes.
Comment has been collapsed.
Pushing small updates helps me keep better track of things, but I'm indeed currently testing something else that I'll add with the next update. :)
Comment has been collapsed.
it changed it to a slightly more specific error:
Uncaught TypeError: Cannot read property 'zr3sI76' of undefined
at checkCtComments (eval at E_c (:3:221), <anonymous>:21064:91)
at Window.eval (eval at E_c (:3:221), <anonymous>:21024:17)
at <anonymous>:2:398
at e.string.k.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:55:352)
edit: side effect = no eye icon to mark as esgst read.
Comment has been collapsed.
No, but I think it would be a bad idea to try to expand the quota, because large storage sizes have proven to slow down the browser and consume too much memory, so it's better to keep it under the localStorage limit and just wipe old stuff from time to time (I'm thinking stuff older than 1 month). localStorage is also simpler to use.
Comment has been collapsed.
it works in a different way relative to localstorage or GM_*value, it's more like a database so the size that people have been reporting wouldn't be a problem, but it would involve a major rewrite and so may not be the best way to do it.
wiping old stuff may be a problem to the comment tracker feature, as it would undo the read status of old comments, making it kinda useless to me at least
Comment has been collapsed.
Well, you can't expect to keep track of all discussions ever made, there's no storage enough for that, so why waste space with discussions that are old and no longer active?
Comment has been collapsed.
well i don't keep track of that many discussions(the discussion storage is at 2.1MB at the moment). if it doesn't unread comments from my highlighted threads i can work around any time based deletion to my satisfaction, specially as un-highlight them when they are not relevant anymore
Comment has been collapsed.
just fyi, i did notice the initial "wipe data" update, and everything at that point seemed to work fine. so i exported all scripts+data via TM and then did the wipe data button back on that update. idk if an update since then goofed it, or it was still reading the data prior to the wipe.
so in my current state i have none of the old data, but i am capable of rolling back to get it.
Comment has been collapsed.
The wipe button from v25.0 only wiped the storages that were moved in that update. Comment Tracker storage was only moved in v25.2, so if you haven't used the button a second time since that version, your data is still there.
Also, just a reminder that with the storage being moved to localStorage, that data will no longer be backed up through Tampermonkey, it has to be exported through the script's settings menu.
Comment has been collapsed.
Sorry, I don't quite get this. Couldn't you use Giveaway Filters?
Comment has been collapsed.
rafaelgs18: feature request, on pages of groups (for example https://www.steamgifts.com/group/mfUoP/playing-appreciated), i get listed games that i already own, could there be an option to hide them like it happens on main giveaways page? maybe this is steamgifts side bug/feature?!
Comment has been collapsed.
Works fine for me, check console for errors. Also be aware that if the page is too small, the sidebar won't be fixed.
Comment has been collapsed.
Can anyone help me with this? (My comment is a reply.) I've tried more things than mentioned in that comment and I'm stuck. You're welcome to add me on Steam if you think you can help. Thank you in advance.
Comment has been collapsed.
That's something I haven't tried. Will likely do so tonight. Thanks for the suggestion.
Comment has been collapsed.
I can't upgrade to v25. Stuck on 24. Any time I try to update, it just doesn't load. I've tried a number of things separately, upgrade to 25, then have to downgrade.
Comment has been collapsed.
ERROR: Execution of script 'ESGST' failed! Failed to set the 'esgst_replies' property on 'Storage': Setting the value of 'esgst_replies' exceeded the quota.
I don't know where to find Storage or what to do when I get there.
Thank you for your help.
Comment has been collapsed.
Try updating to v26.0, I did something that should reduce the size taken by Comment Tracker.
If the error still happens on v26.0, run this code in the console and post the output here:
var _lsTotal = 0, _xLen, _x;
for (_x in localStorage) {
_xLen = ((localStorage[_x].length + _x.length) * 2);
_lsTotal += _xLen;
console.log(_x.substr(0, 50) + " = " + (_xLen / 1024).toFixed(2) + " KB");
}
console.log("Total = " + (_lsTotal / 1024).toFixed(2) + " KB");
Comment has been collapsed.
SGv2 Dark Colors = 15.79 KB
VM79:5 google_experiment_mod = 0.05 KB
VM79:5 group_cache = 0.03 KB
VM79:5 sgrating_ratings = 318.59 KB
VM79:5 sgrating_ratingsid = 13.14 KB
VM79:5 tag_cache = 9732.02 KB
VM79:7 Total = 10240.00 KB
Above that, there are hundreds of lines of PUNK_CACHED, PUNK_CACHE, and PUNK_LAST_CACHED entries. I tried copying them, but it froze the tab and I imagine they're not helpful.
Comment has been collapsed.
tag_cache
appears to be your problem. If you use another SG script that stores here, you cannot use ESGST unless you delete the other script's data.
To delete something from localStorage, google how to find it in your browser, since it's a bit different for each browser.
Comment has been collapsed.
Sweet jeebus, that worked. Took a while to find the proper syntax (probably poor search terms), but I eventually found it.
The script that I had that used it had been disabled for ages, but the value never got deleted.
Thank you again.
Comment has been collapsed.
I realize now that the answer was posted elsewhere, but until now none of it meant anything. I learned a couple things today.
Comment has been collapsed.
I'm having a problem upgrading from 25.5.
When I upgrade, ESGST doesn't get loaded and there are no errors in the console. I found that deleting "esgst_discussions" from local storage fixes it, in that ESGST loads now but on a new reload it's gone and "esgst_discussions" is back in local storage with an "undefined". Any idea how to fix this?
Comment has been collapsed.
No CV and Reduced CV categories "tags" are being duplicated
also got those errors:
O consumo da memória will-change está muito alto. O limite é a área de superfície do documento multiplicada por 3 (1090375 px). Todas as ocorrências will-change do documento acima do limite serão ignoradas. ESGST.user.js:5153:8
related to fixed sidebar i think
TypeError: can't access dead object ESGST.user.js:24384:13
goes to this line:
panel = games[j].container.getElementsByClassName(`esgst-gc-panel`)[0];
Comment has been collapsed.
They're working fine for me, can you give more details? Where it happens, etc...
Comment has been collapsed.
I had just done a ESGST sync after updating the script to the latest version, it happens every place where those "tags" appear it seems(main page, decrypted popup, bookmarks)
FF 55.0.1 + GM
Just did another sync to see if it fixes itself to no vail.
Comment has been collapsed.
And it only duplicates Reduced CV/No CV? If you enable Full CV, does that one get duplicated as well?
Comment has been collapsed.
Can you export your settings and look for gc_categories
? What are the values?
Comment has been collapsed.
Here are mine since i have also the same issue:
"gc_categories":["gc_gi","gc_r","gc_fcv","gc_rcv","gc_ncv","gc_fcv","gc_rcv","gc_ncv","gc_h","gc_i","gc_o","gc_w","gc_a","gc_mp","gc_sc","gc_tc","gc_l","gc_m","gc_ea","gc_rm","gc_dlc","gc_p","gc_g"],"gc_fcv_color":"#ffffff","gc_rcv_color":"#ffffff","gc_ncv_color":"#ffffff","gc_fcv_bgColor":"#f5bb0a","gc_rcv_bgColor":"#641e16","gc_ncv_bgColor":"#641e16","gc_fcv_sg":true,"gc_rcv_sg":false,"gc_ncv_sg":true,"syncNoCvGames":true,"syncReducedCvGames":true}
Happens with all 3, export is for full and no CV only.
Btw is it by design that reduced CV is also shown for no CV games when both options are enabled?
Comment has been collapsed.
Thanks, I know how to fix it now.
Yes, games aren't added to both lists at the same date, so it makes sense to show both, just like on the new giveaway page.
Comment has been collapsed.
Mine (Full/Reduced/No CV):
"gc_categories": ["gc_gi", "gc_r", "gc_fcv", "gc_rcv", "gc_ncv", "gc_fcv", "gc_rcv", "gc_ncv", "gc_h", "gc_i", "gc_o", "gc_w", "gc_a", "gc_mp", "gc_sc", "gc_tc", "gc_l", "gc_m", "gc_ea", "gc_rm", "gc_dlc", "gc_p", "gc_g"],
Comment has been collapsed.
No, and I don't really want to implement one. How long is it taking for you? It takes around 2 seconds for me, I believe that's not that long.
Comment has been collapsed.
When you first load a page or when you refresh it?
Comment has been collapsed.
I have no idea what a will-change memory is, will have to look into it later. Could it be a conflict from another script/theme?
Comment has been collapsed.
Are you sure your hidden giveaways didn't just end?
Comment has been collapsed.
450 Comments - Last post 46 minutes ago by klingki
29 Comments - Last post 3 hours ago by adam1224
7 Comments - Last post 4 hours ago by xXSAFOXx
16,297 Comments - Last post 6 hours ago by SebastianCrenshaw
52 Comments - Last post 7 hours ago by adam1224
206 Comments - Last post 10 hours ago by Joey2741
31 Comments - Last post 11 hours ago by Pika8
280 Comments - Last post 2 minutes ago by IgotElbows
44 Comments - Last post 10 minutes ago by alancml
43 Comments - Last post 35 minutes ago by venturercatt
13 Comments - Last post 48 minutes ago by Azaltir
7,978 Comments - Last post 49 minutes ago by hbarkas
727 Comments - Last post 58 minutes ago by eeev
104 Comments - Last post 1 hour ago by Axelflox
Enhanced SteamGifts & SteamTrades (ESGST)
An extension / userscript that adds some cool features to SteamGifts and SteamTrades.
If you find any bugs or have any feature requests, please file an issue here.
Compatibility
Tested and confirmed as working:
Not tested but should be working:
Not supported:
Installation
There are two different ways to use ESGST: extension or userscript. You can choose which one you want to use, but the extension is a lot faster and has a better peformance than the userscript, so I recommend it, although there is no major difference between them, except for a few options that are only available in the extension because of limitations in the userscript.
Option 1 - Extension
It should be possible to install the extension in any Chromium-based browser from the Chrome store (such as Opera, Vivaldi, etc...), any Firefox-based browser from the Firefox store (such as Waterfox, etc...), and any browser that uses the Phoebus system from the Pale Moon store (such as Basilik, etc...).
You can also use the extension on Android through Firefox for Android, but some features might not work or not be optimized enough for mobile.
Option 2 - Userscript
To install the userscript, you must install Violentmonkey, Tampermonkey, Greasemonkey or some other userscript manager first. Then click here and you should be prompted to install it. I recommend Violentmonkey or Tampermonkey, because the userscript uses the GM_addValueChangeListener API to communicate changes in the storage between tabs, and that API is not available on Greasemonkey, so a polyfill is used for Greasemonkey, which is not very effective and can affect the performance.
You can also use the userscript on Android through Firefox with Violentmonkey or USI, but some features might not work or not be optimized enough for mobile.
Beta Versions
The latest beta version for both the extension and the userscript is always available in the latest pre-release in the releases page.
Comment has been collapsed.